[opti] global: fix function-args-by-ref & function-args-by-value

https://github.com/KDE/clazy/blob/master/docs/checks/README-function-args-by-ref.md & https://github.com/KDE/clazy/blob/master/docs/checks/README-function-args-by-value.md

Author: bgallois

src/batch.cpp

@@ -335,7 +335,7 @@ void Batch::openPathBackground(int row) {
  * @arg[in] pathBackground Path to the background image.
  * @arg[in] pathParameter Path to the parameter file.
  */
-void Batch::addPath(QString pathMovie, QString pathBackground, QString pathParameter) {
+void Batch::addPath(const QString &pathMovie, const QString &pathBackground, const QString &pathParameter) {
   int row = ui->tablePath->rowCount();
   ui->tablePath->insertRow(row);
   ui->tablePath->setItem(row, 0, new QTableWidgetItem(pathMovie));
@@ -542,7 +542,7 @@ void Batch::openParameterFile(int row) {
 /**
  * @brief Reads a parameter file, updates parameters.
  */
-bool Batch::loadParameterFile(QString path) {
+bool Batch::loadParameterFile(const QString &path) {
   QFile parameterFile(path);
   if (parameterFile.open(QIODevice::ReadOnly | QIODevice::Text)) {
     QTextStream in(&parameterFile);

src/batch.h

@@ -88,11 +88,11 @@ class Batch : public QWidget {
   void startTracking();
   void openPathFolder();
   void openPathBackground(int);
-  void addPath(QString, QString, QString);
+  void addPath(const QString &, const QString &, const QString &);
   void removePath();
   void removePath(int index);
   void updateParameterTable();
-  bool loadParameterFile(QString path);
+  bool loadParameterFile(const QString &path);
   void openParameterFile(int);
 
   void errors(int code);

src/fasttrack-cli.cpp

@@ -28,7 +28,7 @@ This file is part of Fast Track.
 
 using namespace std;
 
-void loadConfig(QString path, QMap<QString, QString> &parameters) {
+void loadConfig(const QString &path, QMap<QString, QString> &parameters) {
   QFile parameterFile(path);
   if (parameterFile.open(QIODevice::ReadOnly | QIODevice::Text)) {
     QTextStream in(&parameterFile);
@@ -246,7 +246,7 @@ int main(int argc, char **argv) {
   QObject::connect(tracking, &Tracking::finished, []() {
     cout << "Tracking ended normally" << endl;
   });
-  QObject::connect(tracking, &Tracking::forceFinished, [](QString message) {
+  QObject::connect(tracking, &Tracking::forceFinished, [](const QString &message) {
     cout << message.toStdString() << endl;
   });
 

src/interactive.cpp

@@ -108,7 +108,7 @@ Interactive::Interactive(QWidget *parent) : QMainWindow(parent),
   });
   ui->menuView->addAction(replayAction);
 
-  connect(ui->slider, &Timeline::valueChanged, this, [this](const int &newValue) {
+  connect(ui->slider, &Timeline::valueChanged, this, [this](int newValue) {
     int index = ui->interactiveTab->currentIndex();
     if (index == 0) {
       display(newValue);
@@ -371,7 +371,7 @@ Interactive::Interactive(QWidget *parent) : QMainWindow(parent),
   });
   connect(ui->actionAboutQt, &QAction::triggered, qApp, &QApplication::aboutQt);
 
-  connect(this, &Interactive::message, this, [this](QString msg) {
+  connect(this, &Interactive::message, this, [this](const QString &msg) {
     QMessageBox msgBox;
     msgBox.setIcon(QMessageBox::Critical);
     msgBox.setText(QStringLiteral("Error"));
@@ -912,7 +912,7 @@ void Interactive::previewTracking() {
       replay->loadReplay(dir);
       replayAction->setChecked(true);
     });
-    connect(tracking, &Tracking::forceFinished, this, [this](QString errorMessage) {
+    connect(tracking, &Tracking::forceFinished, this, [this](const QString &errorMessage) {
       ui->slider->setDisabled(false);
       ui->previewButton->setDisabled(false);
       ui->trackButton->setDisabled(false);
@@ -1193,14 +1193,14 @@ void Interactive::level() {
       autolevel->moveToThread(thread);
 
       connect(thread, &QThread::started, autolevel, &AutoLevel::level);
-      connect(autolevel, &AutoLevel::forceFinished, this, [this](QString errorMessage) {
+      connect(autolevel, &AutoLevel::forceFinished, this, [this](const QString &errorMessage) {
         this->setEnabled(true);
         emit message(errorMessage);
       });
       connect(autolevel, &AutoLevel::finished, this, [this]() {
         this->setEnabled(true);
       });
-      connect(autolevel, &AutoLevel::levelParametersChanged, this, [this](QMap<QString, double> levelParameters) {
+      connect(autolevel, &AutoLevel::levelParametersChanged, this, [this](const QMap<QString, double> &levelParameters) {
         ui->maxT->setValue(levelParameters.value(QStringLiteral("normAngle")));
         ui->maxL->setValue(levelParameters.value(QStringLiteral("normDist")));
         ui->normArea->setValue(levelParameters.value(QStringLiteral("normArea")));
@@ -1227,7 +1227,7 @@ void Interactive::level() {
 /**
  * @brief Reads a parameter file, updates parameters.
  */
-void Interactive::loadParameters(QString path) {
+void Interactive::loadParameters(const QString &path) {
   QFile parameterFile(path);
   if (parameterFile.open(QIODevice::ReadOnly | QIODevice::Text)) {
     QTextStream in(&parameterFile);

src/interactive.h

@@ -99,7 +99,7 @@ class Interactive : public QMainWindow {
   void reset();
 
   void saveSettings();
-  void loadParameters(QString path);
+  void loadParameters(const QString &path);
   void level();
 
  private:

src/mainwindow.cpp

@@ -116,14 +116,14 @@ MainWindow::MainWindow(QWidget *parent) : QMainWindow(parent),
 
   interactive = new Interactive(this);
   ui->tabWidget->addTab(interactive, tr("Interactive tracking"));
-  connect(interactive, &Interactive::status, this, [this](QString message) {
+  connect(interactive, &Interactive::status, this, [this](const QString &message) {
     trayIcon->showMessage(QStringLiteral("FastTrack"), message, QSystemTrayIcon::Information, 3000);
   });
   connect(interactive, &Interactive::modeChanged, this, &MainWindow::setMode);
 
   batch = new Batch(this);
   ui->tabWidget->addTab(batch, tr("Batch tracking"));
-  connect(batch, &Batch::status, this, [this](QString message) {
+  connect(batch, &Batch::status, this, [this](const QString &message) {
     trayIcon->showMessage(QStringLiteral("FastTrack"), message, QSystemTrayIcon::Information, 3000);
   });
 

src/tracking.cpp

@@ -818,7 +818,7 @@ void Tracking::imageProcessing() {
  * @param[in] startImage Index of the beginning image.
  * @param[in] stopImage Index of the ending image.
  */
-Tracking::Tracking(string path, string backgroundPath, int startImage, int stopImage) : m_path{path}, m_backgroundPath{backgroundPath}, video{new VideoReader(m_path)}, m_startImage{startImage}, m_stopImage{stopImage}, connectionName{QString("tracking_%1").arg(QRandomGenerator::global()->generate())} {
+Tracking::Tracking(const string &path, const string &backgroundPath, int startImage, int stopImage) : m_path{path}, m_backgroundPath{backgroundPath}, video{new VideoReader(m_path)}, m_startImage{startImage}, m_stopImage{stopImage}, connectionName{QString("tracking_%1").arg(QRandomGenerator::global()->generate())} {
 }
 
 /**
@@ -828,7 +828,7 @@ Tracking::Tracking(string path, string backgroundPath, int startImage, int stopI
  * @param[in] startImage Index of the beginning image.
  * @param[in] stopImage Index of the ending image.
  */
-Tracking::Tracking(string path, UMat background, int startImage, int stopImage) : m_path{path}, m_background{background}, video{new VideoReader(m_path)}, m_startImage{startImage}, m_stopImage{stopImage}, connectionName{QString("tracking_%1").arg(QRandomGenerator::global()->generate())} {
+Tracking::Tracking(const string &path, const UMat &background, int startImage, int stopImage) : m_path{path}, m_background{background}, video{new VideoReader(m_path)}, m_startImage{startImage}, m_stopImage{stopImage}, connectionName{QString("tracking_%1").arg(QRandomGenerator::global()->generate())} {
 }
 
 /**
@@ -946,7 +946,7 @@ void Tracking::startProcess() {
       throw std::runtime_error("Can't write log to the disk!");
     }
     else {
-      connect(this, &Tracking::forceFinished, [this](QString message) {
+      connect(this, &Tracking::forceFinished, [this](const QString &message) {
         QTextStream out(&m_logFile);
         out << QDate::currentDate().toString(QStringLiteral("dd-MMM-yyyy-")) + QTime::currentTime().toString(QStringLiteral("hh-mm-ss")) + '\t' + message.toLower() + '\n';
       });
@@ -1028,7 +1028,7 @@ Tracking::~Tracking() {
  * @param[in] path The path to a folder where to write the text file.
  * @param[in] db The database where tracking results are stored already opened.
  */
-bool Tracking::exportTrackingResult(const QString path, QSqlDatabase db) {
+bool Tracking::exportTrackingResult(const QString &path, const QSqlDatabase &db) {
   QFile outputFile(path + "/tracking.txt");
   if (!outputFile.open(QFile::WriteOnly | QFile::Text)) {
     return false;
@@ -1061,7 +1061,7 @@ bool Tracking::exportTrackingResult(const QString path, QSqlDatabase db) {
  * @param[in] path The path to a folder where to write the text file.
  * @param[in] db The database where tracking results are stored already opened.
  */
-bool Tracking::importTrackingResult(const QString path, QSqlDatabase db) {
+bool Tracking::importTrackingResult(const QString &path, QSqlDatabase db) {
   QFile file(path + "/tracking.txt");
   if (!file.open(QFile::ReadOnly | QFile::Text)) {
     return false;

src/tracking.h

@@ -110,8 +110,8 @@ class Tracking : public QObject {
 
  public:
   Tracking() = default;
-  Tracking(string path, string background, int startImage = 0, int stopImage = -1);
-  Tracking(string path, UMat background, int startImage = 0, int stopImage = -1);
+  Tracking(const string &path, const string &background, int startImage = 0, int stopImage = -1);
+  Tracking(const string &path, const UMat &background, int startImage = 0, int stopImage = -1);
   Tracking(const Tracking &) = delete;
   Tracking &operator=(const Tracking &) = delete;
   ~Tracking();
@@ -133,8 +133,8 @@ class Tracking : public QObject {
   static UMat backgroundExtraction(VideoReader &video, int n, const int method, const int registrationMethod);
   static void registration(UMat imageReference, UMat &frame, int method);
   static void binarisation(UMat &frame, char backgroundColor, int value);
-  static bool exportTrackingResult(const QString path, QSqlDatabase db);
-  static bool importTrackingResult(const QString path, QSqlDatabase db);
+  static bool exportTrackingResult(const QString &path, const QSqlDatabase &db);
+  static bool importTrackingResult(const QString &path, QSqlDatabase db);
 
   UMat m_binaryFrame;                /*!< Binary image CV_8U */
   UMat m_visuFrame;                  /*!< Image 8 bit CV_8U */

src/trackingmanager.cpp

@@ -88,7 +88,7 @@ void TrackingManager::addLogEntry(QMap<QString, QString> log) {
  * @param[in] path QString that contains the path to the output file.
  * @param[in] line QMap that contains the log entry.
  */
-void TrackingManager::appendToFile(QString path, QMap<QString, QString> line) {
+void TrackingManager::appendToFile(const QString &path, const QMap<QString, QString> &line) {
   QFile file(path);
   if (file.open(QIODevice::Append)) {
     QDataStream out(&file);
@@ -101,7 +101,7 @@ void TrackingManager::appendToFile(QString path, QMap<QString, QString> line) {
  * @param[in] path QString that contains the path to the output file.
  * @param[in] lines QList ofQMap that contains log entries.
  */
-void TrackingManager::writeToFile(QString path, QList<QMap<QString, QString>> lines) {
+void TrackingManager::writeToFile(const QString &path, const QList<QMap<QString, QString>> &lines) {
   QFile file(path);
   if (file.open(QIODevice::WriteOnly)) {
     QDataStream out(&file);
@@ -115,7 +115,7 @@ void TrackingManager::writeToFile(QString path, QList<QMap<QString, QString>> li
  * @brief Reads a log file.
  * @param[in] path QString that contains the path to the input file.
  */
-void TrackingManager::readFromFile(QString path) {
+void TrackingManager::readFromFile(const QString &path) {
   QFile file(path);
   if (file.open(QIODevice::ReadOnly)) {
     QDataStream in(&file);

src/trackingmanager.h

@@ -45,9 +45,9 @@ class TrackingManager : public QWidget {
 
  public slots:
   void addLogEntry(QMap<QString, QString> log);
-  void appendToFile(QString path, QMap<QString, QString> line);
-  void writeToFile(QString path, QList<QMap<QString, QString>> lines);
-  void readFromFile(QString path);
+  void appendToFile(const QString &path, const QMap<QString, QString> &line);
+  void writeToFile(const QString &path, const QList<QMap<QString, QString>> &lines);
+  void readFromFile(const QString &path);
 };
 
 #endif  // TRACKINGMANAGER_H