You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 79a9368
Browse filesBrowse the repository at this point in the historyBrowse files
feat(input): a selected note in its voice's colour, the above-staff ruler, re-pitch, intervals below (#123)
The differences from MuseScore's handbook left in the three input modes,
each checked against [Entering notes and
rests](https://handbook.musescore.org/basics/entering-notes-and-rests),
[Input by duration
mode](https://handbook.musescore.org/basics/input-by-duration-mode),
[Alternative note input
methods](https://handbook.musescore.org/basics/alternative-note-input-methods)
and [Working with multiple
voices](https://handbook.musescore.org/basics/working-with-multiple-voices).
## A selected note in its voice's colour
The handbook: "notes and rests … will be highlighted in the color of
their respective voice when you select them."
- **Engraver:** the layout marks each lower voice's notes and rests with
their voice (`SceneNode::set_voice` in `add_lower_voices`), and
`Selectable::voice` carries it.
- **View:** the selection layer draws each voice in its colour. Voice
1's is the selection colour; voices 2 to 4 are green, orange and pink
unless the theme sets `chart.voice2`…`4`.
- **A click on another voice's note or rest** selects that voice's
element in note input too (`ChartGesture::Click::voice`,
`KEYFLOW_INPUT_MOVE {voice}`). The status line ("Rest · half · voice 2 ·
bar 1, beat 3") and the next key act on it. Before, the click selected
voice 1's note at that beat as well.
- **Fixed in passing:** normal mode no longer draws a sliver of the
note-input cursor at the bar's start.
## Input by duration: the above-staff ruler
The handbook's preference, "Input by duration mode cursor: choose
whether to show the above staff ruler or the classic note entry cursor".
Its figure shows the ruler: a pin in the voice's colour over where the
next note goes, and a tick each duration on to the barline. That is now
input by duration's cursor; `KEYFLOW_DURATION_RULER` switches back to
the box.
## Re-pitch (⇧⌘I)
"The Re-pitch note input method allows you to change the pitches of a
sequence of notes while leaving their durations unaltered."
`KEYFLOW_REPITCH`, ⇧⌘I (Ctrl+Shift+I off a Mac):
- In input by note name, a letter gives the note at the cursor that
pitch, its length and ties kept, and moves on to the next note, past
rests.
- Not by mouse, as in MuseScore.
- The status line says it's on.
## Intervals below
"For intervals below the selected note, you can apply a custom shortcut
of your own." `KEYFLOW_INTERVAL_BELOW_1`–`9` add a note that interval
under the chord's lowest note, spelled in the key. They have no key by
default and can be bound in the action list.
## Not built, and why
- **Real-time input** (automatic and manual): it needs a MIDI keyboard
and a metronome, and Keyflow's chart has no MIDI input.
- **Insert:** it grows a bar past its time signature (MuseScore shows a
"+" over the measure). A Keyflow bar's length is its meter's, so an
insert would have to push notes into the next bar, which is a different
operation.
## Checked in the app
Isolated Architect `main` `48d3894e`:
- voice 2's rest selected in green;
- the ruler in input by duration;
- re-pitch: E G C became A G F with lengths kept (`A:24 G:24 F:22`).
Recordings of all three modes with these are on
[`pr-media`](https://github.com/FastTrackStudios/keyflow/blob/pr-media/chart-selection-and-input-modes/README.md#round-7-the-input-modes-with-musescores-remaining-behaviours),
in `recording/round7/`.
## Tests
- **New:**
- `each_note_and_rest_knows_its_voice` (engraver);
- `re_pitch_changes_the_notes_pitches_and_keeps_their_rhythm`;
- intervals below in
`alt_number_adds_an_interval_above_the_chord_in_the_key`.
- **Manifest test:** checks every key, ⇧⌘I included. Actions without a
default key are left out of the keys.
- **`just ci`:** passes (2,625 passed, 51 skipped). No `Cargo.lock`
change.
Copy file name to clipboardExpand all lines: features/extension/extension.toml
+89-2Lines changed: 89 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -411,10 +411,10 @@ effect = "mutating"
411
411
[[actions]]
412
412
id = "KEYFLOW_INPUT_MOVE"
413
413
name = "Keyflow: move the input cursor"
414
-
description = "The note-input cursor to the note, rest or chord at `fraction` (0 to 1) across bar `bar` (the chart's bars from 0), selecting it: what a click on the chart does. `target` (`chords`, `notes`) says which line; `select: false` moves without selecting."
414
+
description = "The note-input cursor to the note, rest or chord at `fraction` (0 to 1) across bar `bar` (the chart's bars from 0), selecting it: what a click on the chart does. `target` (`chords`, `notes`) says which line; `select: false` moves without selecting; `voice` (0 to 3), the voice of the note or rest clicked, which note input then enters into."
@@ -634,6 +634,83 @@ description = "A note a ninth above the selected note's chord (its top note) add
634
634
group = "Keyflow"
635
635
effect = "mutating"
636
636
637
+
[[actions]]
638
+
id = "KEYFLOW_INTERVAL_BELOW_1"
639
+
name = "Keyflow: add unison below"
640
+
description = "A note a unison below the selected note's chord (its lowest note) added to it, spelled in the key: MuseScore's add interval below. No key by default; bind one in the action list."
641
+
group = "Keyflow"
642
+
effect = "mutating"
643
+
644
+
[[actions]]
645
+
id = "KEYFLOW_INTERVAL_BELOW_2"
646
+
name = "Keyflow: add second below"
647
+
description = "A note a second below the selected note's chord (its lowest note) added to it, spelled in the key: MuseScore's add interval below. No key by default; bind one in the action list."
648
+
group = "Keyflow"
649
+
effect = "mutating"
650
+
651
+
[[actions]]
652
+
id = "KEYFLOW_INTERVAL_BELOW_3"
653
+
name = "Keyflow: add third below"
654
+
description = "A note a third below the selected note's chord (its lowest note) added to it, spelled in the key: MuseScore's add interval below. No key by default; bind one in the action list."
655
+
group = "Keyflow"
656
+
effect = "mutating"
657
+
658
+
[[actions]]
659
+
id = "KEYFLOW_INTERVAL_BELOW_4"
660
+
name = "Keyflow: add fourth below"
661
+
description = "A note a fourth below the selected note's chord (its lowest note) added to it, spelled in the key: MuseScore's add interval below. No key by default; bind one in the action list."
662
+
group = "Keyflow"
663
+
effect = "mutating"
664
+
665
+
[[actions]]
666
+
id = "KEYFLOW_INTERVAL_BELOW_5"
667
+
name = "Keyflow: add fifth below"
668
+
description = "A note a fifth below the selected note's chord (its lowest note) added to it, spelled in the key: MuseScore's add interval below. No key by default; bind one in the action list."
669
+
group = "Keyflow"
670
+
effect = "mutating"
671
+
672
+
[[actions]]
673
+
id = "KEYFLOW_INTERVAL_BELOW_6"
674
+
name = "Keyflow: add sixth below"
675
+
description = "A note a sixth below the selected note's chord (its lowest note) added to it, spelled in the key: MuseScore's add interval below. No key by default; bind one in the action list."
676
+
group = "Keyflow"
677
+
effect = "mutating"
678
+
679
+
[[actions]]
680
+
id = "KEYFLOW_INTERVAL_BELOW_7"
681
+
name = "Keyflow: add seventh below"
682
+
description = "A note a seventh below the selected note's chord (its lowest note) added to it, spelled in the key: MuseScore's add interval below. No key by default; bind one in the action list."
683
+
group = "Keyflow"
684
+
effect = "mutating"
685
+
686
+
[[actions]]
687
+
id = "KEYFLOW_INTERVAL_BELOW_8"
688
+
name = "Keyflow: add octave below"
689
+
description = "A note an octave below the selected note's chord (its lowest note) added to it, spelled in the key: MuseScore's add interval below. No key by default; bind one in the action list."
690
+
group = "Keyflow"
691
+
effect = "mutating"
692
+
693
+
[[actions]]
694
+
id = "KEYFLOW_INTERVAL_BELOW_9"
695
+
name = "Keyflow: add ninth below"
696
+
description = "A note a ninth below the selected note's chord (its lowest note) added to it, spelled in the key: MuseScore's add interval below. No key by default; bind one in the action list."
697
+
group = "Keyflow"
698
+
effect = "mutating"
699
+
700
+
[[actions]]
701
+
id = "KEYFLOW_REPITCH"
702
+
name = "Keyflow: re-pitch"
703
+
description = "MuseScore's re-pitch method, on or off (Cmd+Shift+I): in input by note name, a letter gives the note at the cursor that pitch, its length kept, and moves on to the next note, past rests."
704
+
group = "Keyflow"
705
+
effect = "mutating"
706
+
707
+
[[actions]]
708
+
id = "KEYFLOW_DURATION_RULER"
709
+
name = "Keyflow: input by duration cursor (ruler or box)"
710
+
description = "Input by duration's cursor switched between MuseScore's above-staff ruler (a pin where the next note goes and a tick a duration on to the barline; the default) and the classic box cursor, as MuseScore's Preferences → Note input chooses."
0 commit comments