You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit ca834b4
Browse filesBrowse the repository at this point in the historyBrowse files
feat(extension): a chart reopened comes back at its zoom, scroll and selection (#130)
Walkthrough rough edge 9, the top of the stack.
A chart's view was kept by its pane (`use_view_state`, #107), so it
outlived a reload but not the pane. Closed and opened again, the chart
came back fitted to the width with nothing selected.
- **Writing:** each chart's view (zoom, scroll, selection) is now also
kept by its path in the extension's data (`HostRequest::SetData`, key
`view:<path>`). It's written when it changes, and only once the chart's
kept view has been given back, so a fresh pane can't write its defaults
over it.
- **Restoring:** a pane that opens the chart with no place of its own
for it gets that view back.
**Checked in the app:** *Drive To LA* at 130%, scroll (60, 150), a chord
selected, then the pane closed and the chart opened again came back at
130%, (60, 150), with the chord selected.
**`just ci` on this layer, the stack's top:** 2,627 passed, 51 skipped.
0 commit comments