Repository navigation
Commit cdb4181
authored
feat(edit): J respells the selected note; normal mode's status line describes the selection (#119)
Two more differences from MuseScore's handbook closed, after #118.
## Closed
- **Respell (J):** `KEYFLOW_RESPELL`, J in the chart's view. The
selected note is spelled the next way that sounds the same, the plainest
first: C♯ → D♭ → B𝄪 → C♯, E → F♭ → D𝄪 → E (`Pitch::respelled`). The
handbook: "To change the enharmonic spelling of a selected note, press
J."
- **The status line describes the selection,** as MuseScore's status bar
does. In normal mode it names what is selected:
- a note, a chord of notes with its pitches, a rest, or a chord symbol;
- its duration and voice;
- its bar and beat.
For example: "Normal mode · Note G♭3 · quarter · voice 1 · bar 1, beat
4". It used to say only "bar N selected".
## Checked in the app
Isolated Architect `main` `48d3894e`: F♯ entered, J made it G♭, and Esc
showed the description above. It's in the round 6 recordings on
[`pr-media`](https://github.com/FastTrackStudios/keyflow/blob/pr-media/chart-selection-and-input-modes/README.md#round-6-the-three-input-modes)
(`recording/round6/`).
## What still differs from the handbook
- **Selection colour:** a note selected outside note input takes the
theme's selection colour, not its voice's, because the chart's selection
doesn't know an element's voice yet. While entering, the entered note is
in the voice's colour.
- **Not built:** intervals below (no default key in the handbook), the
above-staff ruler for input by duration, and re-pitch, real-time and
insert input.
- **Input via Keyflow syntax** is Keyflow's own mode; MuseScore has no
counterpart.
## Tests
- **New:**
`j_respells_the_selected_note_the_next_way_that_sounds_the_same` and
`normal_mode_s_status_line_describes_the_selection`. The manifest test
checks J is bound in the chart's view.
- **`just ci`:** passes (2,616 passed, 51 skipped).4 files changed
Lines changed: 142 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
564 | 564 | | |
565 | 565 | | |
566 | 566 | | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
567 | 574 | | |
568 | 575 | | |
569 | 576 | | |
| |||
1278 | 1285 | | |
1279 | 1286 | | |
1280 | 1287 | | |
| 1288 | + | |
| 1289 | + | |
| 1290 | + | |
| 1291 | + | |
| 1292 | + | |
1281 | 1293 | | |
1282 | 1294 | | |
1283 | 1295 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
381 | 381 | | |
382 | 382 | | |
383 | 383 | | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
384 | 387 | | |
385 | 388 | | |
386 | 389 | | |
| |||
475 | 478 | | |
476 | 479 | | |
477 | 480 | | |
| 481 | + | |
478 | 482 | | |
479 | 483 | | |
480 | 484 | | |
| |||
723 | 727 | | |
724 | 728 | | |
725 | 729 | | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
726 | 736 | | |
727 | 737 | | |
728 | 738 | | |
| |||
1396 | 1406 | | |
1397 | 1407 | | |
1398 | 1408 | | |
| 1409 | + | |
| 1410 | + | |
| 1411 | + | |
| 1412 | + | |
| 1413 | + | |
| 1414 | + | |
| 1415 | + | |
| 1416 | + | |
| 1417 | + | |
| 1418 | + | |
| 1419 | + | |
| 1420 | + | |
| 1421 | + | |
| 1422 | + | |
| 1423 | + | |
| 1424 | + | |
| 1425 | + | |
| 1426 | + | |
| 1427 | + | |
| 1428 | + | |
| 1429 | + | |
| 1430 | + | |
| 1431 | + | |
| 1432 | + | |
| 1433 | + | |
| 1434 | + | |
| 1435 | + | |
| 1436 | + | |
| 1437 | + | |
| 1438 | + | |
| 1439 | + | |
| 1440 | + | |
| 1441 | + | |
| 1442 | + | |
| 1443 | + | |
| 1444 | + | |
| 1445 | + | |
| 1446 | + | |
| 1447 | + | |
| 1448 | + | |
| 1449 | + | |
| 1450 | + | |
| 1451 | + | |
| 1452 | + | |
| 1453 | + | |
| 1454 | + | |
| 1455 | + | |
| 1456 | + | |
| 1457 | + | |
| 1458 | + | |
| 1459 | + | |
| 1460 | + | |
| 1461 | + | |
| 1462 | + | |
| 1463 | + | |
| 1464 | + | |
1399 | 1465 | | |
1400 | 1466 | | |
1401 | 1467 | | |
| |||
1448 | 1514 | | |
1449 | 1515 | | |
1450 | 1516 | | |
1451 | | - | |
1452 | | - | |
| 1517 | + | |
| 1518 | + | |
1453 | 1519 | | |
1454 | 1520 | | |
1455 | 1521 | | |
| |||
1465 | 1531 | | |
1466 | 1532 | | |
1467 | 1533 | | |
1468 | | - | |
| 1534 | + | |
1469 | 1535 | | |
1470 | 1536 | | |
1471 | 1537 | | |
| |||
1620 | 1686 | | |
1621 | 1687 | | |
1622 | 1688 | | |
| 1689 | + | |
| 1690 | + | |
| 1691 | + | |
| 1692 | + | |
| 1693 | + | |
| 1694 | + | |
| 1695 | + | |
| 1696 | + | |
| 1697 | + | |
| 1698 | + | |
| 1699 | + | |
| 1700 | + | |
| 1701 | + | |
| 1702 | + | |
| 1703 | + | |
| 1704 | + | |
| 1705 | + | |
| 1706 | + | |
| 1707 | + | |
| 1708 | + | |
| 1709 | + | |
| 1710 | + | |
| 1711 | + | |
| 1712 | + | |
| 1713 | + | |
| 1714 | + | |
| 1715 | + | |
| 1716 | + | |
| 1717 | + | |
| 1718 | + | |
| 1719 | + | |
| 1720 | + | |
| 1721 | + | |
1623 | 1722 | | |
1624 | 1723 | | |
1625 | 1724 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
257 | 257 | | |
258 | 258 | | |
259 | 259 | | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
260 | 287 | | |
261 | 288 | | |
262 | 289 | | |
| |||
0 commit comments