Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize handling of JsonPointer.head() #1328

Closed
cowtowncoder opened this issue Sep 6, 2024 · 0 comments
Closed

Optimize handling of JsonPointer.head() #1328

cowtowncoder opened this issue Sep 6, 2024 · 0 comments
Labels
2.19 Issues planned at earliest for 2.19 performance Issue related to performance problems or enhancements
Milestone
2.19.0

Comments

@cowtowncoder
Copy link
Member

(note: this is a placeholder for reported but not verified performance concern)

Looks like implementation of JsonPointer.head() could be problematic for deeply nested pointer instances: and while this is unlikely to be of general security concern, it could be problematic for legitimate use. And as per comments in class, optimization already considered earlier... so let's see how easy it's to do.
@cowtowncoder cowtowncoder added 2.18 Issues planned at earliest for 2.18 performance Issue related to performance problems or enhancements labels Sep 6, 2024
cowtowncoder added a commit that referenced this issue Sep 6, 2024
@cowtowncoder
Add failing test for #1328
561ffaf
cowtowncoder added a commit that referenced this issue Sep 6, 2024
@cowtowncoder
Add failing test for #1328 (#1329)
67ec34b
cowtowncoder added a commit that referenced this issue Oct 31, 2024
@cowtowncoder
Fix #1328: optimize JsonPointer.head()
646aebe
@cowtowncoder cowtowncoder added 2.19 Issues planned at earliest for 2.19 and removed 2.18 Issues planned at earliest for 2.18 labels Oct 31, 2024
@cowtowncoder cowtowncoder added this to the 2.19.0 milestone Oct 31, 2024
cowtowncoder added a commit that referenced this issue Oct 31, 2024
@cowtowncoder
Move now passing #1328 test to non-failing package
8823774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.19 Issues planned at earliest for 2.19 performance Issue related to performance problems or enhancements
Projects
None yet
Milestone
2.19.0
Development

No branches or pull requests
1 participant
@cowtowncoder