|
| 1 | +package tools.jackson.databind.deser.enums; |
| 2 | + |
| 3 | +import org.junit.jupiter.api.Test; |
| 4 | + |
| 5 | +import com.fasterxml.jackson.annotation.JsonAlias; |
| 6 | +import com.fasterxml.jackson.annotation.JsonValue; |
| 7 | + |
| 8 | +import tools.jackson.databind.*; |
| 9 | + |
| 10 | +import static org.junit.jupiter.api.Assertions.assertEquals; |
| 11 | + |
| 12 | +import static tools.jackson.databind.testutil.DatabindTestUtil.a2q; |
| 13 | +import static tools.jackson.databind.testutil.DatabindTestUtil.newJsonMapper; |
| 14 | +import static tools.jackson.databind.testutil.DatabindTestUtil.q; |
| 15 | + |
| 16 | +// [databind#6210]: `@JsonAlias` ignored on Enum values if `@JsonValue` is present |
| 17 | +public class EnumAliasWithJsonValue6210Test |
| 18 | +{ |
| 19 | + enum Versus6210 { |
| 20 | + @JsonAlias({ "A", "B" }) |
| 21 | + BUY("B"), |
| 22 | + @JsonAlias({ "V", "S" }) |
| 23 | + SELL("S"); |
| 24 | + |
| 25 | + private final String value; |
| 26 | + |
| 27 | + Versus6210(String value) { |
| 28 | + this.value = value; |
| 29 | + } |
| 30 | + |
| 31 | + @JsonValue |
| 32 | + public String getValue() { |
| 33 | + return value; |
| 34 | + } |
| 35 | + } |
| 36 | + |
| 37 | + // Aliases that collide with `@JsonValue` ids of other values, and each other |
| 38 | + enum Colliding6210 { |
| 39 | + @JsonAlias({ "b" }) |
| 40 | + ALPHA("a"), |
| 41 | + @JsonAlias({ "a", "x" }) |
| 42 | + BETA("b"), |
| 43 | + @JsonAlias({ "x" }) |
| 44 | + GAMMA("c"); |
| 45 | + |
| 46 | + private final String value; |
| 47 | + |
| 48 | + Colliding6210(String value) { |
| 49 | + this.value = value; |
| 50 | + } |
| 51 | + |
| 52 | + @JsonValue |
| 53 | + public String getValue() { |
| 54 | + return value; |
| 55 | + } |
| 56 | + } |
| 57 | + |
| 58 | + enum IntValued6210 { |
| 59 | + @JsonAlias({ "one" }) |
| 60 | + FIRST(1), |
| 61 | + @JsonAlias({ "two", "second" }) |
| 62 | + SECOND(2); |
| 63 | + |
| 64 | + private final int value; |
| 65 | + |
| 66 | + IntValued6210(int value) { |
| 67 | + this.value = value; |
| 68 | + } |
| 69 | + |
| 70 | + @JsonValue |
| 71 | + public int getValue() { |
| 72 | + return value; |
| 73 | + } |
| 74 | + } |
| 75 | + |
| 76 | + /* |
| 77 | + /********************************************************************** |
| 78 | + /* Test methods |
| 79 | + /********************************************************************** |
| 80 | + */ |
| 81 | + |
| 82 | + private final ObjectMapper MAPPER = newJsonMapper(); |
| 83 | + |
| 84 | + // [databind#6210] |
| 85 | + @Test |
| 86 | + public void aliasesWithJsonValue() throws Exception { |
| 87 | + ObjectReader r = MAPPER.readerFor(Versus6210.class); |
| 88 | + |
| 89 | + // First: values from `@JsonValue` accessor still work |
| 90 | + assertEquals(Versus6210.BUY, r.readValue(q("B"))); |
| 91 | + assertEquals(Versus6210.SELL, r.readValue(q("S"))); |
| 92 | + |
| 93 | + // and then aliases, which used to fail |
| 94 | + assertEquals(Versus6210.BUY, r.readValue(q("A"))); |
| 95 | + assertEquals(Versus6210.SELL, r.readValue(q("V"))); |
| 96 | + } |
| 97 | + |
| 98 | + // [databind#6210]: aliases must not override `@JsonValue`-provided ids |
| 99 | + @Test |
| 100 | + public void jsonValueWinsOverAlias() throws Exception { |
| 101 | + ObjectReader r = MAPPER.readerFor(Colliding6210.class); |
| 102 | + |
| 103 | + // "a" is id of ALPHA, alias of BETA; "b" id of BETA, alias of ALPHA |
| 104 | + assertEquals(Colliding6210.ALPHA, r.readValue(q("a"))); |
| 105 | + assertEquals(Colliding6210.BETA, r.readValue(q("b"))); |
| 106 | + assertEquals(Colliding6210.GAMMA, r.readValue(q("c"))); |
| 107 | + } |
| 108 | + |
| 109 | + // [databind#6210]: with duplicate aliases, first Enum value wins |
| 110 | + // (same as without `@JsonValue`) |
| 111 | + @Test |
| 112 | + public void firstAliasWinsForDuplicates() throws Exception { |
| 113 | + assertEquals(Colliding6210.BETA, MAPPER.readValue(q("x"), Colliding6210.class)); |
| 114 | + } |
| 115 | + |
| 116 | + // [databind#6210]: aliases are Strings even if `@JsonValue` is of int type |
| 117 | + @Test |
| 118 | + public void aliasesWithIntJsonValue() throws Exception { |
| 119 | + ObjectReader r = MAPPER.readerFor(IntValued6210.class); |
| 120 | + |
| 121 | + assertEquals(IntValued6210.FIRST, r.readValue("1")); |
| 122 | + assertEquals(IntValued6210.SECOND, r.readValue("2")); |
| 123 | + |
| 124 | + assertEquals(IntValued6210.FIRST, r.readValue(q("one"))); |
| 125 | + assertEquals(IntValued6210.SECOND, r.readValue(q("two"))); |
| 126 | + assertEquals(IntValued6210.SECOND, r.readValue(q("second"))); |
| 127 | + } |
| 128 | + |
| 129 | + // [databind#6210]: also verify Enum-as-Map-key path |
| 130 | + @Test |
| 131 | + public void aliasesWithJsonValueAsMapKey() throws Exception { |
| 132 | + java.util.Map<Versus6210, String> map = MAPPER.readValue( |
| 133 | + a2q("{'V':'x', 'B':'y'}"), |
| 134 | + MAPPER.getTypeFactory().constructMapType(java.util.LinkedHashMap.class, |
| 135 | + Versus6210.class, String.class)); |
| 136 | + assertEquals(2, map.size()); |
| 137 | + assertEquals("x", map.get(Versus6210.SELL)); |
| 138 | + assertEquals("y", map.get(Versus6210.BUY)); |
| 139 | + } |
| 140 | +} |
0 commit comments