-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primitive array deserializer not being captured by DeserializerModifier
#4216
Comments
SakuraKoi
added
the
to-evaluate
Issue that has been received but not yet evaluated
label
Nov 23, 2023
cowtowncoder
added
2.16
Issues planned for 2.16
and removed
to-evaluate
Issue that has been received but not yet evaluated
labels
Nov 23, 2023
Thank you for reporting this, @SakuraKoi . Definitely sounds like a bug, and reason you mentioned sounds accurate as well. |
I think fix should targeted to 2.16 branch, ideally for 2.16.1. |
Possible fix made by #4219, with update notes. Thank you for taking the time to analyze things, @SakuraKoi! |
cowtowncoder
changed the title
Primitive array deserializer cannot being captured by DeserializerModifier
Primitive array deserializer not being captured by Nov 26, 2023
DeserializerModifier
Fixed via #4219. Thank you @JooHyukKim for the fix, @SakuraKoi for reporting this! |
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this issue
Dec 27, 2023
### What changes were proposed in this pull request? This pr aims to upgrade jackson from 2.16.0 to 2.16.1 ### Why are the changes needed? The new version bring some fix: - [#4200](FasterXML/jackson-databind#4200): JsonSetter(contentNulls = FAIL) is ignored in delegating JsonCreator argument - [#4216](FasterXML/jackson-databind#4216): Primitive array deserializer not being captured by DeserializerModifier - [#4219](FasterXML/jackson-databind#4219): JsonNode.findValues() and findParents() missing expected values in 2.16.0 The full release notes as follows: - https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.16.1 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass Github Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #44494 from LuciferYang/SPARK-46508. Authored-by: yangjie01 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this issue
Aug 7, 2024
This pr aims to upgrade jackson from 2.16.0 to 2.16.1 The new version bring some fix: - [apache#4200](FasterXML/jackson-databind#4200): JsonSetter(contentNulls = FAIL) is ignored in delegating JsonCreator argument - [apache#4216](FasterXML/jackson-databind#4216): Primitive array deserializer not being captured by DeserializerModifier - [apache#4219](FasterXML/jackson-databind#4219): JsonNode.findValues() and findParents() missing expected values in 2.16.0 The full release notes as follows: - https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.16.1 No Pass Github Actions No Closes apache#44494 from LuciferYang/SPARK-46508. Authored-by: yangjie01 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Search before asking
Describe the bug
Since in createArrayDeserializer, primitive array deserializer is returned directly, the deserializer modifier is skipped and cannot capture these deserializers.
Version Information
2.16.0
Reproduction
Expected behavior
both the deserializer for field1 and field2 got captured by DeserializerModifier in the sample code
Additional context
No response
The text was updated successfully, but these errors were encountered: