WRITE_ENUMS_TO_LOWERCASE must use Locale.ROOT for case folding - #6010
Merged
cowtowncoder merged 4 commits intoMay 24, 2026
Merged
Conversation
Member
|
Whops. Merged concurrent changes that were meant to go in this PR directly in 3.x. |
Member
|
Thank you @dlwldnjs1009 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5994 (same root cause as #5993):
EnumFeature.WRITE_ENUMS_TO_LOWERCASElower-cased enum names with the JVM default
Locale, so under Turkish/Azeri localesIS_ADMINserialized asıs_admıninstead ofis_admin.#5994 applied
Locale.ROOTto theUPPER_SNAKE_CASE/LOWER_CASEnaming strategies;this extends the same fix to the enum lower-casing path.
Changes
EnumValuesToWrite._fetch: fold enum names withLocale.ROOT(live 3.x value/key path)EnumValues._findNameToUse: same fix for the deprecated helperEnumValuesis deprecated on 3.x and no longer used byEnumSerializerdirectly, but thiskeeps the still-public helper locale-stable and matches the 2.x path where
EnumValuesremains the live serialization/key path.
Testing
EnumSerializationTest.testEnumFeature_WRITE_ENUMS_TO_LOWERCASEUsesRootLocaleEnumValuesTest.testConstructFromNameLowerCasedWithRootLocale