Skip to content
This repository has been archived by the owner on Jan 22, 2019. It is now read-only.

Missing null writes when writing Object[] values #116

Closed
georgewfraser opened this issue Feb 15, 2016 · 5 comments
Closed

Missing null writes when writing Object[] values #116

georgewfraser opened this issue Feb 15, 2016 · 5 comments
Labels

Comments

@georgewfraser
Copy link
Contributor

When writing arrays to CSV, if there is a null, columns get written out of order. Reproduced in 2.7.1 with this test: https://gist.github.com/georgewfraser/164647fbaca61aadf9ee

Possibly related to #68

@georgewfraser georgewfraser changed the title Out-or-order columns Out-of-order columns Feb 15, 2016
@cowtowncoder
Copy link
Member

Thank you for reporting this, providing test case. Hope to look into this soon.

@cowtowncoder
Copy link
Member

I can reproduce this locally; looks like "all nulls" somehow does not work as expected.

@cowtowncoder
Copy link
Member

cowtowncoder commented Aug 19, 2016

More likely related to #106: looks like nulls for "array in array" are suppressed. This could be somewhat problematic even for other entries since "null value" would not get written.

@cowtowncoder cowtowncoder changed the title Out-of-order columns Missing null writes when writing Object[] values Aug 19, 2016
cowtowncoder added a commit that referenced this issue Aug 19, 2016
@cowtowncoder
Copy link
Member

This may be tricky to fix. The problem is that suppression serves a function (2 tests fail if it's removed), but I hope there's a way to refine heuristics further to support all usage -- perhaps by further separating output of the first column or something like that (and not just by "array in array" structure).

@cowtowncoder
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants