From d930a126a7cf3f13f7bceb1e417064ce79115287 Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Tue, 24 Aug 2021 04:43:11 +0100 Subject: [PATCH] getColumnDesc returns unpaired square bracket when columns are empty (#283) --- .../com/fasterxml/jackson/dataformat/csv/CsvSchema.java | 5 ++--- .../jackson/dataformat/csv/schema/CsvSchemaTest.java | 6 ++++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/csv/src/main/java/com/fasterxml/jackson/dataformat/csv/CsvSchema.java b/csv/src/main/java/com/fasterxml/jackson/dataformat/csv/CsvSchema.java index 9e7fdb2f..1c083351 100644 --- a/csv/src/main/java/com/fasterxml/jackson/dataformat/csv/CsvSchema.java +++ b/csv/src/main/java/com/fasterxml/jackson/dataformat/csv/CsvSchema.java @@ -1456,10 +1456,9 @@ public Column column(String name, int probableIndex) { public String getColumnDesc() { StringBuilder sb = new StringBuilder(100); + sb.append('['); for (Column col : _columns) { - if (sb.length() == 0) { - sb.append('['); - } else { + if (sb.length() > 1) { sb.append(','); } sb.append('"'); diff --git a/csv/src/test/java/com/fasterxml/jackson/dataformat/csv/schema/CsvSchemaTest.java b/csv/src/test/java/com/fasterxml/jackson/dataformat/csv/schema/CsvSchemaTest.java index f11510ff..ab5324af 100644 --- a/csv/src/test/java/com/fasterxml/jackson/dataformat/csv/schema/CsvSchemaTest.java +++ b/csv/src/test/java/com/fasterxml/jackson/dataformat/csv/schema/CsvSchemaTest.java @@ -142,6 +142,12 @@ public void testReorderWithComparator() throws Exception _verifyLinks(schema); } + public void testColumnDescForEmptyScheme() throws Exception + { + CsvSchema schema = CsvSchema.emptySchema(); + assertEquals("[]", schema.getColumnDesc()); + } + private void _verifyLinks(CsvSchema schema) { List all = new ArrayList();