Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CsvMappingException into CsvReadException/CsvWriteException #240

Closed
cowtowncoder opened this issue Jan 23, 2021 · 0 comments
Closed

Comments

@cowtowncoder
Copy link
Member

In Jackson 2.x there is CsvMappingException which extends JsonMappingException. This seems slightly sub-optimal as failures reported are streaming-level issues (mostly read but some write issues), and as such, exceptions used should instead extend:

  • StreamReadException (added in 2.10 to eventually replace JsonParseException)
  • StreamWriteException (added in 2.13 to eventually replace JsonGenerationException)

This can be done in two phases:

  1. For Jackson 2.13, create 2 new exceptions, make them extend existing CsvMappingException (without rebasing, to keep compatibility)
  2. For Jackson 3.0, remove CsvMappingException and make 2 new exceptions extend streaming-level counterparts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant