This repository has been archived by the owner on Jan 22, 2019. It is now read-only.
FluentIterable serialization doens't work for Bean Properties #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
added a commit
that referenced
this pull request
Dec 3, 2014
FluentIterable serialization doens't work for Bean Properties
cowtowncoder
added a commit
that referenced
this pull request
Dec 30, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the depths of
BeanPropertyWriter, theJavaTypefor the property is constructed, but Type Modifiers don't get called on it, so the Type Modifier in this module doesn't help.This fix explicitly handles the issue by using StdDelegatingDeserializer, which looks up the delegate deserializer using the static type of the delegate.
FWIW, I'd have rather just located and returned and instance of
IterableSerializer, but there doesn't seem to be a clean way to do that inSerializers#findSerializer.