Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binary nodes not supported during deserialization #5

Closed
aborg0 opened this issue Nov 26, 2014 · 3 comments
Closed

binary nodes not supported during deserialization #5

aborg0 opened this issue Nov 26, 2014 · 3 comments
Milestone
2.4.5

Comments

@aborg0
Copy link

aborg0 commented Nov 26, 2014

According to the docs BinaryNode is represented as a Base64 encoded String value. Although the current implementation throws a JsonMappingException instead.
@aborg0
Copy link
Author

aborg0 commented Nov 26, 2014

It seems the Base64 encoded text easily accessible from the BinaryNode, so fixing this would be easy.

@cowtowncoder
Copy link
Member

Sounds reasonable, yes.

@cowtowncoder cowtowncoder added this to the 2.4.5 milestone Nov 27, 2014
@cowtowncoder
Copy link
Member

Added handling, tested via simple added test that converts from ObjectNode that contains a BinaryNode into JsonValue; failed before fix, passes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.5
Development

No branches or pull requests
2 participants
@cowtowncoder @aborg0