Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse of ClassKey in ValueWriterLocator not working #79

Closed
cowtowncoder opened this issue Apr 4, 2021 · 0 comments
Closed

Reuse of ClassKey in ValueWriterLocator not working #79

cowtowncoder opened this issue Apr 4, 2021 · 0 comments

Comments

@cowtowncoder
Copy link
Member

(note: found by alloc profiling with async-profiler)

So, looks like attempted reuse of ClassKey instances is not working, due to one missing assignment.
This should be fixed, and making _key eagerly constructor since it is all but guaranteed to be needed for every serialization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cowtowncoder