Use SerializationFeature.WRITE_DURATIONS_AS_TIMESTAMPS for configuring Duration serialization
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
changed the title
SerializationFeature.WRITE_DURATIONS_AS_TIMESTAMPS for configuring Duration serialization
cowtowncoder
added a commit
that referenced
this pull request
Sep 13, 2018
|
Thank you for submitting this PR! Since this changes observed behavior, it needed to go in a new minor version, and now that I branched One other thing that might be worth considering is whether handling of Thank you again for the improvement; this will be in 2.10.0 once that gets released. |
filiphr
added a commit
to filiphr/spring-boot
that referenced
this pull request
Dec 11, 2019
… default Jackson added a breaking change in 2.10 for the way Duration is serialized. Before that the DurationSerializer was using SerializationFeature.WRITE_DATES_AS_TIMESTAMPS to check whether Duration should be serialized as a timestamp or not. Since 2.10 Jackson uses SerializationFeature.WRITE_DURATIONS_AS_TIMESTAMPS to check whether Duration should be serialized as a timestamp or not. This commit aligns the default for SerializationFeature.WRITE_DURATIONS_AS_TIMESTAMPS with the default for SerializationFeature.WRITE_DATES_AS_TIMESTAMPS The change in Jackson was done in FasterXML/jackson-modules-java8#75 fixes spring-projectsgh-19345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation uses
WRITE_DATES_AS_TIMESTAMPSand ignoresWRITE_DURATIONS_AS_TIMESTAMPStotally.I thought it would be less surprising to use
WRITE_DURATIONS_AS_TIMESTAMPSfor time duration serialization.