Remove redundant null call, add php extensions

jpresutti · jpresutti · commit 78cb8136c1cd · 2021-11-24T18:04:13.000-05:00
diff --git a/Csv/CsvReader.php b/Csv/CsvReader.php
@@ -91,8 +91,9 @@ public function getNextLine(): array|false
             $this->buildHeader();
         }
         $return = [];
+        /** @var array<int,string>|false $row */
         $row = $this->file->fgetcsv();
-        if ($row === null || $row === false) {
+        if ($row === false) {
             return false;
         }
 
diff --git a/composer.json b/composer.json
@@ -14,7 +14,11 @@
         "php": "^8.1.0",
         "ext-pdo": "*",
         "ext-xml": "*",
-        "ext-readline": "*"
+        "ext-readline": "*",
+        "ext-ctype": "*",
+        "ext-simplexml": "*",
+        "ext-libxml": "*",
+        "ext-fileinfo": "*"
     },
     "suggest": {
         "ext-mysql": "*",
diff --git a/composer.lock b/composer.lock

Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,9 @@ public function getNextLine(): array\|false`
`91`	`91`	`$this->buildHeader();`
`92`	`92`	`}`
`93`	`93`	`$return = [];`
	`94`	`+ /** @var array<int,string>\|false $row */`
`94`	`95`	`$row = $this->file->fgetcsv();`
`95`		`- if ($row === null \|\| $row === false) {`
	`96`	`+ if ($row === false) {`
`96`	`97`	`return false;`
`97`	`98`	`}`
`98`	`99`