Skip to content

Commit 638d3c1

Browse files
authored
Updated dependencies to fix set-output warning (#279)
1 parent 4d0d002 commit 638d3c1

File tree

8 files changed

+89192
-11147
lines changed

8 files changed

+89192
-11147
lines changed

bin/action.min.js

Lines changed: 83332 additions & 1596 deletions
Large diffs are not rendered by default.

package-lock.json

Lines changed: 5828 additions & 9513 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,25 +4,25 @@
44
"main": "bin/action.min.js",
55
"source": "src/index.ts",
66
"devDependencies": {
7-
"@actions/core": "^1.2.6",
8-
"@actions/exec": "^1.0.3",
9-
"@actions/github": "^4.0.0",
10-
"@babel/core": "^7.12.3",
11-
"@babel/preset-env": "^7.12.1",
12-
"@babel/preset-typescript": "^7.12.1",
13-
"@tsconfig/node12": "^1.0.7",
14-
"@types/jest": "^26.0.15",
15-
"@types/tmp": "^0.2.0",
16-
"babel-jest": "^26.6.0",
17-
"husky": "^4.2.5",
18-
"jest": "^26.6.0",
19-
"microbundle": "^0.13.0",
20-
"prettier": "^2.1.2",
21-
"pretty-quick": "^3.0.2",
7+
"@actions/core": "^1.10.0",
8+
"@actions/exec": "^1.1.1",
9+
"@actions/github": "^5.1.1",
10+
"@babel/core": "^7.21.4",
11+
"@babel/preset-env": "^7.21.4",
12+
"@babel/preset-typescript": "^7.21.4",
13+
"@tsconfig/node12": "^1.0.11",
14+
"@types/jest": "^29.5.1",
15+
"@types/tmp": "^0.2.3",
16+
"babel-jest": "^29.5.0",
17+
"husky": "^8.0.3",
18+
"jest": "^29.5.0",
19+
"microbundle": "^0.15.1",
20+
"prettier": "^2.8.7",
21+
"pretty-quick": "^3.1.3",
2222
"tmp": "^0.2.1",
23-
"ts-jest": "^26.4.1",
24-
"ts-node": "^9.0.0",
25-
"typescript": "^4.0.3"
23+
"ts-jest": "^29.1.0",
24+
"ts-node": "^10.9.1",
25+
"typescript": "^5.0.4"
2626
},
2727
"scripts": {
2828
"format:check": "prettier . --list-different",

src/createCheck.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@ export async function createCheck(
2121
github: InstanceType<typeof GitHub>,
2222
context: Context
2323
) {
24-
const check = await github.checks.create({
24+
const check = await github.rest.checks.create({
2525
...context.repo,
2626
name: "Deploy Preview",
2727
head_sha: context.payload.pull_request?.head.sha,
2828
status: "in_progress",
2929
});
3030

3131
return async (details: Object) => {
32-
await github.checks.update({
32+
await github.rest.checks.update({
3333
...context.repo,
3434
check_run_id: check.data.id,
3535
completed_at: new Date().toISOString(),

src/deploy.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -127,13 +127,8 @@ export async function deployPreview(
127127
gacFilename: string,
128128
deployConfig: ChannelDeployConfig
129129
) {
130-
const {
131-
projectId,
132-
channelId,
133-
target,
134-
expires,
135-
firebaseToolsVersion,
136-
} = deployConfig;
130+
const { projectId, channelId, target, expires, firebaseToolsVersion } =
131+
deployConfig;
137132

138133
const deploymentText = await execWithCredentials(
139134
[

src/postOrUpdateComment.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ export async function postChannelSuccessComment(
8787

8888
let commentId;
8989
try {
90-
const comments = (await github.issues.listComments(commentInfo)).data;
90+
const comments = (await github.rest.issues.listComments(commentInfo)).data;
9191
for (let i = comments.length; i--; ) {
9292
const c = comments[i];
9393
if (isCommentByBot(c)) {
@@ -101,7 +101,7 @@ export async function postChannelSuccessComment(
101101

102102
if (commentId) {
103103
try {
104-
await github.issues.updateComment({
104+
await github.rest.issues.updateComment({
105105
...context.repo,
106106
comment_id: commentId,
107107
body: comment.body,
@@ -113,7 +113,7 @@ export async function postChannelSuccessComment(
113113

114114
if (!commentId) {
115115
try {
116-
await github.issues.createComment(comment);
116+
await github.rest.issues.createComment(comment);
117117
} catch (e) {
118118
console.log(`Error creating comment: ${e.message}`);
119119
}

test/samples/cliOutputs.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,13 @@ export const channelMultiSiteSuccess: ChannelSuccessResult = {
1212
target1: {
1313
site: "my-main-hosting-site",
1414
target: "target1",
15-
url:
16-
"https://action-hosting-deploy-demo--multisite-test-goqvngto.web.app",
15+
url: "https://action-hosting-deploy-demo--multisite-test-goqvngto.web.app",
1716
expireTime: "2020-10-27T21:32:57.233344586Z",
1817
},
1918
target2: {
2019
site: "my-second-hosting-site",
2120
target: "target2",
22-
url:
23-
"https://action-hosting-deploy-demo-2--multisite-test-ksadajci.web.app",
21+
url: "https://action-hosting-deploy-demo-2--multisite-test-ksadajci.web.app",
2422
expireTime: "2020-10-27T21:32:57.233344586Z",
2523
},
2624
},
@@ -31,8 +29,7 @@ export const channelSingleSiteSuccess: ChannelSuccessResult = {
3129
result: {
3230
"action-hosting-deploy-demo": {
3331
site: "action-hosting-deploy-demo",
34-
url:
35-
"https://action-hosting-deploy-demo--singlesite-test-jl98rmie.web.app",
32+
url: "https://action-hosting-deploy-demo--singlesite-test-jl98rmie.web.app",
3633
expireTime: "2020-10-27T21:32:57.233344586Z",
3734
},
3835
},

test/samples/comments.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
export const multiSiteComment = `Visit the preview URL for this PR (updated for commit fe211ff):
1+
export const multiSiteComment =
2+
`Visit the preview URL for this PR (updated for commit fe211ff):
23
34
- [https://action-hosting-deploy-demo--multisite-test-goqvngto.web.app](https://action-hosting-deploy-demo--multisite-test-goqvngto.web.app)
45
- [https://action-hosting-deploy-demo-2--multisite-test-ksadajci.web.app](https://action-hosting-deploy-demo-2--multisite-test-ksadajci.web.app)
@@ -9,7 +10,8 @@ export const multiSiteComment = `Visit the preview URL for this PR (updated for
910
1011
<sub>Sign: 980f04126fb629deaadace7d6ee8a0628942e3d3</sub>`.trim();
1112

12-
export const singleSiteComment = `Visit the preview URL for this PR (updated for commit fe211ff):
13+
export const singleSiteComment =
14+
`Visit the preview URL for this PR (updated for commit fe211ff):
1315
1416
[https://action-hosting-deploy-demo--singlesite-test-jl98rmie.web.app](https://action-hosting-deploy-demo--singlesite-test-jl98rmie.web.app)
1517

0 commit comments

Comments
 (0)