-
Notifications
You must be signed in to change notification settings - Fork 6
feat: get evaluation get result #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zaimwa9
wants to merge
33
commits into
feat/evaluation-context-mappers
Choose a base branch
from
feat/evaluation-get-result
base: feat/evaluation-context-mappers
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
2aeb65a
feat: added-engine-function-signatures
Zaimwa9 ba057cb
feat: moved-engine-to-core
Zaimwa9 bb96eb1
feat: implemented-process-segment-overrides
Zaimwa9 a2fd5a8
feat: implemented-evalute-segments-partially
Zaimwa9 0f08fb1
feat: implemented-should-apply-override
Zaimwa9 da08e8e
feat: implemented-get-identity-segments
Zaimwa9 af51bf7
feat: implemented-new-in-and-fixed-remaining-tests
Zaimwa9 0fb7587
feat: run-lint
Zaimwa9 741ceeb
feat: rebased
Zaimwa9 6a6a129
feat: misc
Zaimwa9 3bad95b
Merge branch 'feat/evaluation-context-mappers' of github.com:Flagsmit…
Zaimwa9 f0a53b7
feat: json-path-lib-implementation
Zaimwa9 ef1274a
remove dup
gagantrivedi 962c01c
feat: made-legacy-functions-public
Zaimwa9 771a1a1
feat: updated-tests-to-match-engine-in-operator-accepting-numbers
Zaimwa9 561cd71
feat: rebased
Zaimwa9 21d7e74
feat: engine-agnostic-to-empty-identity-in-segment-evaluation
Zaimwa9 0baa0b4
feat: renamed-to-is-higher-priority
Zaimwa9 97cfdfb
feat: renamed-get-identity-segments-func
Zaimwa9 7188b95
feat: reverted-to-is-primitive
Zaimwa9 418ae33
feat: use-weakest-priority-constant
Zaimwa9 12144a3
feat: upgraded-engine-test-data-and-fixed-mv-evaluation-bug
Zaimwa9 fe63b45
feat: removed-targeting-reason-func
Zaimwa9 6420d15
feat: linter-rubocop-autocorrect
Zaimwa9 cbbd3c2
feat: linter
Zaimwa9 3b729fc
feat: linter
Zaimwa9 7c15dd5
Merge branch 'feat/evaluation-context-mappers' of github.com:Flagsmit…
Zaimwa9 13057f9
feat: moved-mappers-to-engine-namespace
Zaimwa9 7cee757
feat: rebased
Zaimwa9 2f3850c
Merge branch 'feat/evaluation-context-mappers' of github.com:Flagsmit…
Zaimwa9 37c424f
feat: enrich-context-with-identity-key
Zaimwa9 29e6bf6
feat: run-ci-on-all-branches
Zaimwa9 080f191
feat: removed-comments
Zaimwa9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| module Flagsmith | ||
| module Engine | ||
| module Features | ||
| # Targeting reason constants for evaluation results | ||
| module TargetingReasons | ||
| TARGETING_REASON_DEFAULT = 'DEFAULT' | ||
| TARGETING_REASON_TARGETING_MATCH = 'TARGETING_MATCH' | ||
| TARGETING_REASON_SPLIT = 'SPLIT' | ||
| end | ||
| end | ||
| end | ||
| end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.