Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow other providers #43

Open
odama626 opened this issue Jul 22, 2022 · 1 comment
Open

Allow other providers #43

odama626 opened this issue Jul 22, 2022 · 1 comment
Labels
CLI command line interface config User config enhancement New feature or request
Milestone

Comments

@odama626
Copy link
Collaborator

odama626 commented Jul 22, 2022

apollo should be removed as a dependency of @flatbread/core and extracted into it's own package @flatbread/provider-apollo the flatbread package should be trimmed down to only contain the cli, and a new flag should be added to allow specifying which provider to use when running the flatbread command

options for the flatbread package -- should implement both of possible

  • Preferably: add a provider field to the config that accepts a provider that the cli will use
  • add a -p, --provider flag to the cli to specify which provider to use with the cli
@odama626 odama626 changed the title apollo should be removed from core Allow other providers Jul 22, 2022
@odama626 odama626 added enhancement New feature or request CLI command line interface config User config labels Jul 22, 2022
@tonyketcham
Copy link
Collaborator

tonyketcham commented Jul 22, 2022

I agree it'd be best to have the provider declared in the config so that third-party providers can easily be registered.

We might be able to get the provider out of the config before passing it to generateSchema, and then feed the remaining config into generateSchema.

@tonyketcham tonyketcham added this to the v1.0 Release 🌿 milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI command line interface config User config enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants