dev branch: 1.8.0 installation creates a .net shortcut

[jjw24]

this shortcut is created everytime 1.8.0 is installed:

@taooceros any ideas?

[taooceros]

2021-06-17 00:53:27> ApplyReleasesImpl: Squirrel Enabled Apps: []
2021-06-17 00:53:27> ApplyReleasesImpl: No apps are marked as Squirrel-aware! Going to run them all
2021-06-17 00:53:27> ApplyReleasesImpl: About to create shortcuts for createdump.exe, rootAppDir C:\Users\1\AppData\Local\FlowLauncher
2021-06-17 00:53:27> ApplyReleasesImpl: Creating shortcut for createdump.exe => C:\Users\1\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Microsoft Corporation\Microsoft® .NET.lnk
2021-06-17 00:53:27> ApplyReleasesImpl: About to save shortcut: C:\Users\1\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Microsoft Corporation\Microsoft® .NET.lnk (target C:\Users\1\AppData\Local\FlowLauncher\createdump.exe, workingDir C:\Users\1\AppData\Local\FlowLauncher\app-1.7.2, args , toastActivatorCSLID acc29e55-6fa9-5c52-8861-f900e093184f)
2021-06-17 00:53:27> ApplyReleasesImpl: Creating shortcut for createdump.exe => C:\Users\1\Desktop\Microsoft® .NET.lnk
2021-06-17 00:53:27> ApplyReleasesImpl: About to save shortcut: C:\Users\1\Desktop\Microsoft® .NET.lnk (target C:\Users\1\AppData\Local\FlowLauncher\createdump.exe, workingDir C:\Users\1\AppData\Local\FlowLauncher\app-1.7.2, args , toastActivatorCSLID acc29e55-6fa9-5c52-8861-f900e093184f)

[taooceros]

2021-06-17 00:53:27> ApplyReleasesImpl: Squirrel Enabled Apps: []
2021-06-17 00:53:27> ApplyReleasesImpl: No apps are marked as Squirrel-aware! Going to run them all
2021-06-17 00:53:27> ApplyReleasesImpl: About to create shortcuts for createdump.exe, rootAppDir C:\Users\1\AppData\Local\FlowLauncher
2021-06-17 00:53:27> ApplyReleasesImpl: Creating shortcut for createdump.exe => C:\Users\1\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Microsoft Corporation\Microsoft® .NET.lnk
2021-06-17 00:53:27> ApplyReleasesImpl: About to save shortcut: C:\Users\1\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Microsoft Corporation\Microsoft® .NET.lnk (target C:\Users\1\AppData\Local\FlowLauncher\createdump.exe, workingDir C:\Users\1\AppData\Local\FlowLauncher\app-1.7.2, args , toastActivatorCSLID acc29e55-6fa9-5c52-8861-f900e093184f)
2021-06-17 00:53:27> ApplyReleasesImpl: Creating shortcut for createdump.exe => C:\Users\1\Desktop\Microsoft® .NET.lnk
2021-06-17 00:53:27> ApplyReleasesImpl: About to save shortcut: C:\Users\1\Desktop\Microsoft® .NET.lnk (target C:\Users\1\AppData\Local\FlowLauncher\createdump.exe, workingDir C:\Users\1\AppData\Local\FlowLauncher\app-1.7.2, args , toastActivatorCSLID acc29e55-6fa9-5c52-8861-f900e093184f)

[taooceros]

It seems that we need to mark the enabled app for squirrel, or else it will create shortcut for every .exe exist in the package.

[taooceros]

Squirrel/Squirrel.Windows#1644 this is a bug, so a potential workaround is to remove the createdump.exe since most user won't need to use it.

[jjw24]

ok cool thanks for looking into this @taooceros

[taooceros]

dotnet/runtime#43716 We may not be able to remove the createdump.exe. Someone has made a workaround for squirrel. Maybe we can create a custom squirrel to do that.

[taooceros]

I check the issue again. It is possible to remove the createdump.exe if we remove it from dep.json. I will create a pr for doing that soon.