Skip to content

Commit 744d216

Browse files
committed
Release v1.3.4
1 parent 3a609a1 commit 744d216

File tree

74 files changed

+1116
-472
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

74 files changed

+1116
-472
lines changed

DevSpaceAgent/Docker/DockerContainers.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ public static async Task<IList<DockerContainerInfo>> ListContainersAsync(DockerC
1818
{
1919
All = true,
2020
};
21-
Dictionary<string, string>? Filters = null;
2221
if (@event.Data != null)
2322
{
2423
ListContainersEvent? Data = @event.Data.Deserialize<ListContainersEvent>(AgentJsonOptions.Options);

DevSpaceAgent/Docker/DockerVolumes.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,10 @@ public static async Task<IList<DockerVolumeInfo>> ListVolumesAsync(DockerClient
3434
return List;
3535
}
3636

37-
public static async Task<VolumeResponse> CreateVolumeAsync(DockerClient client, VolumesCreateParameters param)
37+
public static async Task<VolumeResponse> CreateVolumeAsync(DockerClient client, VolumesCreateParameters? param)
3838
{
39+
if (param == null)
40+
throw new Exception("Volume create parameters is missing.");
3941
return await client.Volumes.CreateAsync(param);
4042
}
4143

DevSpaceAgent/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ public static async void RunChecks(object? sender, ElapsedEventArgs? e)
283283
if (Server != null)
284284
Server.MulticastText(System.Text.Json.JsonSerializer.Serialize(Stats, AgentJsonOptions.Options));
285285
else if (Client != null)
286-
Client.WebSocket.SendAsync(Encoding.UTF8.GetBytes(System.Text.Json.JsonSerializer.Serialize(Stats, AgentJsonOptions.Options)), WebSocketMessageType.Text, true, CancellationToken.None);
286+
_ = Client.WebSocket.SendAsync(Encoding.UTF8.GetBytes(System.Text.Json.JsonSerializer.Serialize(Stats, AgentJsonOptions.Options)), WebSocketMessageType.Text, true, CancellationToken.None);
287287
}
288288

289289
public static System.Timers.Timer timer = new System.Timers.Timer(new TimeSpan(0, 5, 0));

DevSpaceAgent/Server/EdgeClient.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public override async Task Connect(string host, short port, string key, bool rec
5151
bool StatsSent = false;
5252
ArraySegment<byte> buffer = new ArraySegment<byte>(new byte[8192]);
5353

54-
WebSocketReceiveResult result = null;
54+
WebSocketReceiveResult? result = null;
5555

5656
if (WebSocket.State == WebSocketState.Open)
5757
ReconnectCount = 5;
@@ -66,7 +66,7 @@ public override async Task Connect(string host, short port, string key, bool rec
6666
SystemInfoResponse HostInfo = await Program.DockerClient.System.GetSystemInfoAsync();
6767
AgentStatsResponse Stats = await AgentStatsResponse.Create(Program.Version, Program.DockerClient, HostInfo);
6868

69-
WebSocket.SendAsync(Encoding.UTF8.GetBytes(System.Text.Json.JsonSerializer.Serialize(Stats, AgentJsonOptions.Options)), WebSocketMessageType.Text, true, CancellationToken.None);
69+
_ = WebSocket.SendAsync(Encoding.UTF8.GetBytes(System.Text.Json.JsonSerializer.Serialize(Stats, AgentJsonOptions.Options)), WebSocketMessageType.Text, true, CancellationToken.None);
7070
}
7171
}
7272
try
@@ -90,7 +90,7 @@ public override async Task Connect(string host, short port, string key, bool rec
9090
else
9191
{
9292

93-
ServerEventHandler.RecieveAsync(new ClientSession
93+
_ = ServerEventHandler.RecieveAsync(new ClientSession
9494
{
9595
Session = WebSocket
9696
}, ms.ToArray(), 0, result.Count);

DevSpaceShared/Data/DockerContainerInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public static DockerContainerInfo Create(ContainerListResponse data)
6969
return Info;
7070
}
7171

72-
public required string Id { get; set; }
72+
public required string? Id { get; set; }
7373
public string Name { get; set; }
7474
public string ImageId { get; set; }
7575
public string ImageName { get; set; }

DevSpaceShared/Data/DockerNetworkInfo.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ public static DockerNetworkInfo Create(NetworkResponse network, bool inspect, Ne
3232
{
3333
Info.Labels = network.Labels;
3434
Info.Options = network.Options;
35-
Info.ContainersList = network.Containers;
35+
if (network.Containers != null)
36+
Info.ContainersList = network.Containers;
37+
3638
if (networkFrom != null)
3739
{
3840
Info.ConfigFrom = new DockerNetworkInfo

DevSpaceShared/Responses/AgentStatsResponse.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public static async Task<AgentStatsResponse> Create(string? agentVersion, Docker
2222

2323
return new AgentStatsResponse
2424
{
25-
StacksCount = Containers.Count(x => x.Labels != null && x.Labels.TryGetValue("com.docker.compose.project", out string label) && !string.IsNullOrEmpty(label)),
25+
StacksCount = Containers.Count(x => x.Labels != null && x.Labels.TryGetValue("com.docker.compose.project", out string? label) && !string.IsNullOrEmpty(label)),
2626
ContainersCount = systemInfo.Containers,
2727
ContainersRunningCount = systemInfo.ContainersRunning,
2828
ContainersDownCount = systemInfo.ContainersStopped,

DevSpaceWeb/.editorconfig

Lines changed: 258 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,258 @@
1+
# Remove the line below if you want to inherit .editorconfig settings from higher directories
2+
root = true
3+
4+
# C# files
5+
[*.cs]
6+
7+
#### Core EditorConfig Options ####
8+
9+
# Indentation and spacing
10+
indent_size = 4
11+
indent_style = space
12+
tab_width = 4
13+
14+
# New line preferences
15+
end_of_line = crlf
16+
insert_final_newline = false
17+
18+
#### .NET Code Actions ####
19+
20+
# Type members
21+
dotnet_hide_advanced_members = false
22+
dotnet_member_insertion_location = with_other_members_of_the_same_kind
23+
dotnet_property_generation_behavior = prefer_throwing_properties
24+
25+
# Symbol search
26+
dotnet_search_reference_assemblies = true
27+
28+
#### .NET Coding Conventions ####
29+
30+
# Organize usings
31+
dotnet_separate_import_directive_groups = false
32+
dotnet_sort_system_directives_first = false
33+
file_header_template = unset
34+
35+
# this. and Me. preferences
36+
dotnet_style_qualification_for_event = false
37+
dotnet_style_qualification_for_field = false
38+
dotnet_style_qualification_for_method = false
39+
dotnet_style_qualification_for_property = false
40+
41+
# Language keywords vs BCL types preferences
42+
dotnet_style_predefined_type_for_locals_parameters_members = true
43+
dotnet_style_predefined_type_for_member_access = true
44+
45+
# Parentheses preferences
46+
dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity
47+
dotnet_style_parentheses_in_other_binary_operators = always_for_clarity
48+
dotnet_style_parentheses_in_other_operators = never_if_unnecessary
49+
dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity
50+
51+
# Modifier preferences
52+
dotnet_style_require_accessibility_modifiers = for_non_interface_members
53+
54+
# Expression-level preferences
55+
dotnet_prefer_system_hash_code = true
56+
dotnet_style_coalesce_expression = true
57+
dotnet_style_collection_initializer = true
58+
dotnet_style_explicit_tuple_names = true
59+
dotnet_style_namespace_match_folder = true
60+
dotnet_style_null_propagation = true
61+
dotnet_style_object_initializer = true
62+
dotnet_style_operator_placement_when_wrapping = beginning_of_line
63+
dotnet_style_prefer_auto_properties = false
64+
dotnet_style_prefer_collection_expression = when_types_loosely_match
65+
dotnet_style_prefer_compound_assignment = true
66+
dotnet_style_prefer_conditional_expression_over_assignment = true
67+
dotnet_style_prefer_conditional_expression_over_return = true
68+
dotnet_style_prefer_foreach_explicit_cast_in_source = when_strongly_typed
69+
dotnet_style_prefer_inferred_anonymous_type_member_names = true
70+
dotnet_style_prefer_inferred_tuple_names = true
71+
dotnet_style_prefer_is_null_check_over_reference_equality_method = true
72+
dotnet_style_prefer_simplified_boolean_expressions = true
73+
dotnet_style_prefer_simplified_interpolation = true
74+
75+
# Field preferences
76+
dotnet_style_readonly_field = true
77+
78+
# Parameter preferences
79+
dotnet_code_quality_unused_parameters = all
80+
81+
# Suppression preferences
82+
dotnet_remove_unnecessary_suppression_exclusions = none
83+
84+
# New line preferences
85+
dotnet_style_allow_multiple_blank_lines_experimental = true
86+
dotnet_style_allow_statement_immediately_after_block_experimental = true
87+
88+
#### C# Coding Conventions ####
89+
90+
# var preferences
91+
csharp_style_var_elsewhere = false
92+
csharp_style_var_for_built_in_types = false
93+
csharp_style_var_when_type_is_apparent = false
94+
95+
# Expression-bodied members
96+
csharp_style_expression_bodied_accessors = true:silent
97+
csharp_style_expression_bodied_constructors = false:silent
98+
csharp_style_expression_bodied_indexers = true:silent
99+
csharp_style_expression_bodied_lambdas = true:silent
100+
csharp_style_expression_bodied_local_functions = false
101+
csharp_style_expression_bodied_methods = false:silent
102+
csharp_style_expression_bodied_operators = false:silent
103+
csharp_style_expression_bodied_properties = true:silent
104+
105+
# Pattern matching preferences
106+
csharp_style_pattern_matching_over_as_with_null_check = true
107+
csharp_style_pattern_matching_over_is_with_cast_check = true
108+
csharp_style_prefer_extended_property_pattern = true
109+
csharp_style_prefer_not_pattern = true
110+
csharp_style_prefer_pattern_matching = true
111+
csharp_style_prefer_switch_expression = true:suggestion
112+
113+
# Null-checking preferences
114+
csharp_style_conditional_delegate_call = true
115+
116+
# Modifier preferences
117+
csharp_prefer_static_anonymous_function = true
118+
csharp_prefer_static_local_function = true
119+
csharp_preferred_modifier_order = public,private,protected,internal,file,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,required,volatile,async
120+
csharp_style_prefer_readonly_struct = true
121+
csharp_style_prefer_readonly_struct_member = true
122+
123+
# Code-block preferences
124+
csharp_prefer_braces = true:silent
125+
csharp_prefer_simple_using_statement = true:suggestion
126+
csharp_prefer_system_threading_lock = true:suggestion
127+
csharp_style_namespace_declarations = file_scoped:silent
128+
csharp_style_prefer_method_group_conversion = true:silent
129+
csharp_style_prefer_primary_constructors = true:suggestion
130+
csharp_style_prefer_top_level_statements = false:silent
131+
132+
# Expression-level preferences
133+
csharp_prefer_simple_default_expression = true
134+
csharp_style_deconstructed_variable_declaration = true
135+
csharp_style_implicit_object_creation_when_type_is_apparent = true
136+
csharp_style_inlined_variable_declaration = true
137+
csharp_style_prefer_implicitly_typed_lambda_expression = true
138+
csharp_style_prefer_index_operator = true
139+
csharp_style_prefer_local_over_anonymous_function = true
140+
csharp_style_prefer_null_check_over_type_check = true
141+
csharp_style_prefer_range_operator = true
142+
csharp_style_prefer_tuple_swap = true
143+
csharp_style_prefer_unbound_generic_type_in_nameof = true
144+
csharp_style_prefer_utf8_string_literals = true
145+
csharp_style_throw_expression = true
146+
csharp_style_unused_value_assignment_preference = discard_variable
147+
csharp_style_unused_value_expression_statement_preference = discard_variable
148+
149+
# 'using' directive preferences
150+
csharp_using_directive_placement = outside_namespace:silent
151+
152+
# New line preferences
153+
csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental = true
154+
csharp_style_allow_blank_line_after_token_in_arrow_expression_clause_experimental = true
155+
csharp_style_allow_blank_line_after_token_in_conditional_expression_experimental = true
156+
csharp_style_allow_blank_lines_between_consecutive_braces_experimental = true
157+
csharp_style_allow_embedded_statements_on_same_line_experimental = true
158+
159+
#### C# Formatting Rules ####
160+
161+
# New line preferences
162+
csharp_new_line_before_catch = true
163+
csharp_new_line_before_else = true
164+
csharp_new_line_before_finally = true
165+
csharp_new_line_before_members_in_anonymous_types = true
166+
csharp_new_line_before_members_in_object_initializers = true
167+
csharp_new_line_before_open_brace = all
168+
csharp_new_line_between_query_expression_clauses = true
169+
170+
# Indentation preferences
171+
csharp_indent_block_contents = true
172+
csharp_indent_braces = false
173+
csharp_indent_case_contents = true
174+
csharp_indent_case_contents_when_block = true
175+
csharp_indent_labels = one_less_than_current
176+
csharp_indent_switch_labels = true
177+
178+
# Space preferences
179+
csharp_space_after_cast = false
180+
csharp_space_after_colon_in_inheritance_clause = true
181+
csharp_space_after_comma = true
182+
csharp_space_after_dot = false
183+
csharp_space_after_keywords_in_control_flow_statements = true
184+
csharp_space_after_semicolon_in_for_statement = true
185+
csharp_space_around_binary_operators = before_and_after
186+
csharp_space_around_declaration_statements = false
187+
csharp_space_before_colon_in_inheritance_clause = true
188+
csharp_space_before_comma = false
189+
csharp_space_before_dot = false
190+
csharp_space_before_open_square_brackets = false
191+
csharp_space_before_semicolon_in_for_statement = false
192+
csharp_space_between_empty_square_brackets = false
193+
csharp_space_between_method_call_empty_parameter_list_parentheses = false
194+
csharp_space_between_method_call_name_and_opening_parenthesis = false
195+
csharp_space_between_method_call_parameter_list_parentheses = false
196+
csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
197+
csharp_space_between_method_declaration_name_and_open_parenthesis = false
198+
csharp_space_between_method_declaration_parameter_list_parentheses = false
199+
csharp_space_between_parentheses = false
200+
csharp_space_between_square_brackets = false
201+
202+
# Wrapping preferences
203+
csharp_preserve_single_line_blocks = true
204+
csharp_preserve_single_line_statements = true
205+
206+
#### Naming styles ####
207+
208+
# Naming rules
209+
210+
dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
211+
dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
212+
dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
213+
214+
dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
215+
dotnet_naming_rule.types_should_be_pascal_case.symbols = types
216+
dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case
217+
218+
dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
219+
dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
220+
dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
221+
222+
# Symbol specifications
223+
224+
dotnet_naming_symbols.interface.applicable_kinds = interface
225+
dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
226+
dotnet_naming_symbols.interface.required_modifiers =
227+
228+
dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
229+
dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
230+
dotnet_naming_symbols.types.required_modifiers =
231+
232+
dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
233+
dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
234+
dotnet_naming_symbols.non_field_members.required_modifiers =
235+
236+
# Naming styles
237+
238+
dotnet_naming_style.pascal_case.required_prefix =
239+
dotnet_naming_style.pascal_case.required_suffix =
240+
dotnet_naming_style.pascal_case.word_separator =
241+
dotnet_naming_style.pascal_case.capitalization = pascal_case
242+
243+
dotnet_naming_style.begins_with_i.required_prefix = I
244+
dotnet_naming_style.begins_with_i.required_suffix =
245+
dotnet_naming_style.begins_with_i.word_separator =
246+
dotnet_naming_style.begins_with_i.capitalization = pascal_case
247+
248+
# CS8509: The switch expression does not handle all possible values of its input type (it is not exhaustive).
249+
dotnet_diagnostic.CS8509.severity = error
250+
251+
# CS8601: Possible null reference assignment.
252+
dotnet_diagnostic.CS8601.severity = error
253+
254+
[*.{cs,vb}]
255+
dotnet_style_operator_placement_when_wrapping = beginning_of_line
256+
tab_width = 4
257+
indent_size = 4
258+
end_of_line = crlf

DevSpaceWeb/API/Servers/ContainerJson.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public ContainerJson(ContainerInspectResponse info, bool viewDetails, bool viewE
6161
health = new ContainerHealthJson(info, viewHealthLog);
6262
}
6363

64-
public string id { get; set; }
64+
public string? id { get; set; }
6565
public string? name { get; set; }
6666
public string? description { get; set; }
6767
public string image_id { get; set; }

DevSpaceWeb/Agents/EdgeAgent.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public override async Task Disconnect()
8686
byte[] encoded = Encoding.UTF8.GetBytes(message);
8787
ArraySegment<byte> buffer = new ArraySegment<Byte>(encoded, 0, encoded.Length);
8888
if (WebSocket != null)
89-
WebSocket.SendAsync(buffer, System.Net.WebSockets.WebSocketMessageType.Text, true, token);
89+
_ = WebSocket.SendAsync(buffer, System.Net.WebSockets.WebSocketMessageType.Text, true, token);
9090

9191
JsonElement? result = null;
9292
try

0 commit comments

Comments
 (0)