Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: add "portable" option to pass to tar.Pack #35

Open
murgatroid99 opened this issue Dec 17, 2017 · 1 comment
Open

Suggestion: add "portable" option to pass to tar.Pack #35

murgatroid99 opened this issue Dec 17, 2017 · 1 comment

Comments

@murgatroid99
Copy link
Contributor

I have recently encountering some issues where I package and distribute tarballs as a non-root user, then someone tries to extract it as root and it fails because the ownership data is preserved and it is trying to assign file ownership to a nonexistent user. tar.Pack's portable option looks like it would solve that because it omits uid and gid metadata, so I suggest that that option be made available in this library's pack function.
@murgatroid99
Copy link
Contributor Author

In addition, for similar reasons, I think it would be useful to expose the tar.Unpack's preserveOwner option. I would like to note that the default for that option depends on external factors (specifically the current process's user ID), so in order to avoid changing behavior in the default case, this library should pass undefined through unchanged instead of choosing a default of true or false.

This was referenced Jan 29, 2018
Merged
Merged
Merged
@alexander-fenster alexander-fenster mentioned this issue Feb 10, 2018
Merged
alexander-fenster added a commit to googleapis/nodejs-dialogflow that referenced this issue Feb 14, 2018
@alexander-fenster
run circleci as non-root user
bbf7b00 
It saves several minutes per CI task because it keeps recompiling `grpc` being unable to unpack it. Some details [here](ForbesLindesay-Unmaintained/tar-pack#35).
@alexander-fenster alexander-fenster mentioned this issue Feb 14, 2018
Merged
3 tasks
alexander-fenster added a commit to googleapis/nodejs-dialogflow that referenced this issue Feb 16, 2018
@alexander-fenster
chore: run circleci as non-root user (#24)
a7222be 
It saves several minutes per CI task because it keeps recompiling `grpc` being unable to unpack it. Some details [here](ForbesLindesay-Unmaintained/tar-pack#35).
alexander-fenster added a commit to googleapis/nodejs-storage that referenced this issue Feb 16, 2018
@alexander-fenster
chore: run CI as non-root user
a1c7de6 
Prevent rebuilding `grpc` by running CI tasks as non-root user. Details [here](ForbesLindesay-Unmaintained/tar-pack#35).
@alexander-fenster alexander-fenster mentioned this issue Feb 16, 2018
Merged
3 tasks
alexander-fenster added a commit to googleapis/nodejs-storage that referenced this issue Feb 16, 2018
@alexander-fenster
chore: run CI as non-root user (#136)
4bf026c 
Prevent rebuilding `grpc` by running CI tasks as non-root user. Details [here](ForbesLindesay-Unmaintained/tar-pack#35).
@alexander-fenster alexander-fenster mentioned this issue Mar 16, 2018
Merged
sofisl pushed a commit to googleapis/google-cloud-node that referenced this issue Nov 11, 2022
@alexander-fenster
chore: run circleci as non-root user (#24)
284cf1a 
It saves several minutes per CI task because it keeps recompiling `grpc` being unable to unpack it. Some details [here](ForbesLindesay-Unmaintained/tar-pack#35).
aforismesen added a commit to aforismesen/nodejs-storage that referenced this issue Jul 12, 2024
@aforismesen
chore: run CI as non-root user (#136)
70b0450 
Prevent rebuilding `grpc` by running CI tasks as non-root user. Details [here](ForbesLindesay-Unmaintained/tar-pack#35).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@murgatroid99