Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octoprint: Access Request issues #6

Open
RyantHults opened this issue Jul 6, 2022 · 8 comments
Open

Octoprint: Access Request issues #6

RyantHults opened this issue Jul 6, 2022 · 8 comments

Comments

@RyantHults
Copy link

RyantHults commented Jul 6, 2022

Hi there!
I recently got your octoprint edge driver setup and I noticed I keep getting access requests from it, about once every ~24hrs. Is this a limitation of smartthings, or is there something wrong? I'd gladly input the api key into the driver settings if that would help fix the issue.

Another issue I wanted to bring to your attention (though it's really a smartthings issue): usernames in octopi are Case-Sensitive. In the smartthings app, the username field automatically capitalizes the first character upon saving, which broke my setup since my octopi username is all lower case. Might be a good gotcha to note in the setup instructions.

@FreeMasen
Copy link
Owner

Hey!
Thanks for the bug report. I will take a look at what might be going on with the api key setup. I might be able to support both API Key and the octopi recommended authorization flow.

the username field automatically capitalizes the first character upon saving

So long as you deselect the 'Shift' button when entering it, it should be saved as all lowercase, though it may be displaying with an upper first character if you try and edit it again it should still be all lowercase.

@RyantHults
Copy link
Author

RyantHults commented Jul 6, 2022

So long as you deselect the 'Shift' button when entering it, it should be saved as all lowercase, though it may be displaying with an upper first character if you try and edit it again it should still be all lowercase.

strange, I could have sworn that it was still capitalizing it, but rechecking just now shows that's not the case. Guess I just mis-typed it the first few times.

Another thing I just noticed about the auth issue, it appears that it's requesting authentication but I don't think it needs it. I'm still able to see all the info from my printer, and the logcat shows everything is coming through just fine. Maybe a check to see if it needs authentication is all that's required?

@FreeMasen
Copy link
Owner

It seems like the device's state isn't getting persisted for some reason. I might be blocking the runtime from being able to complete the save so I'll have to keep digging on how to solve this problem but I wanted to let you know I at least found the initial problem.

@RyantHults
Copy link
Author

ok, awesome! thanks for the update!

@FreeMasen
Copy link
Owner

I've updated the driver to explicitly call driver.datastore:save after the API key is captured and this seemed to fix it on the hub I tested. I also reduced the state poll duration from 1 second to 5 seconds to allow a little more space for the datastore update to occur. I ended up publishing the changes last week so it should already be deployed, please let me know if this solves the problem for you as well.

@drich5
Copy link

drich5 commented Sep 21, 2022

I am request my credentials be reset for 1Password

@FreeMasen
Copy link
Owner

I am request my credentials be reset for 1Password

Hi, are you having a problem with the octopi driver? It doesn't have any connection to 1Password could you elaborate on what you are looking for?

@drich5
Copy link

drich5 commented Sep 21, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants