Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some svgs problematic in Firefox [bounty: 4 XTR] #2598

Closed
DreadKnight opened this issue Aug 11, 2024 · 9 comments · Fixed by #2623
Closed

some svgs problematic in Firefox [bounty: 4 XTR] #2598

DreadKnight opened this issue Aug 11, 2024 · 9 comments · Fixed by #2623
Assignees
Labels
bounty Some amount of our token, XatteR, is offered coding This issue requires some programming easy Good place to start if you're a new developer visuals Various things that easily catch the eye
Milestone

Comments

@DreadKnight
Copy link
Member

DreadKnight commented Aug 11, 2024

Firefox doesn't display svg icons that show up above units, such as the skip turn icon when there are no actions left to do.
This caused for us to have a duplication of that icon, in png format, in order to temporarily bypass the issue.

@DreadKnight DreadKnight added coding This issue requires some programming visuals Various things that easily catch the eye easy Good place to start if you're a new developer bounty Some amount of our token, XatteR, is offered labels Aug 11, 2024
@DreadKnight DreadKnight added this to the 0.6 - Cyber Wolf milestone Aug 11, 2024
@abhayrsr
Copy link

Hi, first time contributer here. Would love to work on this task. Is there any other issue linked to this issue available on GitHub right now??

@DreadKnight
Copy link
Member Author

Hi, first time contributer here. Would love to work on this task. Is there any other issue linked to this issue available on GitHub right now??

Heya! Assigned you to it. 2 weeks soft deadline 🐻
Will poke you if stuff is linked to it.

@DreadKnight
Copy link
Member Author

Hi @DreadKnight To better understand this one could you pls provide a video or screen recording that demonstrates the problem?

@Nazim9945 Heya! Please poke at some other issue that's not assigned and easier for you to understand; lots of them open.

@DreadKnight
Copy link
Member Author

@abhayrsr Heya! Any progress with this one?

@abhayrsr
Copy link

abhayrsr commented Aug 27, 2024

I tried but not able to progress. you can assign it to others. Thanks!

@Changh341
Copy link
Contributor

Hey. I would like to take a crack at this issue. May I be assigned this?

@DreadKnight
Copy link
Member Author

Hey. I would like to take a crack at this issue. May I be assigned this?

Heya! Sure thing, go for it.

@Changh341
Copy link
Contributor

Changh341 commented Sep 21, 2024

I was able to find the source of the bug and fix it.
However I only know of skip button icon that appear above units.
Are there any other SVG icons that appear on units that I should look at as the fix involves correcting the markup of the SVG.

@DreadKnight
Copy link
Member Author

I was able to find the source of the bug and fix it. However I only know of skip button icon that appear above units. Are there any other SVG icons that appear on units that I should look at as the fix involves correcting the markup of the SVG.

@Changh341 Good to hear! Only that icon for now and we switched to a png for it to avoid the bug. Wanted to add more icons like that, but didn't wanted to duplicate files too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty Some amount of our token, XatteR, is offered coding This issue requires some programming easy Good place to start if you're a new developer visuals Various things that easily catch the eye
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants