OC widget missing in embed [bounty: 8 XTR]

[DreadKnight]

When the game is embedded, the Open Collective widget located in dash view under the materialization button is not visible.
Tested in Firefox. There's probably a restriction or problem with showing an iframe within an iframe or something like that.

See https://AncientBeast.com (embedded, no widget) versus https://beta.AncientBeast.com (direct, with OC widget).

[priyanshunishad4]

hi, @DreadKnight , i was working to fix this issue , i think i found it , i have attached screenshot , can you tell me is this right? if yes , please assign me this task.

[priyanshunishad4]

[DreadKnight]

@priyanshunishad4 Heya! I can't see the screenshot just yet... Will assign you to it.

[priyanshunishad4]

@priyanshunishad4 Heya! Yeah, that's the one. Will assign you to it then.

thank you then , i am exited this one would be my first git hub contribution

[DreadKnight]

@priyanshunishad4 Heya! Yeah, that's the one. Will assign you to it then.

thank you then , i am exited this one would be my first git hub contribution

You answered way too quick, can't see your screenie. Got confused seeing my screenshots as I'm on phone and just woke up 😆

[DreadKnight]

@priyanshunishad4 I guess you didn't finish uploading your screenshot.

[priyanshunishad4]

i don't know i trying uploading , no problem boss , i will figure it out

[priyanshunishad4]

[DreadKnight]

Yeah, that's the one. It's lacking a div around it compared to my screenie though.

[DreadKnight]

@priyanshunishad4 Heya! Any progress with this one? Soft deadline is usually 2 weeks...

[priyanshunishad4]

hey @DreadKnight , i am so sorry for not completing this task , i was busy preparing for interview. i should not take this task. i am unassigning myself.

[codemaster321]

Hi @DreadKnight, I tried testing https://beta.ancientbeast.com/ on firefox, but for me the OC widgets arent visible, but when inspecting them from console. they are visible. Attaching the screenshots

[DreadKnight]

@codemaster321 I see, might be a CSS related issue with how stuff is revealed on screen and such.

[codemaster321]

@DreadKnight, Yea it is. So could you tell me how do you want this issue to be fixed. I added a overflow-y:auto in the closest div, so here is a small fix. Meanwhile, I will think a solution for oc widget in embed

[codemaster321]

Hi @DreadKnight , I tried to troubleshoot so i opened https://play.ancientbeast.com/ and inspected the DOM. I found that there's no OC widget div there.
.
Furthermore, I think the problem is https://ancientbeast.com/ is pointing to v0.4-stable branch which has no OC widget div there and not to the master branch. So do you want me to push changes in that branch?

[DreadKnight]

Hi @DreadKnight , I tried to troubleshoot so i opened https://play.ancientbeast.com/ and inspected the DOM. I found that there's no OC widget div there.
.
Furthermore, I think the problem is https://ancientbeast.com/ is pointing to v0.4-stable branch which has no OC widget div there and not to the master branch. So do you want me to push changes in that branch?

Indeed, play subdomain and homepage has v0.4 which is stable and didn't probably include this. Will check patches soon and mark this as invalid and close if so.

[codemaster321]

@DreadKnight, Oh, I wasn't aware of that haha. Now I got it.

[codemaster321]

Also, what should be done regarding the overflow issue for OC widget in v0.5-alpha. Should I open a PR for that?

[DreadKnight]

Also, what should be done regarding the overflow issue for OC widget in v0.5-alpha. Should I open a PR for that?

Yeah, feel free to do so. I'll be able to properly test it out that way.

[DreadKnight]

@codemaster321 Nice catch on these. Looking forward to that PR. Will reward you with XatteR, so make sure you add a wallet address, guide here -> https://github.com/FreezingMoon/AncientBeast/wiki/XatteR#bounties

[codemaster321]

@codemaster321 Nice catch on these. Looking forward to that PR. Will reward you with XatteR, so make sure you add a wallet address, guide here -> https://github.com/FreezingMoon/AncientBeast/wiki/XatteR#bounties

Much thanks. Really appreciate it. I will make a PR by tomorrow.