Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider semver(-ish) for versioning? #7185

Open
Schweinepriester opened this issue Oct 14, 2024 · 1 comment
Open

Consider semver(-ish) for versioning? #7185

Schweinepriester opened this issue Oct 14, 2024 · 1 comment

Comments

@Schweinepriester
Copy link
Contributor

TL;DR: Consider semver(-ish) for versioning, at least minor for removing features?

I tried searching if there's some history regarding the versioning, but wasn't able to find it, so sorry if this has been discussed!

I think there have been cases like those before, but I arrive here via our stylelint pipeline failing, finding browserslist/caniuse-lite#129 and subsequently RJWadley/stylelint-no-unsupported-browser-features#299.

Surely it would require some effort and time to adjust the tooling, but would be open to consider semver or semver-ish for versioning of caniuse-db?

Currently the advice seems to be to pin caniuse-db to a specific version, which of course has the drawback of having to update it, be it manual or (semi-)automatic.

With semver at least people would generally be able to stay up to date, with a breaking change being more of a conscious update step.

Alternatively semver-ish could be an idea, for example keep the major as is and increase minor with breaking changes, such that other projects could depend on caniuse-db with ~ for patch level versions, like ~1.0.30001668, covering most of the time.

I suppose breaking changes would only be removing features and really drastic changes to the schema of the JSONs? 🤔


As a little bit of a more subjective note, I use Renovate quite a bit and am bummed when there are breaking changes in a patch level.
So given the foundational nature of caniuse with other tools depending on it, I think it would really be good to take that wide reach to heart and make it somewhat easier on dependents :)

@Fyrd
Copy link
Owner

Fyrd commented Oct 21, 2024

Yes, I think this is reasonable. And thanks for calling out the effect of removing a feature, was not aware of the effect that had had (one of the reasons I try to avoid big changes in the first place).

Will definitely consider using major/minor updates for big changes in the future. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants