feat: don't raise when error occurs on some project

As it would stop the processing of other projects

Author: Jean-Philippe Braun

src/cinder_snapshooter/utils.py

@@ -16,8 +16,10 @@
 
 SPDX-License-Identifier: Apache-2.0
 """
+
 import datetime
 import logging
+import traceback
 
 from typing import Optional
 
@@ -168,7 +170,13 @@ def run_on_projects(
                     trust=g["trust_id"],
                 )
             else:
-                raise
+                log.error(
+                    "Error while processing project",
+                    project=g["project_id"],
+                    req=err.request_id,
+                    trust=g["trust_id"],
+                    error=traceback.format_exc(),
+                )
 
     return return_value
 

tests/test_utils.py

@@ -15,6 +15,7 @@
 
 SPDX-License-Identifier: Apache-2.0
 """
+
 import argparse
 import logging
 
@@ -168,31 +169,22 @@ def connect_as(**kwargs):
         http_status=return_code,
     )
 
-    if return_code == 403:
-        rv = cinder_snapshooter.utils.run_on_projects(
-            os_client,
-            process_function,
-            10,
-            [],
-        )
-        assert rv == []
-        assert os_client.connect_as.call_args_list == [
-            mocker.call(project_id=projects[0][1]),
-            mocker.call(trust_id=projects[1][0]),
-        ]
-        assert process_function.call_args_list == [
-            mocker.call(
-                {"project_id": projects[0][1]},
-            ),
-            mocker.call(
-                {"trust_id": projects[1][0]},
-            ),
-        ]
-    else:
-        with pytest.raises(keystoneauth1.exceptions.HTTPClientError):
-            cinder_snapshooter.utils.run_on_projects(
-                os_client,
-                process_function,
-                10,
-                [],
-            )
+    rv = cinder_snapshooter.utils.run_on_projects(
+        os_client,
+        process_function,
+        10,
+        [],
+    )
+    assert rv == []
+    assert os_client.connect_as.call_args_list == [
+        mocker.call(project_id=projects[0][1]),
+        mocker.call(trust_id=projects[1][0]),
+    ]
+    assert process_function.call_args_list == [
+        mocker.call(
+            {"project_id": projects[0][1]},
+        ),
+        mocker.call(
+            {"trust_id": projects[1][0]},
+        ),
+    ]