Merge pull request #856 from GemstoneGG/dev

Merge `dev` into `libdeflate`

Author: WouterGritter

README.md

@@ -153,7 +153,7 @@ consider utilizing JProfiler to enhance your experience and report any ongoing i
 
 ## Building
 
-Velocity is built with [Gradle](https://gradle.org). We recommend using the
+Velocity-CTD is built with [Gradle](https://gradle.org). We recommend using the
 wrapper script (`./gradlew`) as our CI builds using it.
 
 It is sufficient to run `./gradlew build` to run the full build cycle.
@@ -164,7 +164,7 @@ where our latest updates will be compiled and ready for use.
 ## Running
 
 Once you've built Velocity, you can copy and run the `-all` JAR from
-`proxy/build/libs`. Velocity will generate a default configuration file,
+`proxy/build/libs`. Velocity-CTD will generate a default configuration file,
 and you can configure it from there.
 
 ## Localisation

api/src/ap/java/com/velocitypowered/api/plugin/ap/PluginAnnotationProcessor.java

@@ -71,7 +71,7 @@ public PluginAnnotationProcessor() {
    * @param processingEnv the annotation processing environment
    */
   @Override
-  public synchronized void init(final ProcessingEnvironment processingEnv) {
+  public synchronized void init(ProcessingEnvironment processingEnv) {
     this.environment = processingEnv;
   }
 
@@ -95,8 +95,8 @@ public SourceVersion getSupportedSourceVersion() {
    * @return {@code true} if the annotations are claimed by this processor, {@code false} otherwise
    */
   @Override
-  public synchronized boolean process(final Set<? extends TypeElement> annotations,
-                                      final RoundEnvironment roundEnv) {
+  public synchronized boolean process(Set<? extends TypeElement> annotations,
+                                      RoundEnvironment roundEnv) {
     if (roundEnv.processingOver()) {
       return false;
     }

api/src/ap/java/com/velocitypowered/api/plugin/ap/SerializedPluginDescription.java

@@ -97,8 +97,8 @@ public final class SerializedPluginDescription {
    */
   private final String main;
 
-  private SerializedPluginDescription(final String id, final String name, final String version, final String description,
-                                      final String url, final List<String> authors, final List<Dependency> dependencies, final String main) {
+  private SerializedPluginDescription(String id, String name, String version, String description,
+                                      String url, List<String> authors, List<Dependency> dependencies, String main) {
     Preconditions.checkNotNull(id, "id");
     Preconditions.checkArgument(ID_PATTERN.matcher(id).matches(), "id is not valid");
     this.id = id;
@@ -112,7 +112,7 @@ private SerializedPluginDescription(final String id, final String name, final St
     this.main = Preconditions.checkNotNull(main, "main");
   }
 
-  static SerializedPluginDescription from(final Plugin plugin, final String qualifiedName) {
+  static SerializedPluginDescription from(Plugin plugin, String qualifiedName) {
     List<Dependency> dependencies = new ArrayList<>();
     for (com.velocitypowered.api.plugin.Dependency dependency : plugin.dependencies()) {
       dependencies.add(new Dependency(dependency.id(), dependency.optional()));
@@ -203,7 +203,7 @@ public String getMain() {
   }
 
   @Override
-  public boolean equals(final Object o) {
+  public boolean equals(Object o) {
     if (this == o) {
       return true;
     }
@@ -269,7 +269,7 @@ public static final class Dependency {
      * @param id the ID of the dependent plugin
      * @param optional whether the dependency is optional
      */
-    public Dependency(final String id, final boolean optional) {
+    public Dependency(String id, boolean optional) {
       this.id = id;
       this.optional = optional;
     }
@@ -295,7 +295,7 @@ public boolean isOptional() {
     }
 
     @Override
-    public boolean equals(final Object o) {
+    public boolean equals(Object o) {
       if (this == o) {
         return true;
       }

api/src/main/java/com/velocityctd/api/event/connection/ConnectionEstablishEvent.java

@@ -58,8 +58,8 @@ public class ConnectionEstablishEvent implements ResultedEvent<ResultedEvent.Gen
    * @param intention  the handshake intention of the client, or {@code null} if not yet determined
    * @throws NullPointerException if {@code connection} is null
    */
-  public ConnectionEstablishEvent(final @NonNull InboundConnection connection,
-                                  final @Nullable HandshakeIntent intention) {
+  public ConnectionEstablishEvent(@NonNull InboundConnection connection,
+                                  @Nullable HandshakeIntent intention) {
     this.connection = Preconditions.checkNotNull(connection, "connection");
     this.intention = intention;
   }
@@ -102,7 +102,7 @@ public GenericResult getResult() {
    * @throws NullPointerException if {@code result} is null
    */
   @Override
-  public void setResult(final @NonNull GenericResult result) {
+  public void setResult(@NonNull GenericResult result) {
     this.result = Preconditions.checkNotNull(result, "result");
   }
 }

api/src/main/java/com/velocityctd/api/event/player/TabCompleteRequestEvent.java

@@ -38,7 +38,7 @@ public class TabCompleteRequestEvent {
    * @param player the player who initiated the tab completion request
    * @param partialMessage the message being partially completed
    */
-  public TabCompleteRequestEvent(final Player player, final String partialMessage) {
+  public TabCompleteRequestEvent(Player player, String partialMessage) {
     this.player = checkNotNull(player, "player");
     this.partialMessage = checkNotNull(partialMessage, "partialMessage");
   }
@@ -66,7 +66,7 @@ public String getPartialMessage() {
    *
    * @param partialMessage the new partial message string
    */
-  public void setPartialMessage(final String partialMessage) {
+  public void setPartialMessage(String partialMessage) {
     this.partialMessage = partialMessage;
   }
 

api/src/main/java/com/velocityctd/api/queue/Queue.java

@@ -65,7 +65,7 @@ public interface Queue {
    *
    * @param player the player to remove
    */
-  default void dequeue(final @NotNull Player player) {
+  default void dequeue(@NotNull Player player) {
     dequeue(player.getUniqueId());
   }
 
@@ -83,7 +83,7 @@ default void dequeue(final @NotNull Player player) {
    * @param player the player to check
    * @return {@code true} if the player is queued
    */
-  default boolean contains(final @NotNull Player player) {
+  default boolean contains(@NotNull Player player) {
     return contains(player.getUniqueId());
   }
 
@@ -121,7 +121,7 @@ default boolean contains(final @NotNull Player player) {
    * @param player the player
    * @return the 1-based position, or {@link Optional#empty()}
    */
-  default Optional<Integer> getPosition(final @NotNull Player player) {
+  default Optional<Integer> getPosition(@NotNull Player player) {
     return getPosition(player.getUniqueId());
   }
 

api/src/main/java/com/velocitypowered/api/command/BrigadierCommand.java

@@ -40,7 +40,7 @@ public final class BrigadierCommand implements Command {
    *
    * @param builder the {@link LiteralCommandNode} builder
    */
-  public BrigadierCommand(final @NotNull LiteralArgumentBuilder<CommandSource> builder) {
+  public BrigadierCommand(@NotNull LiteralArgumentBuilder<CommandSource> builder) {
     this(Preconditions.checkNotNull(builder, "builder").build());
   }
 
@@ -49,7 +49,7 @@ public BrigadierCommand(final @NotNull LiteralArgumentBuilder<CommandSource> bui
    *
    * @param node the command node
    */
-  public BrigadierCommand(final @NotNull LiteralCommandNode<CommandSource> node) {
+  public BrigadierCommand(@NotNull LiteralCommandNode<CommandSource> node) {
     this.node = Preconditions.checkNotNull(node, "node");
   }
 
@@ -69,7 +69,7 @@ public LiteralCommandNode<CommandSource> getNode() {
    * @return a new LiteralArgumentBuilder.
    */
   public static LiteralArgumentBuilder<CommandSource> literalArgumentBuilder(
-          final @NotNull String name) {
+          @NotNull String name) {
     Preconditions.checkNotNull(name, "name");
     // Validation to avoid beginner's errors in case someone includes a space in the argument name
     Preconditions.checkArgument(name.indexOf(' ') == -1, "the argument name cannot contain spaces");
@@ -85,7 +85,7 @@ public static LiteralArgumentBuilder<CommandSource> literalArgumentBuilder(
    * @return a new RequiredArgumentBuilder
    */
   public static <T> RequiredArgumentBuilder<CommandSource, T> requiredArgumentBuilder(
-          final @NotNull String name, final @NotNull ArgumentType<T> argumentType) {
+          @NotNull String name, @NotNull ArgumentType<T> argumentType) {
     Preconditions.checkNotNull(name, "name");
     Preconditions.checkNotNull(argumentType, "argument type");
 

api/src/main/java/com/velocitypowered/api/command/CommandSource.java

@@ -26,7 +26,7 @@ public interface CommandSource extends Audience, PermissionSubject {
    * @see <a href="https://docs.papermc.io/adventure/minimessage/format/">MiniMessage docs</a>
    *      for more information on the format.
    */
-  default void sendRichMessage(final @NotNull String message) {
+  default void sendRichMessage(@NotNull String message) {
     this.sendMessage(MiniMessage.miniMessage().deserialize(message, this));
   }
 
@@ -39,8 +39,8 @@ default void sendRichMessage(final @NotNull String message) {
    *     and <a href="https://docs.papermc.io/adventure/minimessage/dynamic-replacements">MiniMessage Placeholders docs</a>
    *     for more information on the format.
    */
-  default void sendRichMessage(final @NotNull String message,
-                               final @NotNull TagResolver @NotNull... resolvers) {
+  default void sendRichMessage(@NotNull String message,
+                               @NotNull TagResolver @NotNull... resolvers) {
     this.sendMessage(MiniMessage.miniMessage().deserialize(message, this, resolvers));
   }
 
@@ -52,7 +52,7 @@ default void sendRichMessage(final @NotNull String message,
    *      however, it is recommended not to use legacy color codes as this is a deprecated format
    *      and not recommended.
    */
-  default void sendPlainMessage(final @NotNull String message) {
+  default void sendPlainMessage(@NotNull String message) {
     this.sendMessage(Component.text(message));
   }
 }

api/src/main/java/com/velocitypowered/api/command/InvocableCommand.java

@@ -36,7 +36,7 @@ public sealed interface InvocableCommand<I extends CommandInvocation<?>> extends
    * @param invocation the invocation context
    * @return the tab complete suggestions
    */
-  default List<String> suggest(final I invocation) {
+  default List<String> suggest(I invocation) {
     return ImmutableList.of();
   }
 
@@ -47,7 +47,7 @@ default List<String> suggest(final I invocation) {
    * @return the tab complete suggestions
    * @implSpec defaults to wrapping the value returned by {@link #suggest(CommandInvocation)}
    */
-  default CompletableFuture<List<String>> suggestAsync(final I invocation) {
+  default CompletableFuture<List<String>> suggestAsync(I invocation) {
     return CompletableFuture.completedFuture(suggest(invocation));
   }
 
@@ -60,7 +60,7 @@ default CompletableFuture<List<String>> suggestAsync(final I invocation) {
    * @param invocation the invocation context
    * @return {@code true} if the source has permission
    */
-  default boolean hasPermission(final I invocation) {
+  default boolean hasPermission(I invocation) {
     return true;
   }
 }

api/src/main/java/com/velocitypowered/api/command/VelocityBrigadierMessage.java

@@ -26,7 +26,7 @@ public final class VelocityBrigadierMessage implements Message, ComponentLike {
    * @param message the component to use as the tooltip message
    * @return a new instance of {@link VelocityBrigadierMessage}
    */
-  public static VelocityBrigadierMessage tooltip(final Component message) {
+  public static VelocityBrigadierMessage tooltip(Component message) {
     return new VelocityBrigadierMessage(message);
   }
 
@@ -38,7 +38,7 @@ public static VelocityBrigadierMessage tooltip(final Component message) {
    */
   private final Component message;
 
-  private VelocityBrigadierMessage(final Component message) {
+  private VelocityBrigadierMessage(Component message) {
     this.message = Preconditions.checkNotNull(message, "message");
   }