Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grdvs30.c cannot use value in -C #8677

Closed
CovMat opened this issue Jan 16, 2025 · 1 comment
Closed

grdvs30.c cannot use value in -C #8677

CovMat opened this issue Jan 16, 2025 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@CovMat
Copy link
Contributor

CovMat commented Jan 16, 2025

usage and code of grdvs30.c should be rewrited:

https://github.com/GenericMappingTools/gmt/blob/master/src/seis/grdvs30.c#L183-L197

now the code cannot distinguish value from filename. If you give -C1, it will see 1 as a filename

#8676

@CovMat CovMat added the bug Something isn't working label Jan 16, 2025
joa-quim added a commit that referenced this issue Jan 17, 2025
@seisman seisman added this to the 6.6.0 milestone Jan 17, 2025
remkos pushed a commit that referenced this issue Jan 17, 2025
@joa-quim
Copy link
Member

Fixed that, and other issues, in #8678.

In fact the numeric value for -C was working, just that anothrt checking routine to see if that was a file or a number printed a misleading message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants