-
-
Notifications
You must be signed in to change notification settings - Fork 12.3k
[Draft] Forward client audio #6439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
9d10730 to
df655e4
Compare
|
|
||
| int read_mic(void *data) { | ||
| sc_socket mic_socket = *(sc_socket*)data; | ||
| const char *input_format_name = "alsa"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is only available on Linux? Can SDL be used instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yume-chan it should work on other platforms if you change alsa to something appropriate? We might want input_format_name to be passed as an argument.
It's possible to list the available input devices with
const AVInputFormat *fmt = NULL;
fmt = av_input_audio_device_next(NULL);
while (fmt) {
printf("%s: %s\n",
fmt->name,
fmt->long_name ? fmt->long_name : "(no description)"
);
fmt = av_input_audio_device_next(fmt);
}This is what I see on linux:
alsa: ALSA audio input
jack: JACK Audio Connection Kit
lavfi: Libavfilter virtual input device
oss: OSS (Open Sound System) capture
pulse: Pulse audio input
|
Looking forward to this feature, would be really good in phone call experience while working for instance. |
This is a WIP based on the poc by @yume-chan to add the feature requested in #3880