Some headers don't compile independently

[abmukh]

Tried executing a basic try code Try1.cpp in vol_test/examples/Sampling_New:

   #include<stdio.h>
   #include "random_walks.hpp"
   using namespace std;
   int main()
   {
        cout<<"Ran"<<endl;
        return 0;
   } 

Returned the following error (sqrt,pow not a member of std):

Resolved that by using #include<cmath> . However cmath ideally should not have been needed to be included.

[vissarion]

This is part of a more general issue probably. Could you test which headers cannot be included separately?

[abmukh]

I did a partial check. The try code is available as the same name in the same directory, now modified . Here is what I found :
Those that need headers :

1. Containers ( Checked for <array>,<deque>,<forward_list>,<map>,<unordered_map>,<unordered_set>,<stack>,<queue>,<vector>)
2. Numeric Limits (Checked for <cfloat>,<cinttype>,<climits>,<cstdint>)
3. Numeric Library ( Checked for <cmath>,<cfenv>,<complex>,<random>,<numeric>,<ratio>,<valarray>)
   Those that do not need header files:
4. String Libraries ( Checked for <cctype>,<cstring>,<string>)
5. Error Handling ( Checked for <cassert>,<cerrno>,<exception>)
6. I/O ( Checked for <iostream>,<cstdio>)
7. Algorithms ( Checked for <algorithm>)
   Will add if I encounter more

[aditiaher]

Try by adding header file #include<bits/stdc++.h>

[vissarion]

The goal here is that every header file should include the headers that are needed to be included autonomously. For example, the issue above is caused by boundary_cdhr_walk.hpp that misses #include<cmath>.

@abmukh if you want to give it a try please open a PR.

[Neel-Shah-29]

Hello i would like to try this issue. I only need to include the cmath header file in boundary_cdhr_walk.hpp right?
Also if there are any other header files that needs to be included than kindly let me know. Thanks!

[himanshuParashar0101]

hi kindly assign this issue to me
I think we should give all the header file into a one header file likes its kind of merging the header file and making our own header that reads the data from it

[Neel-Shah-29]

Hey @Himanshu i am already trying this issue and have sent a PR regarding it , so you can give your suggestions in PR if you want ,i can resolve it .