Merge pull request #107 from GeoscienceAustralia/dem_update2

dem_h to dem_s transition: updated `starts_da` variable in connectivity function to use 0 m elevations instead of nodata pixels

Author: erialC-P

intertidal/extents.py

@@ -224,12 +224,12 @@ def load_connectivity_mask(
         print("Adding GMW mangroves to starting points")
         try:
             gmw_da = load_gmw_mask(dem_da)
-            starts_da = (dem_da == dem_da.nodata) | gmw_da
+            starts_da = (dem_da == 0) | gmw_da
         except Exception as e:
             print(f"No valid GMW mangroves found: {e}")
-            starts_da = dem_da == dem_da.nodata
+            starts_da = dem_da == 0
     else:
-        starts_da = dem_da == dem_da.nodata
+        starts_da = dem_da == 0
 
     # Raise error if no valid starting points
     if not starts_da.any():

tests/README.md

@@ -10,7 +10,7 @@ Integration tests
 
 This directory contains tests that are run to verify that DEA Intertidal code runs correctly. The ``test_intertidal.py`` file runs a small-scale full workflow analysis over an intertidal flat in the Gulf of Carpentaria using the DEA Intertidal [Command Line Interface (CLI) tools](../notebooks/Intertidal_CLI.ipynb), and compares these results against a LiDAR validation DEM to produce some simple accuracy metrics.
 
-The latest integration test completed at **2025-02-26 12:17**. Compared to the previous run, it had an:
+The latest integration test completed at **2025-03-17 15:59**. Compared to the previous run, it had an:
 - RMSE accuracy of **0.14 m ( :heavy_minus_sign: no change)**
 - MAE accuracy of **0.12 m ( :heavy_minus_sign: no change)**
 - Bias of **0.12 m ( :heavy_minus_sign: no change)**

tests/validation.csv

@@ -75,3 +75,4 @@ time,Correlation,RMSE,MAE,R-squared,Bias,Regression slope
 2025-02-14 02:17:10.429447+00:00,0.975,0.145,0.123,0.95,0.117,1.119
 2025-02-17 03:17:15.481317+00:00,0.975,0.145,0.123,0.95,0.117,1.119
 2025-02-26 01:17:17.566788+00:00,0.975,0.145,0.123,0.95,0.117,1.119
+2025-03-17 04:59:10.880279+00:00,0.975,0.145,0.123,0.95,0.117,1.119