Skip to content

Commit ee41ef6

Browse files
committed
[lumen] build docker image with current commit to prevent grabbing wrong tarball
1 parent c763b28 commit ee41ef6

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

Makefile

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,13 @@ IMAGE_NAME ?= llvm
44
XDG_DATA_HOME ?= $(HOME)/.local/share
55
BUILD_DOCS ?= OFF
66
RELEASE ?= 10.0.0
7+
SHA ?= `git rev-parse --short HEAD`
78
CWD = `pwd`
89

910
help:
10-
@echo "$(IMAGE_NAME):$(RELEASE) (docs=$(BUILD_DOCS))"
11+
@echo "$(IMAGE_NAME):$(RELEASE)-$(SHA) (docs=$(BUILD_DOCS))"
1112
@echo ""
12-
@perl -nle'print $& if m{^[a-zA-Z_-]+:.*?## .*$$}' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'
13+
@perl -nle'print $& if m{^[a-zA-Z_-]+:.*?## .*$$}' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-20s\033[0m %s\n", $$1, $$2}'
1314

1415
clean: ## Clean up generated artifacts
1516
@rm -rf build/host
@@ -82,10 +83,10 @@ dist-linux: ## Build an LLVM release distribution for x86_64-unknown-linux
8283
@mkdir -p build/packages/ && \
8384
cd lumen/ && \
8485
docker build \
85-
-t llvm-project:dist \
86+
-t llvm-project:dist-$(RELEASE)-$(SHA) \
8687
--target=dist \
8788
--build-arg buildscript_args="-release=$(RELEASE) -clean-obj" . && \
88-
utils/dist/extract-release.sh -release $(RELEASE)
89+
utils/dist/extract-release.sh -release $(RELEASE) -sha $(SHA)
8990

9091
docker: ## Build a Docker image containing an LLVM distribution
9192
cd lumen/ && \

lumen/utils/dist/extract-release.sh

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd -P)"
66
PACKAGES_DIR="$(cd "$SCRIPT_DIR"/../../../build/packages && pwd -P)"
77

88
release=""
9+
sha=""
910

1011
while [ $# -gt 0 ]; do
1112
case $1 in
@@ -14,6 +15,11 @@ while [ $# -gt 0 ]; do
1415
release="$1"
1516
shift
1617
;;
18+
-sha | --sha )
19+
shift
20+
sha="$1"
21+
shift
22+
;;
1723
*)
1824
echo "unknown option: $1"
1925
exit 2
@@ -26,8 +32,13 @@ if [ -z "$release" ]; then
2632
exit 2
2733
fi
2834

35+
if [ -z "$sha" ]; then
36+
echo "error: no sha hash specified"
37+
exit 2
38+
fi
39+
2940
cd "$PACKAGES_DIR"
30-
if ! id="$(docker create llvm-project:dist sh)"; then
41+
if ! id="$(docker create llvm-project:dist-${release}-${sha} sh)"; then
3142
echo "Could not create dist container!"
3243
exit 2
3344
fi

0 commit comments

Comments
 (0)