Skip to content

Commit b67a6a2

Browse files
authored
Merge pull request #90 from GetStream/fix-issue-89
2 parents 2f4d6cd + 67d2857 commit b67a6a2

File tree

6 files changed

+87
-4
lines changed

6 files changed

+87
-4
lines changed

example/lib/main.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ void main() {
99
WidgetsFlutterBinding.ensureInitialized();
1010
final _key = String.fromEnvironment('key');
1111
final _user_token = String.fromEnvironment('user_token');
12-
final client = StreamFeedClient.connect(_key, userToken: _user_token);
12+
final client = StreamFeedClient.connect(_key, token: Token(_user_token));
1313
runApp(
1414
MyApp(
1515
client: client,

packages/stream_feed/lib/src/core/models/realtime_message.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import 'package:stream_feed/src/core/models/activity.dart';
55
import 'package:stream_feed/src/core/models/feed_id.dart';
66

77
import 'package:stream_feed/src/core/models/foreign_id_time_pair.dart';
8+
import 'package:stream_feed/stream_feed.dart';
89

910
part 'realtime_message.g.dart';
1011

@@ -16,7 +17,7 @@ class RealtimeMessage extends Equatable {
1617
required this.feed,
1718
this.deleted = const <String>[],
1819
this.deletedForeignIds = const <ForeignIdTimePair>[],
19-
this.newActivities = const <Activity>[],
20+
this.newActivities = const <EnrichedActivity>[],
2021
this.appId,
2122
this.publishedAt,
2223
});
@@ -45,7 +46,7 @@ class RealtimeMessage extends Equatable {
4546

4647
/// All activities created by this update
4748
@JsonKey(name: 'new')
48-
final List<Activity> newActivities;
49+
final List<EnrichedActivity> newActivities;
4950

5051
/// Time of the update in ISO format
5152
@JsonKey(includeIfNull: false)

packages/stream_feed/lib/src/core/models/realtime_message.g.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
{
2+
"deleted": [],
3+
"deleted_foreign_ids": [],
4+
"feed": "reward:1",
5+
"new": [
6+
{
7+
"actor": "reward:1",
8+
"foreign_id": null,
9+
"id": "f3de8328-be2d-11eb-bb18-128a130028af",
10+
"message": "@Jessica check out getstream.io it's so dang awesome.",
11+
"object": "tweet:id",
12+
"origin": null,
13+
"target": null,
14+
"time": "2021-05-26T14:23:33.918391",
15+
"to": ["notification:jessica"],
16+
"verb": "tweet"
17+
}
18+
]
19+
}
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
{
2+
"deleted": [],
3+
"deleted_foreign_ids": [],
4+
"feed": "task: 32db0f46-3593-4e14-aa57-f05af4887260",
5+
"new": [
6+
{
7+
"actor": {
8+
"created_at": "2021-04-13T22:53:19.670051Z",
9+
"updated_at": "2021-04-13T22:53:19.670051Z",
10+
"id": "eTHVBnEm0FQB2HeaRKVlEfVf58B3personal",
11+
"data": {
12+
"gender": "Male",
13+
"name": "Rickey Lee",
14+
"photo": "https://firebasestorage.googleapis.com/v0/b/fire-snab.appspot.com/o/profile-image-placeholder.png?alt=media&token=b17598bb-a510-4167-8354-ab75642ba89e"
15+
}
16+
},
17+
"createdTask": {
18+
"id": "32db0f46-3593-4e14-aa57-f05af4887260",
19+
"title": "KeyPack",
20+
"isFinished": true
21+
},
22+
"foreign_id": null,
23+
"group": "updated_2021-06-09",
24+
"id": "cff95542-c979-11eb-8080-80005abdd229",
25+
"object": "task_situation_updated to true",
26+
"origin": null,
27+
"target": null,
28+
"time": "2021-06-09T23:24:18.238189",
29+
"verb": "updated"
30+
}
31+
]
32+
}

packages/stream_feed/test/models_test.dart

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,38 @@ void main() {
125125
});
126126
});
127127
});
128+
group('RealtimeMessage', () {
129+
test('fromJson', () {
130+
final fromJson =
131+
RealtimeMessage.fromJson(jsonFixture('realtime_message.json'));
132+
133+
expect(
134+
fromJson,
135+
RealtimeMessage(
136+
deleted: [],
137+
deletedForeignIds: [],
138+
feed: FeedId.fromId('reward:1'),
139+
newActivities: [
140+
EnrichedActivity(
141+
actor: EnrichableField('reward:1'),
142+
id: 'f3de8328-be2d-11eb-bb18-128a130028af',
143+
extraData: {
144+
'message':
145+
"@Jessica check out getstream.io it's so dang awesome.",
146+
},
147+
origin: EnrichableField(null),
148+
target: EnrichableField(null),
149+
object: EnrichableField('tweet:id'),
150+
time: DateTime.parse('2021-05-26T14:23:33.918391'),
151+
to: ['notification:jessica'],
152+
verb: 'tweet')
153+
]));
154+
});
128155

156+
test('issue-89', () {
157+
RealtimeMessage.fromJson(jsonFixture('realtime_message_issue89.json'));
158+
});
159+
});
129160
test('EnrichedActivity issue 61', () {
130161
final enrichedActivity = EnrichedActivity.fromJson(
131162
jsonFixture('enriched_activity_issue61.json'));

0 commit comments

Comments
 (0)