Merge pull request #228 from GetStream/bugfix/uni-189-fix-null-ref

Add null ref guards

Author: sierpinskid

Packages/StreamVideo/Runtime/Core/LowLevelClient/API/Internal/InternalApiClientBase.cs

@@ -113,7 +113,14 @@ private async Task<TResponse> HttpRequest<TResponse>(HttpMethodType httpMethod,
                 catch (Exception e)
                 {
                     LogRestCall(uri, endpoint, httpMethod, responseContent, success: false, logContent);
-                    throw new StreamDeserializationException(responseContent, typeof(TResponse), e);
+                    throw new StreamDeserializationException(responseContent, typeof(APIErrorInternalDTO), e);
+                }
+
+                if (apiError == null)
+                {
+                    LogRestCall(uri, endpoint, httpMethod, responseContent, success: false, logContent);
+                    throw new StreamDeserializationException(responseContent, typeof(APIErrorInternalDTO),
+                        new InvalidOperationException("Deserializer returned null"));
                 }
 
                 if (apiError.Code != InvalidAuthTokenErrorCode)
@@ -165,6 +172,13 @@ private async Task<TResponse> HttpRequest<TResponse>(HttpMethodType httpMethod,
             try
             {
                 var response = _serializer.Deserialize<TResponse>(responseContent);
+                if (response == null)
+                {
+                    LogRestCall(uri, endpoint, httpMethod, responseContent, success: false, logContent);
+                    throw new StreamDeserializationException(responseContent, typeof(TResponse),
+                        new InvalidOperationException("Deserializer returned null"));
+                }
+
                 LogRestCall(uri, endpoint, httpMethod, responseContent, success: true, logContent);
                 return response;
             }

Packages/StreamVideo/Runtime/Core/LowLevelClient/RtcSession.cs

@@ -490,12 +490,8 @@ public async Task DoJoin(JoinCallData joinCallData, CancellationToken cancellati
                         $"{nameof(DoJoin)} - Skipped join call request: callExists: {callCredentialsExists}, isRejoin: {isRejoin}, isMigration: {isMigration}");
                 }
 
-                ActiveCall = call ?? throw new NullReferenceException(nameof(call));
-
-                if (ActiveCall.Credentials == null || string.IsNullOrEmpty(ActiveCall.Credentials.Token))
-                {
-                    _logs.ErrorIfDebug($"{nameof(DoJoin)} - Missing credentials!");
-                }
+                ActiveCall = call;
+                EnsureCallHasJoinCredentials(ActiveCall);
 
                 _httpClient = _httpClientFactory(ActiveCall);
 
@@ -745,13 +741,46 @@ private async Task<StreamCall> ExecuteJoinRequest(JoinCallData data, Cancellatio
 
             var joinCallResponse
                 = await _lowLevelClient.InternalVideoClientApi.JoinCallAsync(data.Type, data.Id, joinCallRequest);
+            if (joinCallResponse == null)
+            {
+                throw new InvalidOperationException(
+                    $"Join call API returned an empty response for `{data.Type}:{data.Id}`.");
+            }
+
             var streamCall = _cache.TryCreateOrUpdate(joinCallResponse);
+            if (streamCall == null)
+            {
+                throw new InvalidOperationException(
+                    $"Join call API response could not be applied for `{data.Type}:{data.Id}`.");
+            }
 
             //StreamTODO: add ring accept logic. Check JS doJoinRequest
 
             return streamCall;
         }
 
+        private static void EnsureCallHasJoinCredentials(StreamCall call)
+        {
+            if (call == null)
+            {
+                throw new InvalidOperationException("Join call response did not contain call data.");
+            }
+
+            var credentials = call.Credentials;
+            if (credentials == null || string.IsNullOrEmpty(credentials.Token))
+            {
+                throw new InvalidOperationException(
+                    $"Join call response for `{call.Cid}` is missing credentials or token.");
+            }
+
+            var server = credentials.Server;
+            if (server == null || string.IsNullOrEmpty(server.Url))
+            {
+                throw new InvalidOperationException(
+                    $"Join call response for `{call.Cid}` is missing SFU server URL.");
+            }
+        }
+
         public Task StopAsync(string reason = "")
         {
             if (UseNativeAudioBindings)