Plugin.yml version field not valid semver

[brandonryan]

Describe the bug

I was writing a tool to help manage my minecraft plugins for my server. Part of this tool reads the metadata of the current plugins to check which ones are out of date.

The latest version 2.2.5-SNAPSHOT (b121-55a85ec) does not follow the semver spec. Breaks my semver parsing tool.

If you want to add build metadata you could do so like 2.2.5-SNAPSHOT+b121-55a85ec

Please see the semver spec for more details.

P.S.
I have a workaround for now by using a custom parser, but I would rather not have to write custom code to handle invalid semver.

Thanks for the consideration. This plugin is amazing.

[Tim203]

I've never really considered the fact that people may look at the version in plugin.yml. I've added that build information there because it helps us distinguish between builds in a clean way, it was never really meant to follow semver.
I'll consider it but in general I want you to know that we don't really follow semver exactly.

The way that I've done it in the past is that bugfixes generally don't bump the version at all, instead it's a specific build (so on the metadata would change if we were to be semver string compatible). This is already a violation of semver where the patch version must be incremented when backwards compatible bugs are fixed.
If new (backwards compatible) API is added then our patch version gets incremented, which if we were to follow semver would require a bump in the minor version.
Our way of versioning more closely resembles Romantic Versioning, which is also what we're going to use once Floodgate 3.0 hits for our API components and internal versioning see: https://github.com/GeyserMC/api/blob/master/geyser-versioning.md

I just wanted to say that bit to hopefully help you better interpret what to do with the version Floodgate provides.

[brandonryan]

Ok no worries. It's not really a big deal for me just wanted to put it out there. Thank you 😁