Skip to content

Commit ad7a94e

Browse files
authored
Merge pull request #1841 from EliahKagan/no-esc-todo
Remove TODOs about using `path-slash` to handle escapes
2 parents bb64ee1 + a810d1f commit ad7a94e

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

gix-path/src/convert.rs

-2
Original file line numberDiff line numberDiff line change
@@ -233,15 +233,13 @@ pub fn to_unix_separators_on_windows<'a>(path: impl Into<Cow<'a, BStr>>) -> Cow<
233233
/// Replace Windows path separators with slashes, which typically resembles a Unix path, unconditionally.
234234
///
235235
/// **Note** Do not use these and prefer the conditional versions of this method.
236-
// TODO: use https://lib.rs/crates/path-slash to handle escapes
237236
pub fn to_unix_separators<'a>(path: impl Into<Cow<'a, BStr>>) -> Cow<'a, BStr> {
238237
replace(path, b'\\', b'/')
239238
}
240239

241240
/// Find slashes and replace them with backslashes, unconditionally.
242241
///
243242
/// **Note** Do not use these and prefer the conditional versions of this method.
244-
// TODO: use https://lib.rs/crates/path-slash to handle escapes
245243
pub fn to_windows_separators<'a>(path: impl Into<Cow<'a, BStr>>) -> Cow<'a, BStr> {
246244
replace(path, b'/', b'\\')
247245
}

0 commit comments

Comments
 (0)