-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obsolete version of OS on the server #98
Comments
@aminlatifi Can you dockerize this setup? So that we can easily migrate it? CC: @geleeroyale once this is dockerized, we can easily set it up later |
It hosts two services, givpower-bot (production) and givfarm notify reward. |
thanks - we already moved the givpower-bot - we will migrate givfarm-notify after we hopefully fixed the current errors in prod |
I think it's better to finally to gelato service for these kind of things. Then we won't need to keep a server for these kind of stuff. |
@geleeroyale @mhmdksh what's the final status of this? still notify reward is there? |
@aminlatifi I can not find a deployment or exact repo for givfarm-notify.
Can we take a look at this? |
@geleeroyale the repo is giv-token-contracts |
@aminlatifi I am sorry, but all I see in this repo are contracts and contract deployments for hardhat - I can't find any services |
There are scripts run every hour by cron job. |
I cloned the repo onto our
after
I was able to run one of the cronjob scripts, but it fails with an error: It would be awesome if you could clean up the repository to a point of reproducability @aminlatifi - I can't run it in the current state. |
@geleeroyale Thanks for your effort so far. If you have prepared a safe server, I can work on make it run on that and solve issues. |
Do you have any update on this @aminlatifi - do you need support? |
@jainkrati This issue seems to be stuck because the deployment is totally outdated at this point. I was not able to correctly install and it seems like @aminlatifi also got stuck at some point. My suggestion is to factor out |
@geleeroyale Do we have a source document to tell us what is deployed where? If we have it, it would be super helpful since by looking at that we can better decide what must be deployed where. |
@geleeroyale Can you give me access to new server then I can deploy notify reward bot there FYI @aminlatifi |
Access to server has been granted, please give an update on this @mohammadranjbarz |
@mohammadranjbarz Did you manage to deploy notify reward on the services instance? |
Do you recognize what these services do? I think they are related to some GIVeconomy infra. If the services are important I think this should go on your radar and see if we can get some help to work on it. |
I just had to switch out some keys on givpower and givnotify (we know why!) and took this opportunity to put the scripts on the new instance as well as the cronjobs (I escaped them for now, but to activate we just need to delete the # and off we go). However I am not sure how it looks properly, so it would be great if @mohammadranjbarz or @aminlatifi could have a look at |
In my view the migration is complete, we must wait for the next automated notify rewards to be sure everything is okay. |
@divine-comedian |
I think is is a devOps issue so not aware if it needs to be tested or if so, how it can be tested. @geleeroyale or @aminlatifi could provide clarity I think. If we need to test notify reward and check APRs are what we expect I think @laurenluz would know what those should be back on rewards distribution we set. |
According to @aminlatifi we have to wait for the next automated notify-reward to execute in order to evaluate of our new deployment is successful (success is expected). And - yes it is a devOPS issue, you don't have to watch this, we will close it on our own. |
Hey @aminlatifi - how did it go? Do you think we can decommission the old server now? |
Yes, it worked. We can turn off the old one |
@geleeroyale @aminlatifi if this issue is resolved let's close it! |
@geleeroyale, please update here if you have turned off and removed the server. Feel free to close it as well |
The server we run the farming notify reward bot on runs with an obsolete OS version. It may have security vulnerabilities itself and also doesn't allow us to run updated versions of node.js. As we have to run our scripts with node v14 which is too old.
The server OS must be upgraded for its own security and won't be a blocker in the future for further development.
The text was updated successfully, but these errors were encountered: