Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Views paragraph type [2h] #331

Open
isapisa opened this issue Oct 3, 2022 · 9 comments
Open

Change the Views paragraph type [2h] #331

isapisa opened this issue Oct 3, 2022 · 9 comments
Assignees

Comments

@isapisa
Copy link
Contributor

isapisa commented Oct 3, 2022

Issue

As part of Drupal Starter we now have the views paragraph type part of a landing page CT. However, until we defined possible views to reference/select, this is causing confusion, errors for QA.
Can we change this in D starter?

image

Solution:
We can change this to pre-defined selection of views, and only allow Embed types, which is what we end up doing on most projects

To Do

  • Implement ^^ for drupal starter
@bboro
Copy link
Collaborator

bboro commented Oct 6, 2022

@isapisa this is now done for Drupal-starter.

@isapisa isapisa closed this as completed Oct 6, 2022
@amitaibu
Copy link
Member

Right now a content admin needs to select a View and then the display (e.g. Embed). IMO This requires too much knowledge from the content editor.

How about changing the select list to hold only the Views that have an Embed display? And if a certain View has several embeds it can appear in the name. So for example a list could look like this:

  • Recent events
  • Recent news
  • Publications (Embed1)
  • Publications (Another display name of an Embed)

@amitaibu amitaibu reopened this Oct 10, 2022
@amitaibu
Copy link
Member

@isapisa @bboro Thought of it a bit more. Maybe we don't need this Paragraph type at all - is there a real use case for it, where we don't reach out to custom code? If needed the custom code could call views for us - but right now it's likely going to be confusing for a content editor, when to use this paragraph type.

@isapisa
Copy link
Contributor Author

isapisa commented Oct 26, 2022

@amitaibu and instead we'd just have a paragraph type called Recent events ?

@amitaibu
Copy link
Member

Yes. Recent events, Recent news, ...

@isapisa
Copy link
Contributor Author

isapisa commented Oct 26, 2022

sounds good to me

@bboro
Copy link
Collaborator

bboro commented Nov 23, 2023

@isapisa @amitaibu can this be closed?

@isapisa
Copy link
Contributor Author

isapisa commented Nov 24, 2023

@bboro don't know, as far as I know this hasn't been done in DS, but only on recent projects?

@amitaibu
Copy link
Member

If there's still a Views paragraph on DS we should remove it, in favor of specific paragaph types (e.g. Recent news). By removing the generic names, content editors can find what they need with more ease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants