make golint happy

Author: vincent-petithory

dataurl.go

@@ -13,8 +13,10 @@ import (
 )
 
 const (
+	// EncodingBase64 is base64 encoding for the data url
 	EncodingBase64 = "base64"
-	EncodingASCII  = "ascii"
+	// EncodingASCII is ascii encoding for the data url
+	EncodingASCII = "ascii"
 )
 
 func defaultMediaType() MediaType {
@@ -33,6 +35,7 @@ type MediaType struct {
 	Params  map[string]string
 }
 
+// ContentType returns the content type of the dataurl's data, in the form type/subtype.
 func (mt *MediaType) ContentType() string {
 	return fmt.Sprintf("%s/%s", mt.Type, mt.Subtype)
 }
@@ -180,7 +183,7 @@ func (p *parser) parse() error {
 		case itemLeftStringQuote:
 			p.unquoteParamVal = true
 		case itemParamVal:
-			var val string = item.val
+			val := item.val
 			if p.unquoteParamVal {
 				p.unquoteParamVal = false
 				us, err := strconv.Unquote("\"" + val + "\"")

dataurl_test.go

@@ -228,7 +228,7 @@ func expectItems(expected, actual []item) bool {
 	if len(expected) != len(actual) {
 		return false
 	}
-	for i, _ := range expected {
+	for i := range expected {
 		if expected[i].t != actual[i].t {
 			return false
 		}
@@ -260,7 +260,7 @@ func equal(du1, du2 *DataURL) (bool, error) {
 func TestLexDataURLs(t *testing.T) {
 	for _, test := range genTestTable() {
 		l := lex(test.InputRawDataURL)
-		items := make([]item, 0)
+		var items []item
 		for item := range l.items {
 			items = append(items, item)
 		}

lex.go

@@ -480,9 +480,8 @@ func lexDataComma(l *lexer) stateFn {
 	l.emit(itemDataComma)
 	if l.seenBase64Item {
 		return lexBase64Data
-	} else {
-		return lexData
 	}
+	return lexData
 }
 
 func lexData(l *lexer) stateFn {