Hey,
Ideally the package should be automated through package distributions, but since it's not.
uninstall.sh does not delete everything.
If you check dkms status | grep maccel may contain other versions kept installed.
So, a command like sudo dkms remove maccel/{version} --all needs to be ran. Perhaps uninstall script should be improved to include that.
Alternatively, you could automate everything through the CLI, the install and uninstall, and not need sh scripts anymore.
Then there would be a command to install and one to uninstall.
sudo maccel install / uninstall
sudo requirement only to those two commands.
Then a simple cargo install / binstall would be enough for distrib. Even other package distrib would be less needed. As it is much simpler to update a cargo package.
However it should not be bash / sh based, do as much as possible through programmatic ways for better compatibility.
Logging should show each step being done to which folder. No step left for the user to do, not even add the user to maccel group.
An additional thing, could be an upgrade command, if required, because unless an package upgrade is enough to trigger files changes, there should be a command to upgrade, and suggested after each update. Doing the minimal required to the already installed tool. Or automatically do it on new version install.
/opt/maccel/ might also not be needed.
#71
Hey,
Ideally the package should be automated through package distributions, but since it's not.
uninstall.shdoes not delete everything.If you check
dkms status | grep maccelmay contain other versions kept installed.So, a command like
sudo dkms remove maccel/{version} --allneeds to be ran. Perhaps uninstall script should be improved to include that.Alternatively, you could automate everything through the CLI, the install and uninstall, and not need sh scripts anymore.
Then there would be a command to install and one to uninstall.
sudo maccel install / uninstallsudorequirement only to those two commands.Then a simple
cargo install / binstallwould be enough for distrib. Even other package distrib would be less needed. As it is much simpler to update a cargo package.However it should not be bash / sh based, do as much as possible through programmatic ways for better compatibility.
Logging should show each step being done to which folder. No step left for the user to do, not even add the user to maccel group.
An additional thing, could be an upgrade command, if required, because unless an package upgrade is enough to trigger files changes, there should be a command to upgrade, and suggested after each update. Doing the minimal required to the already installed tool. Or automatically do it on new version install.
/opt/maccel/might also not be needed.#71