fix: Resolve moved features and refactor evolution handling (#1772)

* fix: Return correct feature evolution data for moved and split features

The primary changes are:
- The `GetMovedWebFeatureDetailsByOriginalFeatureKey` function has been fixed. It was previously returning the internal database ID of the new feature; it now correctly returns the human-readable feature key, as intended.
- The main feature query has been updated to join against a new `SplitWebFeatures` table. The `GET /v1/features` and `GET /v1/features/{feature_id}` endpoints now include an `evolution` object in the response. This object contains `split_off_info` which lists any features that have been split off from the primary feature.

To support this, the following changes were also made:
- The `openapi.yaml` specification has been updated to include the new `evolution` fields in the `Feature` schema.
- The fake data generation process in `util/cmd/load_fake_data` has been significantly enhanced to create more realistic test data for feature evolution, including scenarios for moved, fully split, and partially split features.
- End-to-end tests and snapshots have been updated to reflect the new data structures and the changes in the underlying test data.start

There needs to be some frontend changes. But that will come in a future PR.

* fix snapshots

* Remove split out info from Regular Feature model

Currently, v3 cannot let us know if a feature has been partially split out.
This commit removes the split out info from the Regular Feature model.

See comment: web-platform-dx/web-features#3000 (comment)

This allows us to simplify this. We can revisit in v4.

* update snapshots

Author: jcscottiii

backend/pkg/httpserver/get_feature_test.go

@@ -66,7 +66,6 @@ func TestGetFeature(t *testing.T) {
 						),
 					},
 					DeveloperSignals: nil,
-					Evolution:        nil,
 					BrowserImplementations: &map[string]backend.BrowserImplementation{
 						"chrome": {
 							Status:  valuePtr(backend.Available),
@@ -176,15 +175,6 @@ func TestGetFeature(t *testing.T) {
 					DeveloperSignals: &backend.FeatureDeveloperSignals{
 						PositiveCount: 10,
 					},
-					Evolution: &backend.FeatureEvolutionInfo{
-						SplitOffInfo: &backend.FeatureEvolutionSplit{
-							Features: []backend.FeatureSplitInfo{
-								{
-									Id: "other",
-								},
-							},
-						},
-					},
 					BrowserImplementations: &map[string]backend.BrowserImplementation{
 						"chrome": {
 							Status:  valuePtr(backend.Available),
@@ -216,7 +206,6 @@ func TestGetFeature(t *testing.T) {
 							`"browser_implementations":` +
 							`{"chrome":{"date":"1999-01-01","status":"available","version":"100"}},` +
 							`"developer_signals":{"positive_count":10},` +
-							`"evolution":{"split_off_info":{"features":[{"id":"other"}]}},` +
 							`"feature_id":"feature1","name":"feature 1"}`,
 					),
 					CacheCfg: getDefaultCacheConfig(),
@@ -238,7 +227,6 @@ func TestGetFeature(t *testing.T) {
 		}
 	},
 	"developer_signals":{"positive_count":10},
-	"evolution":{"split_off_info":{"features":[{"id":"other"}]}},
 	"feature_id":"feature1",
 	"name":"feature 1"
 }`,
@@ -257,7 +245,6 @@ func TestGetFeature(t *testing.T) {
 							`"browser_implementations":` +
 							`{"chrome":{"date":"1999-01-01","status":"available","version":"100"}},` +
 							`"developer_signals":{"positive_count":10},` +
-							`"evolution":{"split_off_info":{"features":[{"id":"other"}]}},` +
 							`"feature_id":"feature1","name":"feature 1"}`,
 					),
 					Err: nil,
@@ -280,7 +267,6 @@ func TestGetFeature(t *testing.T) {
 		}
 	},
 	"developer_signals":{"positive_count":10},
-	"evolution":{"split_off_info":{"features":[{"id":"other"}]}},
 	"feature_id":"feature1",
 	"name":"feature 1"
 }`,

backend/pkg/httpserver/get_features_test.go

@@ -85,7 +85,6 @@ func TestListFeatures(t *testing.T) {
 								},
 							},
 							DeveloperSignals: nil,
-							Evolution:        nil,
 						},
 					},
 				},
@@ -256,15 +255,6 @@ func TestListFeatures(t *testing.T) {
 							DeveloperSignals: &backend.FeatureDeveloperSignals{
 								PositiveCount: 24,
 							},
-							Evolution: &backend.FeatureEvolutionInfo{
-								SplitOffInfo: &backend.FeatureEvolutionSplit{
-									Features: []backend.FeatureSplitInfo{
-										{
-											Id: "test-other",
-										},
-									},
-								},
-							},
 						},
 					},
 				},
@@ -287,7 +277,6 @@ func TestListFeatures(t *testing.T) {
 							`"browser_implementations":` +
 							`{"chrome":{"date":"1999-01-01","status":"available","version":"101"}},` +
 							`"developer_signals":{"positive_count":24},` +
-							`"evolution":{"split_off_info":{"features":[{"id":"test-other"}]}},` +
 							`"feature_id":"feature1","name":"feature 1"}],` +
 							`"metadata":{"next_page_token":"next-page-token","total":100}}`,
 					),
@@ -314,13 +303,6 @@ func TestListFeatures(t *testing.T) {
 			"developer_signals":{
 				"positive_count":24
 			},
-			"evolution":{
-				"split_off_info":{
-					"features":[
-						{"id":"test-other"}
-					]
-				}
-			},
 			"feature_id":"feature1",
 			"name":"feature 1"
 		}
@@ -351,7 +333,6 @@ func TestListFeatures(t *testing.T) {
 							`"browser_implementations":` +
 							`{"chrome":{"date":"1999-01-01","status":"available","version":"101"}},` +
 							`"developer_signals":{"positive_count":24},` +
-							`"evolution":{"split_off_info":{"features":[{"id":"test-other"}]}},` +
 							`"feature_id":"feature1","name":"feature 1"}],` +
 							`"metadata":{"next_page_token":"next-page-token","total":100}}`,
 					),
@@ -379,13 +360,6 @@ func TestListFeatures(t *testing.T) {
 			"developer_signals":{
 				"positive_count":24
 			},
-			"evolution":{
-				"split_off_info":{
-					"features":[
-						{"id":"test-other"}
-					]
-				}
-			},
 			"feature_id":"feature1",
 			"name":"feature 1"
 		}

e2e/tests/404.spec.ts-snapshots/not-found-error-page-similar-results-chromium-linux.png

@@ -21,8 +21,11 @@ test.beforeEach(async ({page}) => {
   await setupFakeNow(page);
 });
 
+const featureID = 'anchor-positioning';
+const featureName = 'Anchor Positioning';
+
 test('matches the screenshot', async ({page}) => {
-  await page.goto('http://localhost:5555/features/odit64');
+  await page.goto(`http://localhost:5555/features/${featureID}`);
 
   // Wait for the chart container to exist
   await page.waitForSelector('#feature-wpt-implementation-progress-0-complete');
@@ -35,7 +38,7 @@ test('matches the screenshot', async ({page}) => {
 });
 
 test('chart width resizes with window', async ({page}) => {
-  await page.goto('http://localhost:5555/features/odit64');
+  await page.goto(`http://localhost:5555/features/${featureID}`);
   await page.waitForSelector('#feature-wpt-implementation-progress-0-complete');
   await page.waitForTimeout(1000);
   const narrowWidth = 1000;
@@ -71,7 +74,7 @@ test('chart width resizes with window', async ({page}) => {
 test('mobile chart displays on click and matches screenshot', async ({
   page,
 }) => {
-  await page.goto('http://localhost:5555/features/odit64');
+  await page.goto(`http://localhost:5555/features/${featureID}`);
   await page.waitForSelector('#feature-wpt-implementation-progress-0-complete');
   const mobileTab = page.locator(
     'sl-tab#feature-wpt-implementation-progress-tab-mobile',
@@ -84,7 +87,7 @@ test('mobile chart displays on click and matches screenshot', async ({
 });
 
 test('date range changes are preserved in the URL', async ({page}) => {
-  await page.goto('http://localhost:5555/features/odit64');
+  await page.goto(`http://localhost:5555/features/${featureID}`);
   await page.waitForSelector('#feature-wpt-implementation-progress-0-complete');
 
   // Get the current default startDate and endDate from the selectors
@@ -131,7 +134,7 @@ test('date range changes are preserved in the URL', async ({page}) => {
   // TODO: Check that the chart has the right start date.
 
   // Click on the feature breadcrumb.
-  const featureCrumb = page.locator('.crumbs >> a:has-text("odit64")');
+  const featureCrumb = page.locator(`.crumbs >> a:has-text("${featureName}")`);
   await featureCrumb.click();
 
   // Check that the URL no longer contains the startDate or endDate.