Symfony 5 support, documentation

[tacman]

I'm having a hard time getting this bundle to work with Symfony 5.

First, services.yml needs to have quotes around the parameter:

services:
    # captcha type
    captcha.type:
        class: Gregwar\CaptchaBundle\Type\CaptchaType
        arguments: [ "@session", '%gregwar_captcha.config%' ]
        tags:
            - { name: form.type, alias: captcha }

But the issue I can't figure out is how to configure it. I've tried adding things to my services.yaml file, but no luck.

gregwar_captcha:
    width: 200
    height: 50
    length: 6

OR

gregwar_captcha: ~

How and where is the config defined for Symfony 5?

[Olaf1989]

@tacman you can create a configuration file in config/packages/ for example named gregwar_captcha.yaml.

For the configuration you should change the web_path option, because it is using an old Symfony default '%kernel.root_dir%/../web'.

gregwar_captcha:
  web_path: '%kernel.project_dir%/public'

The configuration is automatically loaded because the key matches the bundle in lower case and without the word 'bundle'. Read more: https://symfony.com/doc/current/bundles/configuration.html#processing-the-configs-array

[tacman]

Yep. Can you add a recipe to the Symfony flex repository for this. TreeBuilder doesn't work, I'll fix it and submit a PR.

…

On Sat, Dec 28, 2019 at 9:45 AM Olaf ***@***.***> wrote: @tacman <https://github.com/tacman> you can create a configuration file in *config/packages/* for example named *gregwar_captcha.yaml*. For the configuration you should change the *web_path* option, because it is using an old Symfony default *'%kernel.root_dir%/../web'*. gregwar_captcha: web_path: '%kernel.project_dir%/public' The configuration is automatically loaded because the key matches the bundle in lower case and without the word 'bundle'. Read more: https://symfony.com/doc/current/bundles/configuration.html#processing-the-configs-array — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#207?email_source=notifications&email_token=AAEXIQIZNZ7AZS3RNMH2ULDQ25Q7BA5CNFSM4J76OVG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHYLIRY#issuecomment-569422919>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEXIQMM2MIPYUDVYVN2EBTQ25Q7BANCNFSM4J76OVGQ> .

[tacman]

I see you've fixed it already. Can you bump a new version (2.1?). Personally, I'd suggest bumping to a Version 3 that only supports Symfony 4.4+. It'll make a few things easier (like documentation), and anyone using 3.4 can continue to use version 2 (or 2.1 if you bump what you have now).

…

On Sat, Dec 28, 2019 at 10:12 AM Tac Tacelosky ***@***.***> wrote: Yep. Can you add a recipe to the Symfony flex repository for this. TreeBuilder doesn't work, I'll fix it and submit a PR. On Sat, Dec 28, 2019 at 9:45 AM Olaf ***@***.***> wrote: > @tacman <https://github.com/tacman> you can create a configuration file > in *config/packages/* for example named *gregwar_captcha.yaml*. > > For the configuration you should change the *web_path* option, because > it is using an old Symfony default *'%kernel.root_dir%/../web'*. > > gregwar_captcha: > web_path: '%kernel.project_dir%/public' > > The configuration is automatically loaded because the key matches the > bundle in lower case and without the word 'bundle'. Read more: > https://symfony.com/doc/current/bundles/configuration.html#processing-the-configs-array > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#207?email_source=notifications&email_token=AAEXIQIZNZ7AZS3RNMH2ULDQ25Q7BA5CNFSM4J76OVG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHYLIRY#issuecomment-569422919>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAEXIQMM2MIPYUDVYVN2EBTQ25Q7BANCNFSM4J76OVGQ> > . >

[Olaf1989]

@tacman i'm a bit busy, but i have made some quick changes i will try to test this soon.

I will add the recipe to Symfony flex after there is a release version available, this is necessary https://github.com/symfony/recipes/blob/master/README.rst#creating-recipes

[Olaf1989]

@tacman pull-request added #208

[tacman]

Thanks! Sorry to ask such a dumb question, but how can I test this? composer require gregwar/captcha-bundle:@symfony-5 isn't working, but I know it's something like that.

…

On Thu, Jan 2, 2020 at 7:13 PM Olaf ***@***.***> wrote: @tacman <https://github.com/tacman> pull-request added #208 <#208> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#207?email_source=notifications&email_token=AAEXIQIA6AV2CAJEILN3EXTQ3Z7LRA5CNFSM4J76OVG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH74LHA#issuecomment-570410396>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEXIQK4YEXAJOYOKCHOGJTQ3Z7LRANCNFSM4J76OVGQ> .

[Olaf1989]

@tacman i have no idea if it is possible, let alone how.

It is possible to copy the contents of https://github.com/Olaf1989/CaptchaBundle/tree/symfony-5 and use it as a symbolic (vendor/gregwar/captcha-bundle) link in your local project to test it.

[Gregwar]

Merged @Olaf1989 and tagged v2.1.0

[Olaf1989]

@Gregwar thank you!

@tacman a Symfony recipe is not needed anymore because the default configuration is valid. Otherwise we should move all default values (from https://github.com/Gregwar/CaptchaBundle/blob/master/DependencyInjection/Configuration.php) to the recipe

[Gemorroj]

@Gregwar , @Olaf1989
have error with 2.1 release (symfony 4.4)
config:

gregwar_captcha:
    as_url: true
    reload: true

generated path:

/_gcbw/generate-captcha/_captcha_captcha?n=48d1ffaf109bcac63087aac19c90de83

error:

The controller for URI "/_gcbw/generate-captcha/_captcha_captcha" is not callable. Controller "Gregwar\CaptchaBundle\Controller\CaptchaController" has required constructor arguments and does not exist in the container. Did you forget to define the controller as a service?

[vipinbose]

@Gemorroj I am also facing this issue. Any solution for this

Found a solution: Version fixed at 2.0.7

[Olaf1989]

@Gemorroj i'm a bit too busy at the moment, but when i have time i will look into it.

[Gregwar]

@Gemorroj @Olaf1989 I don't really understand why this doesn't work with 4.4

Looks like adding the controller as service id fixes the issue, I pushed on master:
b8a129f

@vipinbose can you confirm ?

I'm ok with more explainations about that

[Gemorroj]

@Gregwar yes, this commit fixes the problem for me.

[Gregwar]

OK, I'm afraid I can't exactly explain the reason of this problem, but I can't investigate any further right now
I tagged v2.1.1 to be sure this fix is included for 4.4 users