From 2a767b5858619f08935c327c435151db5f9f4135 Mon Sep 17 00:00:00 2001
From: Clement G <contact@clemdesign.fr>
Date: Thu, 30 May 2019 21:55:07 +0200
Subject: [PATCH 01/10] Add converter and getResolution function

---
 Converter.php | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++
 Image.php     | 16 +++++++++++++++
 2 files changed, 70 insertions(+)
 create mode 100644 Converter.php

diff --git a/Converter.php b/Converter.php
new file mode 100644
index 0000000..f51dfd5
--- /dev/null
+++ b/Converter.php
@@ -0,0 +1,54 @@
+<?php
+/**
+ * Converter resource
+ * User: Clem
+ * Date: 30/05/2019
+ * Time: 21:46
+ */
+
+namespace Gregwar\Image;
+
+class Converter
+{
+
+  /**
+   * Convert Cm to Pixels using resolution in ppp
+   * @param float $cm
+   * @param int $resolution in PPP / DPI
+   * @return float
+   */
+  static function cmToPixels($cm, $resolution = 150) {
+    return $resolution * $cm / 2.54;
+  }
+
+  /**
+   * Convert Inch to Pixels using resolution in ppp
+   * @param float $inch
+   * @param int $resolution in PPP / DPI
+   * @return float
+   */
+  static function inchToPixel($inch, $resolution = 150) {
+    return $resolution * $inch;
+  }
+
+  /**
+   * Convert Pixels to Cm using resolution in ppp
+   * @param $pixels
+   * @param int $resolution in PPP / DPI
+   * @return float|int
+   */
+  static function pixelsToCm($pixels, $resolution = 150) {
+    return $pixels * 2.54 / $resolution;
+  }
+
+  /**
+   * Convert Pixels to Inch using resolution in ppp
+   * @param float $inch
+   * @param int $resolution in PPP / DPI
+   * @return float
+   */
+  static function pixelsToInch($pixels, $resolution = 150) {
+    return $pixels * $resolution;
+  }
+
+}
\ No newline at end of file
diff --git a/Image.php b/Image.php
index 3dd6ce6..613e81d 100644
--- a/Image.php
+++ b/Image.php
@@ -756,6 +756,22 @@ public function inline($type = 'jpg', $quality = 80)
         return 'data:image/'.$mime.';base64,'.base64_encode(file_get_contents($this->cacheFile($type, $quality, true)));
     }
 
+  /**
+   * Return the resolution of resource
+   * @param string $type
+   * @return array|bool|mixed
+   */
+    public function getResolution($type = 'both')
+    {
+      if(function_exists('imageresolution')) {
+        $res = imageresolution ($this->getAdapter()->getResource());
+        if(is_array($res)) {
+          return ($type === 'both') ? $res : (($type === 'Y') ? $res[1] : $res[0]);
+        }
+      }
+      return false;
+    }
+
     /**
      * Creates an instance, usefull for one-line chaining.
      */

From 8de01e4d917359880adc922a9ebf9c9236609655 Mon Sep 17 00:00:00 2001
From: Clement G <contact@clemdesign.fr>
Date: Fri, 31 May 2019 09:12:39 +0200
Subject: [PATCH 02/10] Add robustness

---
 Converter.php | 30 ++++++++++++++++++------------
 1 file changed, 18 insertions(+), 12 deletions(-)

diff --git a/Converter.php b/Converter.php
index f51dfd5..8839448 100644
--- a/Converter.php
+++ b/Converter.php
@@ -12,9 +12,9 @@ class Converter
 {
 
   /**
-   * Convert Cm to Pixels using resolution in ppp
+   * Convert Cm to Pixels using resolution in DPI
    * @param float $cm
-   * @param int $resolution in PPP / DPI
+   * @param int $resolution in DPI (PPP)
    * @return float
    */
   static function cmToPixels($cm, $resolution = 150) {
@@ -22,9 +22,9 @@ static function cmToPixels($cm, $resolution = 150) {
   }
 
   /**
-   * Convert Inch to Pixels using resolution in ppp
+   * Convert Inch to Pixels using resolution in DPI
    * @param float $inch
-   * @param int $resolution in PPP / DPI
+   * @param int $resolution in DPI (PPP)
    * @return float
    */
   static function inchToPixel($inch, $resolution = 150) {
@@ -32,22 +32,28 @@ static function inchToPixel($inch, $resolution = 150) {
   }
 
   /**
-   * Convert Pixels to Cm using resolution in ppp
-   * @param $pixels
-   * @param int $resolution in PPP / DPI
-   * @return float|int
+   * Convert Pixels to Cm using resolution in DPI
+   * @param int $pixels
+   * @param int $resolution in DPI (PPP)
+   * @return float|int|boolean
    */
   static function pixelsToCm($pixels, $resolution = 150) {
+    if($resolution === 0) {
+      return false;
+    }
     return $pixels * 2.54 / $resolution;
   }
 
   /**
-   * Convert Pixels to Inch using resolution in ppp
-   * @param float $inch
-   * @param int $resolution in PPP / DPI
-   * @return float
+   * Convert Pixels to Inch using resolution in DPI
+   * @param int $pixels
+   * @param int $resolution in DPI (PPP)
+   * @return float|boolean
    */
   static function pixelsToInch($pixels, $resolution = 150) {
+    if($resolution === 0) {
+      return false;
+    }
     return $pixels * $resolution;
   }
 

From f57d27efe097bca8cfccbc5b231051ae8a87bd49 Mon Sep 17 00:00:00 2001
From: Clement G <contact@clemdesign.fr>
Date: Fri, 31 May 2019 09:37:54 +0200
Subject: [PATCH 03/10] Add test for getResolution function Replace rm
 operation in tests

---
 composer.json        |   3 +
 tests/ImageTests.php | 970 ++++++++++++++++++++++---------------------
 2 files changed, 501 insertions(+), 472 deletions(-)

diff --git a/composer.json b/composer.json
index f213dec..5e3ddf4 100755
--- a/composer.json
+++ b/composer.json
@@ -28,5 +28,8 @@
         "psr-0": {
             "Gregwar\\Image": ""
         }
+    },
+    "scripts": {
+        "test": "simple-phpunit --bootstrap vendor/autoload.php tests/ImageTests"
     }
 }
diff --git a/tests/ImageTests.php b/tests/ImageTests.php
index 38fd0df..1cd7fb6 100755
--- a/tests/ImageTests.php
+++ b/tests/ImageTests.php
@@ -8,478 +8,504 @@
  */
 class ImageTests extends \PHPUnit\Framework\TestCase
 {
-    /**
-     * Testing the basic width & height.
-     */
-    public function testBasics()
-    {
-        $image = $this->open('monalisa.jpg');
-
-        $this->assertSame($image->width(), 771);
-        $this->assertSame($image->height(), 961);
+  /**
+   * Testing the basic width & height.
+   */
+  public function testBasics()
+  {
+    $image = $this->open('monalisa.jpg');
+
+    $this->assertSame($image->width(), 771);
+    $this->assertSame($image->height(), 961);
+  }
+
+  /**
+   * Testing the resize.
+   */
+  public function testResize()
+  {
+    $image = $this->open('monalisa.jpg');
+
+    $out = $this->output('monalisa_small.jpg');
+    $image
+      ->resize(300, 200)
+      ->save($out);
+
+    $this->assertTrue(file_exists($out));
+
+    $i = imagecreatefromjpeg($out);
+    $this->assertSame(300, imagesx($i));
+    $this->assertSame(200, imagesy($i));
+  }
+
+  /**
+   * Testing the resize %.
+   */
+  public function testResizePercent()
+  {
+    $image = $this->open('monalisa.jpg');
+
+    $out = $this->output('monalisa_small.jpg');
+    $image
+      ->resize('50%')
+      ->save($out);
+
+    $this->assertTrue(file_exists($out));
+
+    $i = imagecreatefromjpeg($out);
+    $this->assertSame(386, imagesx($i));
+    $this->assertSame(481, imagesy($i));
+  }
+
+  /**
+   * Testing to create an image, jpeg, gif and png.
+   */
+  public function testCreateImage()
+  {
+    $black = $this->output('black.jpg');
+
+    Image::create(150, 200)
+      ->fill('black')
+      ->save($black, 100);
+
+    $i = imagecreatefromjpeg($black);
+    $this->assertTrue(file_exists($black));
+    $this->assertSame(150, imagesx($i));
+    $this->assertSame(200, imagesy($i));
+
+    $j = imagecolorat($i, 40, 40);
+    $this->assertSame(0, $j);
+
+    $black = $this->output('black.png');
+    Image::create(150, 200)
+      ->fill('black')
+      ->save($black, 'png');
+
+    $i = imagecreatefrompng($black);
+    $this->assertTrue(file_exists($black));
+    $this->assertSame(150, imagesx($i));
+    $this->assertSame(200, imagesy($i));
+
+    $black = $this->output('black.gif');
+    Image::create(150, 200)
+      ->fill('black')
+      ->save($black, 'gif');
+
+    $i = imagecreatefromgif($black);
+    $this->assertTrue(file_exists($black));
+    $this->assertSame(150, imagesx($i));
+    $this->assertSame(200, imagesy($i));
+  }
+
+  /**
+   * Testing type guess.
+   */
+  public function testGuess()
+  {
+    $image = $this->open('monalisa.jpg');
+    $this->assertSame('jpeg', $image->guessType());
+    $image = $this->open('monalisa.png');
+    $this->assertSame('png', $image->guessType());
+    $image = $this->open('monalisa.gif');
+    $this->assertSame('gif', $image->guessType());
+  }
+
+  public function testDefaultCacheSystem()
+  {
+    $image = $this->open('monalisa.jpg');
+    $this->assertInstanceOf('Gregwar\Cache\Cache', $image->getCacheSystem());
+  }
+
+  public function testCustomCacheSystem()
+  {
+    $image = $this->open('monalisa.jpg');
+    $cache = $this->createMock('Gregwar\Cache\CacheInterface');
+    $image->setCacheSystem($cache);
+    $this->assertTrue($image->getCacheSystem() instanceof Gregwar\Cache\CacheInterface);
+  }
+
+  /**
+   * Testing that caching an image without operations will result
+   * in the original image when force cache is disabled.
+   */
+  public function testNoCache()
+  {
+    $monalisa = __DIR__ . '/files/monalisa.jpg';
+    $image = $this->open('monalisa.jpg')->setForceCache(false);
+    $this->assertSame($monalisa, $image->guess());
+    $image = $this->open('monalisa.jpg');
+    $this->assertNotSame($monalisa, $image->guess());
+    $image = $this->open('monalisa.jpg')->setForceCache(true);
+    $this->assertNotSame($monalisa, $image->guess());
+  }
+
+  public function testActualCache()
+  {
+    $output = $this->open('monalisa.jpg')
+      ->setCacheDir('/magic/path/to/cache/')
+      ->resize(100, 50)->negate()
+      ->guess();
+
+    $this->assertContains('/magic/path/to/cache', $output);
+    $file = str_replace('/magic/path/to', __DIR__ . '/output/', $output);
+    $this->assertTrue(file_exists($file));
+  }
+
+  public function testCacheData()
+  {
+    $output = $this->open('monalisa.jpg')
+      ->resize(300, 200)
+      ->cacheData();
+
+    $jpg = imagecreatefromstring($output);
+    $this->assertSame(300, imagesx($jpg));
+    $this->assertSame(200, imagesy($jpg));
+  }
+
+  /**
+   * Testing using cache.
+   */
+  public function testCache()
+  {
+    $output = $this->open('monalisa.jpg')
+      ->resize(100, 50)->negate()
+      ->guess();
+
+    $this->assertTrue(file_exists($output));
+    $i = imagecreatefromjpeg($output);
+    $this->assertSame(100, imagesx($i));
+    $this->assertSame(50, imagesy($i));
+
+    $output2 = $this->open('monalisa.jpg')
+      ->resize(100, 50)->negate()
+      ->guess();
+
+    $this->assertSame($output, $output2);
+
+    $output3 = $this->open('monalisa.jpg')
+      ->resize(100, 50)->negate()
+      ->png();
+    $this->assertTrue(file_exists($output));
+    $i = imagecreatefrompng($output3);
+    $this->assertSame(100, imagesx($i));
+    $this->assertSame(50, imagesy($i));
+
+    $output4 = $this->open('monalisa.jpg')
+      ->resize(100, 50)->negate()
+      ->gif();
+    $this->assertTrue(file_exists($output));
+    $i = imagecreatefromgif($output4);
+    $this->assertSame(100, imagesx($i));
+    $this->assertSame(50, imagesy($i));
+  }
+
+  /**
+   * Testing Gaussian blur filter.
+   */
+  public function testGaussianBlur()
+  {
+    $image = $this->open('monalisa.jpg')
+      ->gaussianBlur();
+    $secondImage = $this->open('monalisa.jpg')
+      ->gaussianBlur(5);
+
+    $this->assertTrue(file_exists($image));
+    $this->assertTrue(file_exists($secondImage));
+  }
+
+  /**
+   * Testing creating image from data.
+   */
+  public function testData()
+  {
+    $data = file_get_contents(__DIR__ . '/files/monalisa.jpg');
+
+    $output = $this->output('mona.jpg');
+    $image = Image::fromData($data);
+    $image->save($output);
+
+    $this->assertTrue(file_exists($output));
+    $i = imagecreatefromjpeg($output);
+    $this->assertSame(771, imagesx($i));
+    $this->assertSame(961, imagesy($i));
+  }
+
+  /**
+   * Opening an image.
+   */
+  protected function open($file)
+  {
+    $image = Image::open(__DIR__ . '/files/' . $file);
+    $image->setCacheDir(__DIR__ . '/output/cache/');
+    $image->setActualCacheDir(__DIR__ . '/output/cache/');
+
+    return $image;
+  }
+
+  /**
+   * Testing transparent image.
+   */
+  public function testTransparent()
+  {
+    $gif = $this->output('transparent.gif');
+    $i = Image::create(200, 100)
+      ->fill('transparent')
+      ->save($gif, 'gif');
+
+    $this->assertTrue(file_exists($gif));
+    $img = imagecreatefromgif($gif);
+    $this->assertSame(200, imagesx($img));
+    $this->assertSame(100, imagesy($img));
+    $index = imagecolorat($img, 2, 2);
+    $color = imagecolorsforindex($img, $index);
+    $this->assertSame(127, $color['alpha']);
+  }
+
+  public function testNonExistingFile()
+  {
+    $jpg = $this->output('a.jpg');
+    $img = $this->open('non_existing_file.jpg')
+      ->negate();
+    $error = $img->save($jpg);
+
+    $this->assertTrue(file_exists($error));
+  }
+
+  /**
+   * * @expectedException              \UnexpectedValueException
+   */
+  public function testNonExistingFileNoFallback()
+  {
+    Image::open('non_existing_file.jpg')
+      ->useFallback(false)
+      ->save($this->output('a.jpg'));
+  }
+
+  /**
+   * Test that image::save returns the file name.
+   */
+  public function testSaveReturn()
+  {
+    $red = $this->output('red.jpg');
+    $result = Image::create(10, 10)
+      ->fill('red')
+      ->save($red);
+
+    $this->assertSame($red, $result);
+  }
+
+  /**
+   * Testing merge.
+   */
+  public function testMerge()
+  {
+    $out = $this->output('merge.jpg');
+    Image::create(100, 100)
+      ->fill('red')
+      ->merge(Image::create(50, 50)
+        ->fill('black')
+      )
+      ->save($out);
+
+    // Merge file exists
+    $this->assertTrue(file_exists($out));
+
+    // Test that the upper left zone contain a black pixel, and the lower
+    // down contains a red one
+    $img = imagecreatefromjpeg($out);
+    $this->assertColorEquals('black', imagecolorat($img, 5, 12));
+    $this->assertColorEquals('red', imagecolorat($img, 55, 62));
+  }
+
+  /**
+   * Test that dependencies are well generated.
+   */
+  public function testDependencies()
+  {
+    $this->assertSame(array(), Image::create(100, 100)
+      ->getDependencies());
+    $this->assertSame(array(), Image::create(100, 100)
+      ->merge(Image::create(100, 50))
+      ->getDependencies());
+
+    $this->assertSame(array('toto.jpg'), Image::open('toto.jpg')
+      ->merge(Image::create(100, 50))
+      ->getDependencies());
+
+    $this->assertSame(array('toto.jpg', 'titi.jpg'), Image::open('toto.jpg')
+      ->merge(Image::open('titi.jpg'))
+      ->getDependencies());
+
+    $this->assertSame(array('toto.jpg', 'titi.jpg', 'tata.jpg'), Image::open('toto.jpg')
+      ->merge(Image::open('titi.jpg')
+        ->merge(Image::open('tata.jpg')))
+      ->getDependencies());
+  }
+
+  /**
+   * Test that pretty name (for referencing) is well respected.
+   */
+  public function testPrettyName()
+  {
+    $output = $this->open('monalisa.jpg')
+      ->resize(100, 50)->negate()
+      ->setPrettyName('davinci', false)
+      ->guess();
+
+    $this->assertContains('davinci', $output);
+
+    $output2 = $this->open('monalisa.jpg')
+      ->resize(100, 55)->negate()
+      ->setPrettyName('davinci', false)
+      ->guess();
+
+    $this->assertSame($output, $output2);
+
+    $prefix1 = $this->open('monalisa.jpg')
+      ->resize(100, 50)->negate()
+      ->setPrettyName('davinci')
+      ->guess();
+    $prefix2 = $this->open('monalisa.jpg')
+      ->resize(100, 55)->negate()
+      ->setPrettyName('davinci')
+      ->guess();
+
+    $this->assertContains('davinci', $prefix1);
+    $this->assertContains('davinci', $prefix2);
+    $this->assertNotSame($prefix1, $prefix2);
+
+    $transliterator = '\Behat\Transliterator\Transliterator';
+
+    if (class_exists($transliterator)) {
+      $nonLatinName1 = 'ダヴィンチ';
+      $nonLatinOutput1 = $this->open('monalisa.jpg')
+        ->resize(100, 50)->negate()
+        ->setPrettyName($nonLatinName1, false)
+        ->guess();
+
+      $this->assertContains(
+        $transliterator::urlize($transliterator::transliterate($nonLatinName1)),
+        $nonLatinOutput1
+      );
+
+      $nonLatinName2 = 'давинчи';
+      $nonLatinOutput2 = $this->open('monalisa.jpg')
+        ->resize(100, 55)->negate()
+        ->setPrettyName($nonLatinName2)
+        ->guess();
+
+      $this->assertContains(
+        $transliterator::urlize($transliterator::transliterate($nonLatinName2)),
+        $nonLatinOutput2
+      );
     }
-
-    /**
-     * Testing the resize.
-     */
-    public function testResize()
-    {
-        $image = $this->open('monalisa.jpg');
-
-        $out = $this->output('monalisa_small.jpg');
-        $image
-            ->resize(300, 200)
-            ->save($out)
-            ;
-
-        $this->assertTrue(file_exists($out));
-
-        $i = imagecreatefromjpeg($out);
-        $this->assertSame(300, imagesx($i));
-        $this->assertSame(200, imagesy($i));
-    }
-
-    /**
-     * Testing the resize %.
-     */
-    public function testResizePercent()
-    {
-        $image = $this->open('monalisa.jpg');
-
-        $out = $this->output('monalisa_small.jpg');
-        $image
-            ->resize('50%')
-            ->save($out)
-            ;
-
-        $this->assertTrue(file_exists($out));
-
-        $i = imagecreatefromjpeg($out);
-        $this->assertSame(386, imagesx($i));
-        $this->assertSame(481, imagesy($i));
-    }
-
-    /**
-     * Testing to create an image, jpeg, gif and png.
-     */
-    public function testCreateImage()
-    {
-        $black = $this->output('black.jpg');
-
-        Image::create(150, 200)
-            ->fill('black')
-            ->save($black, 100);
-
-        $i = imagecreatefromjpeg($black);
-        $this->assertTrue(file_exists($black));
-        $this->assertSame(150, imagesx($i));
-        $this->assertSame(200, imagesy($i));
-
-        $j = imagecolorat($i, 40, 40);
-        $this->assertSame(0, $j);
-
-        $black = $this->output('black.png');
-        Image::create(150, 200)
-            ->fill('black')
-            ->save($black, 'png');
-
-        $i = imagecreatefrompng($black);
-        $this->assertTrue(file_exists($black));
-        $this->assertSame(150, imagesx($i));
-        $this->assertSame(200, imagesy($i));
-
-        $black = $this->output('black.gif');
-        Image::create(150, 200)
-            ->fill('black')
-            ->save($black, 'gif');
-
-        $i = imagecreatefromgif($black);
-        $this->assertTrue(file_exists($black));
-        $this->assertSame(150, imagesx($i));
-        $this->assertSame(200, imagesy($i));
-    }
-
-    /**
-     * Testing type guess.
-     */
-    public function testGuess()
-    {
-        $image = $this->open('monalisa.jpg');
-        $this->assertSame('jpeg', $image->guessType());
-        $image = $this->open('monalisa.png');
-        $this->assertSame('png', $image->guessType());
-        $image = $this->open('monalisa.gif');
-        $this->assertSame('gif', $image->guessType());
-    }
-
-    public function testDefaultCacheSystem()
-    {
-        $image = $this->open('monalisa.jpg');
-        $this->assertInstanceOf('Gregwar\Cache\Cache', $image->getCacheSystem());
-    }
-
-    public function testCustomCacheSystem()
-    {
-        $image = $this->open('monalisa.jpg');
-        $cache = $this->createMock('Gregwar\Cache\CacheInterface');
-        $image->setCacheSystem($cache);
-        $this->assertTrue($image->getCacheSystem() instanceof Gregwar\Cache\CacheInterface);
-    }
-
-    /**
-     * Testing that caching an image without operations will result
-     * in the original image when force cache is disabled.
-     */
-    public function testNoCache()
-    {
-        $monalisa = __DIR__.'/files/monalisa.jpg';
-        $image = $this->open('monalisa.jpg')->setForceCache(false);
-        $this->assertSame($monalisa, $image->guess());
-        $image = $this->open('monalisa.jpg');
-        $this->assertNotSame($monalisa, $image->guess());
-        $image = $this->open('monalisa.jpg')->setForceCache(true);
-        $this->assertNotSame($monalisa, $image->guess());
-    }
-
-    public function testActualCache()
-    {
-        $output = $this->open('monalisa.jpg')
-            ->setCacheDir('/magic/path/to/cache/')
-            ->resize(100, 50)->negate()
-            ->guess();
-
-        $this->assertContains('/magic/path/to/cache', $output);
-        $file = str_replace('/magic/path/to', __DIR__.'/output/', $output);
-        $this->assertTrue(file_exists($file));
-    }
-
-    public function testCacheData()
-    {
-        $output = $this->open('monalisa.jpg')
-            ->resize(300, 200)
-            ->cacheData();
-
-        $jpg = imagecreatefromstring($output);
-        $this->assertSame(300, imagesx($jpg));
-        $this->assertSame(200, imagesy($jpg));
-    }
-
-    /**
-     * Testing using cache.
-     */
-    public function testCache()
-    {
-        $output = $this->open('monalisa.jpg')
-            ->resize(100, 50)->negate()
-            ->guess();
-
-        $this->assertTrue(file_exists($output));
-        $i = imagecreatefromjpeg($output);
-        $this->assertSame(100, imagesx($i));
-        $this->assertSame(50, imagesy($i));
-
-        $output2 = $this->open('monalisa.jpg')
-            ->resize(100, 50)->negate()
-            ->guess();
-
-        $this->assertSame($output, $output2);
-
-        $output3 = $this->open('monalisa.jpg')
-            ->resize(100, 50)->negate()
-            ->png();
-        $this->assertTrue(file_exists($output));
-        $i = imagecreatefrompng($output3);
-        $this->assertSame(100, imagesx($i));
-        $this->assertSame(50, imagesy($i));
-
-        $output4 = $this->open('monalisa.jpg')
-            ->resize(100, 50)->negate()
-            ->gif();
-        $this->assertTrue(file_exists($output));
-        $i = imagecreatefromgif($output4);
-        $this->assertSame(100, imagesx($i));
-        $this->assertSame(50, imagesy($i));
-    }
-
-    /**
-     * Testing Gaussian blur filter.
-     */
-    public function testGaussianBlur()
-    {
-        $image = $this->open('monalisa.jpg')
-            ->gaussianBlur();
-        $secondImage = $this->open('monalisa.jpg')
-            ->gaussianBlur(5);
-
-        $this->assertTrue(file_exists($image));
-        $this->assertTrue(file_exists($secondImage));
-    }
-
-    /**
-     * Testing creating image from data.
-     */
-    public function testData()
-    {
-        $data = file_get_contents(__DIR__.'/files/monalisa.jpg');
-
-        $output = $this->output('mona.jpg');
-        $image = Image::fromData($data);
-        $image->save($output);
-
-        $this->assertTrue(file_exists($output));
-        $i = imagecreatefromjpeg($output);
-        $this->assertSame(771, imagesx($i));
-        $this->assertSame(961, imagesy($i));
-    }
-
-    /**
-     * Opening an image.
-     */
-    protected function open($file)
-    {
-        $image = Image::open(__DIR__.'/files/'.$file);
-        $image->setCacheDir(__DIR__.'/output/cache/');
-        $image->setActualCacheDir(__DIR__.'/output/cache/');
-
-        return $image;
-    }
-
-    /**
-     * Testing transparent image.
-     */
-    public function testTransparent()
-    {
-        $gif = $this->output('transparent.gif');
-        $i = Image::create(200, 100)
-            ->fill('transparent')
-            ->save($gif, 'gif');
-
-        $this->assertTrue(file_exists($gif));
-        $img = imagecreatefromgif($gif);
-        $this->assertSame(200, imagesx($img));
-        $this->assertSame(100, imagesy($img));
-        $index = imagecolorat($img, 2, 2);
-        $color = imagecolorsforindex($img, $index);
-        $this->assertSame(127, $color['alpha']);
-    }
-
-    public function testNonExistingFile()
-    {
-        $jpg = $this->output('a.jpg');
-        $img = $this->open('non_existing_file.jpg')
-            ->negate();
-        $error = $img->save($jpg);
-
-        $this->assertTrue(file_exists($error));
-    }
-
-    /**
-     * * @expectedException              \UnexpectedValueException
-     */
-    public function testNonExistingFileNoFallback()
-    {
-        Image::open('non_existing_file.jpg')
-            ->useFallback(false)
-            ->save($this->output('a.jpg'));
-    }
-
-    /**
-     * Test that image::save returns the file name.
-     */
-    public function testSaveReturn()
-    {
-        $red = $this->output('red.jpg');
-        $result = Image::create(10, 10)
-            ->fill('red')
-            ->save($red);
-
-        $this->assertSame($red, $result);
-    }
-
-    /**
-     * Testing merge.
-     */
-    public function testMerge()
-    {
-        $out = $this->output('merge.jpg');
-        Image::create(100, 100)
-            ->fill('red')
-            ->merge(Image::create(50, 50)
-                ->fill('black')
-            )
-            ->save($out);
-
-        // Merge file exists
-        $this->assertTrue(file_exists($out));
-
-        // Test that the upper left zone contain a black pixel, and the lower
-        // down contains a red one
-        $img = imagecreatefromjpeg($out);
-        $this->assertColorEquals('black', imagecolorat($img, 5, 12));
-        $this->assertColorEquals('red', imagecolorat($img, 55, 62));
-    }
-
-    /**
-     * Test that dependencies are well generated.
-     */
-    public function testDependencies()
-    {
-        $this->assertSame(array(), Image::create(100, 100)
-            ->getDependencies());
-        $this->assertSame(array(), Image::create(100, 100)
-            ->merge(Image::create(100, 50))
-            ->getDependencies());
-
-        $this->assertSame(array('toto.jpg'), Image::open('toto.jpg')
-            ->merge(Image::create(100, 50))
-            ->getDependencies());
-
-        $this->assertSame(array('toto.jpg', 'titi.jpg'), Image::open('toto.jpg')
-            ->merge(Image::open('titi.jpg'))
-            ->getDependencies());
-
-        $this->assertSame(array('toto.jpg', 'titi.jpg', 'tata.jpg'), Image::open('toto.jpg')
-            ->merge(Image::open('titi.jpg')
-                    ->merge(Image::open('tata.jpg')))
-            ->getDependencies());
-    }
-
-    /**
-     * Test that pretty name (for referencing) is well respected.
-     */
-    public function testPrettyName()
-    {
-        $output = $this->open('monalisa.jpg')
-            ->resize(100, 50)->negate()
-            ->setPrettyName('davinci', false)
-            ->guess();
-
-        $this->assertContains('davinci', $output);
-
-        $output2 = $this->open('monalisa.jpg')
-            ->resize(100, 55)->negate()
-            ->setPrettyName('davinci', false)
-            ->guess();
-
-        $this->assertSame($output, $output2);
-
-        $prefix1 = $this->open('monalisa.jpg')
-            ->resize(100, 50)->negate()
-            ->setPrettyName('davinci')
-            ->guess();
-        $prefix2 = $this->open('monalisa.jpg')
-            ->resize(100, 55)->negate()
-            ->setPrettyName('davinci')
-            ->guess();
-
-        $this->assertContains('davinci', $prefix1);
-        $this->assertContains('davinci', $prefix2);
-        $this->assertNotSame($prefix1, $prefix2);
-
-        $transliterator = '\Behat\Transliterator\Transliterator';
-
-        if (class_exists($transliterator)) {
-            $nonLatinName1 = 'ダヴィンチ';
-            $nonLatinOutput1 = $this->open('monalisa.jpg')
-                ->resize(100, 50)->negate()
-                ->setPrettyName($nonLatinName1, false)
-                ->guess();
-
-            $this->assertContains(
-                $transliterator::urlize($transliterator::transliterate($nonLatinName1)),
-                $nonLatinOutput1
-            );
-
-            $nonLatinName2 = 'давинчи';
-            $nonLatinOutput2 = $this->open('monalisa.jpg')
-                ->resize(100, 55)->negate()
-                ->setPrettyName($nonLatinName2)
-                ->guess();
-
-            $this->assertContains(
-                $transliterator::urlize($transliterator::transliterate($nonLatinName2)),
-                $nonLatinOutput2
-            );
-        }
-    }
-
-    /**
-     * Testing inlining.
-     */
-    public function testInline()
-    {
-        $output = $this->open('monalisa.jpg')
-            ->resize(20, 20)
-            ->inline();
-
-        $this->assertSame(0, strpos($output, 'data:image/jpeg;base64,'));
-
-        $data = base64_decode(substr($output, 23));
-        $image = imagecreatefromstring($data);
-
-        $this->assertSame(20, imagesx($image));
-        $this->assertSame(20, imagesy($image));
-    }
-
-    /**
-     * Testing that width() can be called after cache
-     */
-    public function testWidthPostCache()
-    {
-        $this->open('monalisa.jpg')
-            ->resize(100, 50)->negate()
-            ->png();
-        
-        $dummy2 = $this->open('monalisa.jpg')
-            ->resize(100, 50)->negate();
-        $png = $dummy2->png();
-
-        $i = imagecreatefrompng($png);
-        $this->assertEquals(imagesx($i), $dummy2->width());
-    }
-
-    /**
-     * Asaserting that two colors are equals
-     * (JPG compression is not preserving colors for instance, so we
-     * need a non-strict way to compare it).
-     */
-    protected function assertColorEquals($c1, $c2, $delta = 8)
-    {
-        $c1 = ImageColor::parse($c1);
-        $c2 = ImageColor::parse($c2);
-        list($r1, $g1, $b1) = $this->toRGB($c1);
-        list($r2, $g2, $b2) = $this->toRGB($c2);
-
-        $this->assertLessThan($delta, abs($r1 - $r2));
-        $this->assertLessThan($delta, abs($g1 - $g2));
-        $this->assertLessThan($delta, abs($b1 - $b2));
-    }
-
-    protected function toRGB($color)
-    {
-        $b = $color & 0xff;
-        $g = ($color >> 8) & 0xff;
-        $r = ($color >> 16) & 0xff;
-
-        return array($r, $g, $b);
-    }
-
-    /**
-     * Outputing an image to a file.
-     */
-    protected function output($file)
-    {
-        return __DIR__.'/output/'.$file;
-    }
-
-    /**
-     * Reinitialize the output dir.
-     */
-    public function setUp()
-    {
-        $dir = $this->output('');
-        `rm -rf $dir`;
-        mkdir($dir);
-        mkdir($this->output('cache'));
+  }
+
+  /**
+   * Testing inlining.
+   */
+  public function testInline()
+  {
+    $output = $this->open('monalisa.jpg')
+      ->resize(20, 20)
+      ->inline();
+
+    $this->assertSame(0, strpos($output, 'data:image/jpeg;base64,'));
+
+    $data = base64_decode(substr($output, 23));
+    $image = imagecreatefromstring($data);
+
+    $this->assertSame(20, imagesx($image));
+    $this->assertSame(20, imagesy($image));
+  }
+
+  /**
+   * Testing that width() can be called after cache
+   */
+  public function testWidthPostCache()
+  {
+    $this->open('monalisa.jpg')
+      ->resize(100, 50)->negate()
+      ->png();
+
+    $dummy2 = $this->open('monalisa.jpg')
+      ->resize(100, 50)->negate();
+    $png = $dummy2->png();
+
+    $i = imagecreatefrompng($png);
+    $this->assertEquals(imagesx($i), $dummy2->width());
+  }
+
+  /**
+   * Test the function getResolution
+   */
+  public function testResolution()
+  {
+    $image = $this->open('monalisa.jpg');
+
+    $image->init();
+
+    $this->assertEquals(array(96, 96), $image->getResolution());
+
+  }
+
+  /**
+   * Asaserting that two colors are equals
+   * (JPG compression is not preserving colors for instance, so we
+   * need a non-strict way to compare it).
+   */
+  protected function assertColorEquals($c1, $c2, $delta = 8)
+  {
+    $c1 = ImageColor::parse($c1);
+    $c2 = ImageColor::parse($c2);
+    list($r1, $g1, $b1) = $this->toRGB($c1);
+    list($r2, $g2, $b2) = $this->toRGB($c2);
+
+    $this->assertLessThan($delta, abs($r1 - $r2));
+    $this->assertLessThan($delta, abs($g1 - $g2));
+    $this->assertLessThan($delta, abs($b1 - $b2));
+  }
+
+  protected function toRGB($color)
+  {
+    $b = $color & 0xff;
+    $g = ($color >> 8) & 0xff;
+    $r = ($color >> 16) & 0xff;
+
+    return array($r, $g, $b);
+  }
+
+  /**
+   * Outputing an image to a file.
+   */
+  protected function output($file)
+  {
+    return __DIR__ . '/output/' . $file;
+  }
+
+  /**
+   * Reinitialize the output dir.
+   */
+  public function setUp()
+  {
+    $dir = $this->output('');
+   // `rm -rf $dir`;    // This line is replaced by follow because doesn't work on Windows system
+    ImageTests::delTree($dir);
+    mkdir($dir);
+    mkdir($this->output('cache'));
+  }
+
+  /**
+   * Del recursively a tree folder
+   * @param $dir
+   * @return bool
+   */
+  public static function delTree($dir)
+  {
+    $files = array_diff(scandir($dir), array('.', '..'));
+    foreach ($files as $file) {
+      (is_dir("$dir/$file")) ? ImageTests::delTree("$dir/$file") : unlink("$dir/$file");
     }
+    return rmdir($dir);
+  }
 }

From d3da33488a0d63f61c7f29fbfba03a06f54e3bf3 Mon Sep 17 00:00:00 2001
From: Clement G <contact@clemdesign.fr>
Date: Fri, 31 May 2019 09:39:26 +0200
Subject: [PATCH 04/10] Improve test

---
 tests/ImageTests.php | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/tests/ImageTests.php b/tests/ImageTests.php
index 1cd7fb6..9284dce 100755
--- a/tests/ImageTests.php
+++ b/tests/ImageTests.php
@@ -445,8 +445,18 @@ public function testResolution()
 
     $image->init();
 
+    // Normal call
     $this->assertEquals(array(96, 96), $image->getResolution());
 
+    // Normal explicit call
+    $this->assertEquals(array(96, 96), $image->getResolution('both'));
+
+    // Call to get X resolution
+    $this->assertEquals(96, $image->getResolution('X'));
+
+    // Call to get Y resolution
+    $this->assertEquals(96, $image->getResolution('Y'));
+
   }
 
   /**

From 7ee43bc52d6529a941ca6ad87cf98590ec1c4726 Mon Sep 17 00:00:00 2001
From: Clement G <contact@clemdesign.fr>
Date: Fri, 31 May 2019 09:43:55 +0200
Subject: [PATCH 05/10] Set default resolution to 96 DPI

---
 Converter.php | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Converter.php b/Converter.php
index 8839448..b58269e 100644
--- a/Converter.php
+++ b/Converter.php
@@ -17,7 +17,7 @@ class Converter
    * @param int $resolution in DPI (PPP)
    * @return float
    */
-  static function cmToPixels($cm, $resolution = 150) {
+  static function cmToPixels($cm, $resolution = 96) {
     return $resolution * $cm / 2.54;
   }
 
@@ -27,7 +27,7 @@ static function cmToPixels($cm, $resolution = 150) {
    * @param int $resolution in DPI (PPP)
    * @return float
    */
-  static function inchToPixel($inch, $resolution = 150) {
+  static function inchToPixel($inch, $resolution = 96) {
     return $resolution * $inch;
   }
 
@@ -37,7 +37,7 @@ static function inchToPixel($inch, $resolution = 150) {
    * @param int $resolution in DPI (PPP)
    * @return float|int|boolean
    */
-  static function pixelsToCm($pixels, $resolution = 150) {
+  static function pixelsToCm($pixels, $resolution = 96) {
     if($resolution === 0) {
       return false;
     }
@@ -50,7 +50,7 @@ static function pixelsToCm($pixels, $resolution = 150) {
    * @param int $resolution in DPI (PPP)
    * @return float|boolean
    */
-  static function pixelsToInch($pixels, $resolution = 150) {
+  static function pixelsToInch($pixels, $resolution = 96) {
     if($resolution === 0) {
       return false;
     }

From 9187e3ea0a2bfc245a730967031094b9c6d6ef30 Mon Sep 17 00:00:00 2001
From: Clement G <contact@clemdesign.fr>
Date: Fri, 31 May 2019 09:55:46 +0200
Subject: [PATCH 06/10] Update function

---
 Converter.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Converter.php b/Converter.php
index b58269e..6d3af3e 100644
--- a/Converter.php
+++ b/Converter.php
@@ -27,7 +27,7 @@ static function cmToPixels($cm, $resolution = 96) {
    * @param int $resolution in DPI (PPP)
    * @return float
    */
-  static function inchToPixel($inch, $resolution = 96) {
+  static function inchToPixels($inch, $resolution = 96) {
     return $resolution * $inch;
   }
 

From 667a7696823b76bd2ee03ec201b9cab586c8839f Mon Sep 17 00:00:00 2001
From: Clement G <contact@clemdesign.fr>
Date: Fri, 31 May 2019 10:02:37 +0200
Subject: [PATCH 07/10] Fix issue

---
 Converter.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Converter.php b/Converter.php
index 6d3af3e..93c9be7 100644
--- a/Converter.php
+++ b/Converter.php
@@ -54,7 +54,7 @@ static function pixelsToInch($pixels, $resolution = 96) {
     if($resolution === 0) {
       return false;
     }
-    return $pixels * $resolution;
+    return $pixels / $resolution;
   }
 
 }
\ No newline at end of file

From 332efed4cdd237feafce9fde6064841303f02ad0 Mon Sep 17 00:00:00 2001
From: Clement G <contact@clemdesign.fr>
Date: Fri, 31 May 2019 10:09:04 +0200
Subject: [PATCH 08/10] Add tests for Converter

---
 composer.json            |  2 +-
 phpunit.xml.dist         |  3 ++
 tests/ConverterTests.php | 66 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 70 insertions(+), 1 deletion(-)
 create mode 100644 tests/ConverterTests.php

diff --git a/composer.json b/composer.json
index 5e3ddf4..34bdf61 100755
--- a/composer.json
+++ b/composer.json
@@ -30,6 +30,6 @@
         }
     },
     "scripts": {
-        "test": "simple-phpunit --bootstrap vendor/autoload.php tests/ImageTests"
+        "test": "simple-phpunit --bootstrap vendor/autoload.php"
     }
 }
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
index c66a5af..6725405 100644
--- a/phpunit.xml.dist
+++ b/phpunit.xml.dist
@@ -15,6 +15,9 @@
         <testsuite name="Image testing">
             <file>./tests/ImageTests.php</file>
         </testsuite>
+        <testsuite name="Converter testing">
+            <file>./tests/ConverterTests.php</file>
+        </testsuite>
     </testsuites>
 
 </phpunit>
diff --git a/tests/ConverterTests.php b/tests/ConverterTests.php
new file mode 100644
index 0000000..0e04dff
--- /dev/null
+++ b/tests/ConverterTests.php
@@ -0,0 +1,66 @@
+<?php
+/**
+ * Tests for Converter class
+ * User: Clem
+ * Date: 31/05/2019
+ * Time: 09:39
+ */
+
+use \Gregwar\Image\Converter;
+
+class ConverterTests extends \PHPUnit\Framework\TestCase
+{
+  public function testCmToPixels()
+  {
+    // Basic convertion
+    $this->assertEquals(37.795275591, Converter::cmToPixels(1), '', 0.001);
+
+    // 6cm convertion
+    $this->assertEquals(226.771653543, Converter::cmToPixels(6), '', 0.001);
+
+    // 6cm convertion with 300 dpi
+    $this->assertEquals(708.6614173, Converter::cmToPixels(6, 300), '', 0.001);
+  }
+
+  public function testInchToPixels()
+  {
+    // Basic convertion
+    $this->assertEquals(96, Converter::inchToPixels(1));
+
+    // 6inch convertion
+    $this->assertEquals(576, Converter::inchToPixels(6));
+
+    // 6inch convertion with 300 dpi
+    $this->assertEquals(1800, Converter::inchToPixels(6, 300));
+  }
+
+  public function testPixelsToCm()
+  {
+    // Basic convertion
+    $this->assertEquals(0.026458333, Converter::pixelsToCm(1), '', 0.001);
+
+    // 960 pixels convertion
+    $this->assertEquals(25.4, Converter::pixelsToCm(960), '', 0.001);
+
+    // 960 pixels with 300 dpi
+    $this->assertEquals(8.128, Converter::pixelsToCm(960, 300), '', 0.001);
+
+    // 960 pixels with 0 dpi
+    $this->assertEquals(false, Converter::pixelsToCm(960, 0));
+  }
+
+  public function testPixelsToInch()
+  {
+    // Basic convertion
+    $this->assertEquals(0.010416667, Converter::pixelsToInch(1), '', 0.001);
+
+    // 960 pixels convertion
+    $this->assertEquals(10, Converter::pixelsToInch(960), '', 0.001);
+
+    // 960 pixels with 300 dpi
+    $this->assertEquals(3.2, Converter::pixelsToInch(960, 300), '', 0.001);
+
+    // 960 pixels with 0 dpi
+    $this->assertEquals(false, Converter::pixelsToInch(960, 0));
+  }
+}
\ No newline at end of file

From 2b55a55a19331b38e15d99f59cc4d679b7ddb6d3 Mon Sep 17 00:00:00 2001
From: Clement G <contact@clemdesign.fr>
Date: Fri, 31 May 2019 11:01:23 +0200
Subject: [PATCH 09/10] Improve robustness

---
 Converter.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Converter.php b/Converter.php
index 93c9be7..daed5b8 100644
--- a/Converter.php
+++ b/Converter.php
@@ -38,7 +38,7 @@ static function inchToPixels($inch, $resolution = 96) {
    * @return float|int|boolean
    */
   static function pixelsToCm($pixels, $resolution = 96) {
-    if($resolution === 0) {
+    if($resolution == 0) {
       return false;
     }
     return $pixels * 2.54 / $resolution;
@@ -51,7 +51,7 @@ static function pixelsToCm($pixels, $resolution = 96) {
    * @return float|boolean
    */
   static function pixelsToInch($pixels, $resolution = 96) {
-    if($resolution === 0) {
+    if($resolution == 0) {
       return false;
     }
     return $pixels / $resolution;

From b837ff1fb585055b1c77ef2405c204a46802d4b8 Mon Sep 17 00:00:00 2001
From: Clement G <contact@clemdesign.fr>
Date: Fri, 31 May 2019 11:10:17 +0200
Subject: [PATCH 10/10] Update README.md

---
 README.md | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/README.md b/README.md
index 3476fda..a47c517 100644
--- a/README.md
+++ b/README.md
@@ -117,6 +117,8 @@ The other methods available are:
 
 * `inline($type = 'jpg')`: returns the HTML inlinable base64 string (see `demo/inline.php`)
 
+* `getResolution($type = 'both')`: returns the resolution of picture in DPI. Only available for >= PHP 7. Other $type options: `X` for horizontal resolution, `Y` for vertical resolution, `both` for the both.
+
 You can also create image from scratch using:
 
 ```php
@@ -138,6 +140,20 @@ You can save the image to an explicit file using `save($file, $type = 'jpg', $qu
 
 You can also get the contents of the image using `get($type = 'jpg', $quality = 80)`, which will return the binary contents of the image
 
+## Converter
+
+Converter allow you to convert centimeters to pixels, inch to pixels... using defined resolution in DPI.
+
+The following static method are available:
+
+* `cmToPixels($cm, $resolution = 96)`: convert centimeters to pixels.
+
+* `inchToPixels($cm, $resolution = 96)`: convert inch to pixels.
+
+* `pixelsToCm($cm, $resolution = 96)`: convert pixels to centimeters.
+
+* `pixelsToInch($cm, $resolution = 96)`: convert pixels to inch.
+
 ## Using cache
 
 Each operation above is not actually applied on the opened image, but added in an operations