feat[next]: Integration of concat_where #1713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tehrengruber
force-pushed
the
GTIR_concat_where
branch
from
71026ff to
05e74c2
Compare
tehrengruber
changed the title
…pressions connected by logical operators (they are resolved by NestConcatWheres): running fine in roundtrip_default, gtfn_run_gtfn and gtfn_run_gtfn_imperative
…PMAP-LES, DerefCond is still a draft, but works for the tested cases
havogt
reviewed
Jul 10, 2025
havogt
reviewed
Jul 10, 2025
egparedes
approved these changes
Jul 10, 2025
Contributor
egparedes
left a comment
egparedes
left a comment
There was a problem hiding this comment.
LGTM (only very minor code style comments)
tests/next_tests/unit_tests/iterator_tests/transforms_tests/test_collapse_tuple.py
Show resolved
Hide resolved
Contributor
|
Moving the previous description to a comment: Description will follow. TODO
Tasks that can be picked up by others:
Potential splitting into multiple PRs when someone picks up a task:
|
havogt
changed the title
edopao
added a commit
that referenced
this pull request
Jul 14, 2025
Lowering to SDFG of `concat_where` primitive, follows GTIR PR #1713. Test coverage provided in previous PR.
philip-paul-mueller
pushed a commit
to philip-paul-mueller/gt4py
that referenced
this pull request
Jul 15, 2025
In previous commits the following pieces where already added: - GridTools#1998 - GridTools#2065 In this PR, `concat_where` tests are added and transformations are integrated. Currently, the feature is disabled for embedded (GridTools#2127) and DaCe (PR will be opened once this is merged). Details: - constant folding for `InfinityLiteral`s is added - various tuning to passes for `index`, `concat_where` builtins and `InfinityLiteral` - cases: field constructors now accept `Domain`s (instead of `dict[Dimension, int]) --------- Co-authored-by: Hannes Vogt <[email protected]> Co-authored-by: Till Ehrengruber <[email protected]> Co-authored-by: Edoardo Paone <[email protected]>
philip-paul-mueller
pushed a commit
to philip-paul-mueller/gt4py
that referenced
this pull request
Jul 15, 2025
Lowering to SDFG of `concat_where` primitive, follows GTIR PR GridTools#1713. Test coverage provided in previous PR.
stubbiali
pushed a commit
to stubbiali/gt4py
that referenced
this pull request
Aug 19, 2025
…ridTools#1998) GTIR concat_where frontend parts extracted from GridTools#1713. Credits to @SF-N and @tehrengruber . This PR removes the support for chained comparisons like `field_a < field_b < field_c` which cannot be supported in embedded (same as `0 < Dim < 42`) because it translates to a boolean scalar comparison as it is evaluated as `(field_a < field_b) and (field_b < field_c)` with `and` instead of `&`. --------- Co-authored-by: tehrengruber <[email protected]>
stubbiali
pushed a commit
to stubbiali/gt4py
that referenced
this pull request
Aug 19, 2025
…ols#2094) Some scalar arguments of a lambda nested SDFG were not represented as symbols, although used in domain symbolic expressions. The unittest `test_concat_where.py:test_lap_like` In the `concat_where` PR (GridTools#1713) was failing in lowering to SDFG because of this bug.
stubbiali
pushed a commit
to stubbiali/gt4py
that referenced
this pull request
Aug 19, 2025
In previous commits the following pieces where already added: - GridTools#1998 - GridTools#2065 In this PR, `concat_where` tests are added and transformations are integrated. Currently, the feature is disabled for embedded (GridTools#2127) and DaCe (PR will be opened once this is merged). Details: - constant folding for `InfinityLiteral`s is added - various tuning to passes for `index`, `concat_where` builtins and `InfinityLiteral` - cases: field constructors now accept `Domain`s (instead of `dict[Dimension, int]) --------- Co-authored-by: Hannes Vogt <[email protected]> Co-authored-by: Till Ehrengruber <[email protected]> Co-authored-by: Edoardo Paone <[email protected]>
stubbiali
pushed a commit
to stubbiali/gt4py
that referenced
this pull request
Aug 19, 2025
Lowering to SDFG of `concat_where` primitive, follows GTIR PR GridTools#1713. Test coverage provided in previous PR.
tehrengruber
added a commit
to tehrengruber/gt4py
that referenced
this pull request
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous commits the following pieces where already added:
In this PR,
concat_wheretests are added and transformations are integrated. Currently, the feature is disabled for embedded (#2127) and DaCe (PR will be opened once this is merged).Details:
InfinityLiterals is addedindex,concat_wherebuiltins andInfinityLiteralDomains (instead of `dict[Dimension, int])