Skip to content

Conversation

@tehrengruber
Copy link
Contributor

No description provided.

@tehrengruber tehrengruber requested a review from havogt June 17, 2025 11:27
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a small test. Should be easy to extend the one in test_scan, by putting the concat_where instead of iteration the smaller domain.

@havogt
Copy link
Contributor

havogt commented Jul 2, 2025

After thinking about it again this workaround makes cases work that are semantically wrong, but we don't have a nice way to express it semantically correct. So tests for this case should actually not necessarily pass. We should document this very clearly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants