Skip to content

bug[next]: Fix OOB access in scan operator #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tehrengruber wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bug[next]: Fix OOB access in scan operator #2081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/gt4py/next/ffront/foast_to_gtir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from gt4py.next.ffront.stages import AOT_FOP, FOP
from gt4py.next.iterator import ir as itir
from gt4py.next.iterator.ir_utils import ir_makers as im
from gt4py.next.iterator.transforms import inline_lambdas
from gt4py.next.otf import toolchain, workflow
from gt4py.next.type_system import type_info, type_specifications as ts

Expand Down Expand Up @@ -134,11 +135,15 @@ def visit_ScanOperator(
func_definition: itir.FunctionDefinition = self.visit(node.definition, **kwargs)
new_body = func_definition.expr

stencil_args: list[itir.Expr] = []
assert not node.type.definition.pos_only_args and not node.type.definition.kw_only_args
for param in func_definition.params[1:]:
new_body = im.let(param.id, im.deref(param.id))(new_body)
stencil_args.append(im.ref(param.id))
stencil_args: list[itir.Expr] = [im.ref(param.id) for param in func_definition.params[1:]]
new_body = im.let(
*((param.id, im.deref(param.id)) for param in func_definition.params[1:])
)(new_body)
# Derefing the iterators directly in the let may lead to out-of-bounds access. Force inline
# them here such that they can be guarded by an if.
# TODO(tehrengruber): This should be fixed on the conceptual level when reworking the scan.
new_body = inline_lambdas.inline_lambda(new_body)

definition = itir.Lambda(params=func_definition.params, expr=new_body)

Expand Down