Skip to content

[FEATURE] "Burn After Time Mode" is confusing #524

@lgrn

Description

@lgrn

Description

When adding a secret, I select "Expiration" and "Max Views", let's say 7 days and 2 views.

The "Expiration" value has the following explanatory text:

Set how long the secret should be available

Intuitively, I expect this to work in the following way:

  • 7 days pass, or the secret is viewed 2 times
  • The secret is deleted

Then there is the option for "Burn after time expires":

The secret will be destroyed after the time expires, regardless of how many times it's viewed.

I think it could be clarified what this actually means. More specifically:

  1. Is the default behavior that secrets are not destroyed when they expire? If so, it's my opinion that the "Expiration" value should have a clear warning that expiry will not delete secrets, something that definitely could be assumed.

  2. What is meant by "regardless of how many times it's viewed"? Will exceeding amount of views always delete ("burn") a secret, but exceeding the expiry will not? If so, both the "Expiration" and "Max Views" should in my opinion clearly explain this.

  3. I notice that when enabling "Burn after time expires", the "Max views" value disappears. So is this just a way to not have to set an extremely high "Max views" value and only go by time? If so, it seems completely backwards instead of just making the "expiration" and "max views" criteria optional per secret.

Why does this option exist?

edit: Also, I think it would be good to decide on one word to describe a secret being destroyed, instead of mixing terms like "burned", "destroyed", "expired", it's very confusing if they don't actually mean different things.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions