Skip to content

Commit dbf03e0

Browse files
youdongguoyoudongguotimholy
authored
fix c=0, g=0 (#29)
* fix c=0, g=0 Co-authored-by: Tim Holy <tim.holy@gmail.com> --------- Co-authored-by: youdongguo <1010705897@qq.com> Co-authored-by: Tim Holy <tim.holy@gmail.com>
1 parent aa69c63 commit dbf03e0

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/NMFMerge.jl

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,13 @@ function solve_remix(S, T, id1, id2)
148148
b = sqrt(τ^2/4-δ)
149149
λ_max = τ/2+b
150150
λ_min = δ/λ_max
151-
ξ = (h1h1-h2h2+2b)/((h1h2+c*h2h2)*2)
152-
u = (ξ, 1)./sqrt(1+2ξ*c+ξ^2)
151+
den = (h1h2+c*h2h2)*2
152+
if iszero(den)
153+
u = h1h1 >= h2h2 ? (one(c), zero(c)) : (zero(c), one(c))
154+
else
155+
ξ = (h1h1-h2h2+2b)/den
156+
u = (ξ, 1)./sqrt(1+2ξ*c+ξ^2)
157+
end
153158
return c, λ_min, u
154159
end
155160

0 commit comments

Comments
 (0)