Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump ruby-lsp from 0.23.5 to 0.23.6 in /Library/Homebrew #19113

Merged
merged 3 commits into from
Jan 18, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 17, 2025

Bumps ruby-lsp from 0.23.5 to 0.23.6.

Release notes

Sourced from ruby-lsp's releases.

v0.23.6

✨ Enhancements

🐛 Bug Fixes

Commits
  • bbd0c84 Check if RuboCop is available before searching for add-on (#3071)
  • 542e896 Bump extension version to v0.8.18
  • 931e926 Upgrade RuboCop related gems and Tapioca (#3069)
  • dcb4bbe Request diagnostic refresh when RuboCop configs change (#3041)
  • 125f722 Change our internal RuboCop integration identifier (#3067)
  • f0d7f6c Prevent double activation when multiple documents are opened (#3070)
  • 60390ec Update GUESSED_TYPES_URL (#3068)
  • 7fb9adf Use local executables when working on the Ruby LSP (#3065)
  • 77337ef Fix singleton indexing under compact namespaces (#3062)
  • 2e099da Add references support for instance variables (#2787)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Bumping Gemfile dependencies ruby Pull requests that update Ruby code labels Jan 17, 2025
@p-linnane p-linnane marked this pull request as draft January 18, 2025 04:51
@p-linnane
Copy link
Member

p-linnane commented Jan 18, 2025

@dduugg Can you take a look here? Running the Vendor Gems workflow is including a ton of stuff now. Thinking it has something to do with the .gitignore work that was done recently.

EDIT: Opened #19115 to revert in order to unblock CI.

@p-linnane
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/bundler/Library/Homebrew/ruby-lsp-0.23.6 branch from f452269 to e4bd079 Compare January 18, 2025 04:57
@p-linnane
Copy link
Member

@dependabot recreate

Bumps [ruby-lsp](https://github.com/Shopify/ruby-lsp) from 0.23.5 to 0.23.6.
- [Release notes](https://github.com/Shopify/ruby-lsp/releases)
- [Commits](Shopify/ruby-lsp@v0.23.5...v0.23.6)

---
updated-dependencies:
- dependency-name: ruby-lsp
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/Library/Homebrew/ruby-lsp-0.23.6 branch from cccf3f6 to 9bb63b6 Compare January 18, 2025 05:18
@p-linnane p-linnane marked this pull request as ready for review January 18, 2025 05:18
@p-linnane p-linnane enabled auto-merge January 18, 2025 05:21
@p-linnane p-linnane added this pull request to the merge queue Jan 18, 2025
@dduugg
Copy link
Member

dduugg commented Jan 18, 2025

@dduugg Can you take a look here? Running the Vendor Gems workflow is including a ton of stuff now. Thinking it has something to do with the .gitignore work that was done recently.

EDIT: Opened #19115 to revert in order to unblock CI.

Looks like I botched the partial inclusion of mechanize, due to misreading the path. Thanks for reverting, I can give it another go and test by running the workflow on the re-attempt PR.

Merged via the queue into master with commit 78706b5 Jan 18, 2025
29 checks passed
@p-linnane p-linnane deleted the dependabot/bundler/Library/Homebrew/ruby-lsp-0.23.6 branch January 18, 2025 05:39
@Bo98
Copy link
Member

Bo98 commented Jan 18, 2025

It's not just mechanize that's a problem - it's not even including vendored gems correctly as the directory gets blanked on updates.

@dduugg
Copy link
Member

dduugg commented Jan 18, 2025

It's not just mechanize that's a problem - it's not even including vendored gems correctly as the directory gets blanked on updates.

@Bo98, could you point me to what your describing? I was comparing 0fefd61 to 310f5bf which appear to differ only by the former including the full contents of Library/Homebrew/vendor/gems/mechanize-2.14.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Bumping Gemfile dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants